[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

shafik added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp:236 if (count) -m_name = ConstString((char *)buffer_sp->GetBytes()); +m_name = ConstString((const char *)buffer_sp->GetBytes()); else

[Lldb-commits] [lldb] f9ac13a - [lldb] Remove remaining calls to DataBufferLLVM::GetChars

Author: Jonas Devlieghere Date: 2022-04-01T17:43:05-07:00 New Revision: f9ac13a8f1edcdc540491c5e917ac5d31e07ef3b URL: https://github.com/llvm/llvm-project/commit/f9ac13a8f1edcdc540491c5e917ac5d31e07ef3b DIFF:

[Lldb-commits] [PATCH] D122946: Prevent HostInfoBase::GetAugmentedArchSpec() from attaching "unknown" environments

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Fun stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122946/new/ https://reviews.llvm.org/D122946 ___ lldb-commits

[Lldb-commits] [lldb] 2165c36 - [lldb] Return a DataBuffer from FileSystem::CreateDataBuffer (NFC)

Author: Jonas Devlieghere Date: 2022-04-01T17:31:20-07:00 New Revision: 2165c36be44589a0d78c6ac23389d69a5d390dc5 URL: https://github.com/llvm/llvm-project/commit/2165c36be44589a0d78c6ac23389d69a5d390dc5 DIFF:

[Lldb-commits] [PATCH] D122946: Prevent HostInfoBase::GetAugmentedArchSpec() from attaching "unknown" environments

aprantl created this revision. aprantl added reviewers: JDevlieghere, jasonmolenda. Herald added a project: All. aprantl requested review of this revision. Messy stuff. Environments are optional and a missing environment is distinct from the default "unknown" environment enumerator. Also the

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

JDevlieghere updated this revision to Diff 419881. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Implement Pavel's suggestion of mapping ELF files as writable and casting to a WritableMemoryBuffer. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b5900e6 - clang-format HostInfoBase.cpp

Author: Adrian Prantl Date: 2022-04-01T15:55:23-07:00 New Revision: b5900e64c2db41acd230522c02d0845c7e443c21 URL: https://github.com/llvm/llvm-project/commit/b5900e64c2db41acd230522c02d0845c7e443c21 DIFF: https://github.com/llvm/llvm-project/commit/b5900e64c2db41acd230522c02d0845c7e443c21.diff

[Lldb-commits] [PATCH] D122944: [lldb] Prevent object file plugins from messing with the data buffer if they don't match

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. While discussing D122856 with Pavel on IRC, he pointed out that the current design

[Lldb-commits] [PATCH] D122943: [LLDB][NativePDB] Fix a crash when S_DEFRANGE_SUBFIELD_REGISTER descirbes a simple type

zequanwu created this revision. zequanwu added reviewers: rnk, labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When a variable is simple type and has 64 bits, the debug info may look like the

[Lldb-commits] [PATCH] D122568: [lldb] correct comment in deterministic build test

int3 requested changes to this revision. int3 added a comment. This revision now requires changes to proceed. Clearing queue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122568/new/ https://reviews.llvm.org/D122568

[Lldb-commits] [PATCH] D122912: Simplify ArchSpec::IsFullySpecifiedTriple() (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:1399 bool ArchSpec::IsFullySpecifiedTriple() const { - const auto _specified_triple = GetTriple(); - - bool user_triple_fully_specified = false; - - if ((user_specified_triple.getOS() !=

[Lldb-commits] [PATCH] D122912: Simplify ArchSpec::IsFullySpecifiedTriple() (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG942c21ed23dc: Simplify ArchSpec::IsFullySpecifiedTriple() (NFC) (authored by aprantl). Herald added a project: LLDB.

[Lldb-commits] [lldb] 942c21e - Simplify ArchSpec::IsFullySpecifiedTriple() (NFC)

Author: Adrian Prantl Date: 2022-04-01T14:16:36-07:00 New Revision: 942c21ed23dcba11a156cbaad4a74348dc6fdcff URL: https://github.com/llvm/llvm-project/commit/942c21ed23dcba11a156cbaad4a74348dc6fdcff DIFF: https://github.com/llvm/llvm-project/commit/942c21ed23dcba11a156cbaad4a74348dc6fdcff.diff

[Lldb-commits] [PATCH] D122867: [trace][intel pt] Handle better tsc in the decoder

jj10306 accepted this revision. jj10306 added a comment. Looks good Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:248 - DecodeInstructions(*decoder, decoded_thread_sp); + DecodeInstructions(*decoder, *decoded_thread_sp.get());

[Lldb-commits] [PATCH] D122867: [trace][intel pt] Handle better tsc in the decoder

wallace updated this revision to Diff 419813. wallace added a comment. - Address comments - Also now using Format instead of Printf, which more idiomatic in this repo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122867/new/

[Lldb-commits] [lldb] c50eec4 - [LLDB] Add require x86 for NativePdb Test.

Author: Zequan Wu Date: 2022-04-01T10:39:06-07:00 New Revision: c50eec400c0edc73eec3c9e97b5c030492cb787f URL: https://github.com/llvm/llvm-project/commit/c50eec400c0edc73eec3c9e97b5c030492cb787f DIFF: https://github.com/llvm/llvm-project/commit/c50eec400c0edc73eec3c9e97b5c030492cb787f.diff

[Lldb-commits] [PATCH] D122867: [trace][intel pt] Handle better tsc in the decoder

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:120 + +void DecodedThread::ReportTscError(int libipt_error_code) { m_tsc_errors++; } + jj10306 wrote: > The parameter is unused, is there a reason to keep this or

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. Thanks for reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] c45975c - [LLDB][NativePDB] Create inline function decls

Author: Zequan Wu Date: 2022-04-01T10:06:31-07:00 New Revision: c45975cbf96aad53f24c71f7e1a1549a275d245d URL: https://github.com/llvm/llvm-project/commit/c45975cbf96aad53f24c71f7e1a1549a275d245d DIFF: https://github.com/llvm/llvm-project/commit/c45975cbf96aad53f24c71f7e1a1549a275d245d.diff

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45975cbf96a: [LLDB][NativePDB] Create inline function decls (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/

[Lldb-commits] [PATCH] D122867: [trace][intel pt] Handle better tsc in the decoder

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:236-238 + /// Notify this class that the last added instruction or error has + /// an associated TSC. + void ReportTscForLastInstruction(uint64_t tsc); nit: When I

[Lldb-commits] [PATCH] D122912: Simplify ArchSpec::IsFullySpecifiedTriple() (NFC)

aprantl added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:1399 bool ArchSpec::IsFullySpecifiedTriple() const { - const auto _specified_triple = GetTriple(); - - bool user_triple_fully_specified = false; - - if ((user_specified_triple.getOS() !=

[Lldb-commits] [PATCH] D122867: [trace][intel pt] Handle better tsc in the decoder

jj10306 added a comment. The changes to the decoder look sound, just left two questions related to it and a couple other nits. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:120 + +void DecodedThread::ReportTscError(int libipt_error_code) { m_tsc_errors++; }

[Lldb-commits] [PATCH] D122898: [lldb] Move host platform implementations into the base class

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122898/new/ https://reviews.llvm.org/D122898

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

This revision was automatically updated to reflect the committed changes. Closed by commit rGca922a3559d7: [intelpt] Refactor timestamps out of `IntelPTInstruction` (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/

[Lldb-commits] [lldb] ca922a3 - [intelpt] Refactor timestamps out of `IntelPTInstruction`

Author: Alisamar Husain Date: 2022-04-01T21:51:42+05:30 New Revision: ca922a3559d7c537fefbf023b6c9fd0f8ff0ed9d URL: https://github.com/llvm/llvm-project/commit/ca922a3559d7c537fefbf023b6c9fd0f8ff0ed9d DIFF:

[Lldb-commits] [PATCH] D122912: Simplify ArchSpec::IsFullySpecifiedTriple() (NFC)

JDevlieghere added a comment. LGTM if the answer to both my questions is "yes". Comment at: lldb/source/Utility/ArchSpec.cpp:1399 bool ArchSpec::IsFullySpecifiedTriple() const { - const auto _specified_triple = GetTriple(); - - bool user_triple_fully_specified = false; - -

[Lldb-commits] [PATCH] D122882: Add JSONGenerator::DumpBinaryEscaped method in debugserver, update most callers to use this, skip escaping step

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/JSONGenerator.h:233-247 + std::string quoted; + const size_t strsize = m_value.size(); + for (size_t i = 0; i < strsize; ++i) { +char ch = m_value[i]; +if (ch == '"') +

[Lldb-commits] [PATCH] D122912: Simplify ArchSpec::IsFullySpecifiedTriple() (NFC)

aprantl created this revision. aprantl added reviewers: jasonmolenda, JDevlieghere. Herald added a project: All. aprantl requested review of this revision. I found this function somewhat hard to read and removed a few entirely redundant checks and converted it to early exits.

[Lldb-commits] [PATCH] D122859: [trace] Show ideas for the main interfaces for new HTR

davidca added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:73 + // trace + struct HTRInMemoryBlock { + Just like in the original HTR design, if you remove this abstraction, and store indices as indices in each layer, then you don't have

[Lldb-commits] [PATCH] D122898: [lldb] Move host platform implementations into the base class

labath created this revision. labath added reviewers: JDevlieghere, jingham. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. About half of our host platform code was implemented in the Platform class, while the rest was it RemoteAwarePlatform.

[Lldb-commits] [PATCH] D122680: Add a setting to force overwriting commands in "command script add"

labath added inline comments. Comment at: lldb/source/Commands/CommandObjectCommands.cpp:1650 std::string m_short_help; - bool m_overwrite = false; + bool m_overwrite = eLazyBoolCalculate; ScriptedCommandSynchronicity m_synchronicity = This doesn't seem

[Lldb-commits] [lldb] a1901f5 - [LLDB] Fix TestJobControl.py decorators import

Author: Muhammad Omair Javaid Date: 2022-04-01T14:13:11+05:00 New Revision: a1901f501ca971e532f8386b479e13967cd32b93 URL: https://github.com/llvm/llvm-project/commit/a1901f501ca971e532f8386b479e13967cd32b93 DIFF:

[Lldb-commits] [lldb] c103eac - [LLDB] Skip TestJobControl.py AArch64/Arm Linux

Author: Muhammad Omair Javaid Date: 2022-04-01T13:58:20+05:00 New Revision: c103eac9d8596cf154ccf5249f5c919badd831d6 URL: https://github.com/llvm/llvm-project/commit/c103eac9d8596cf154ccf5249f5c919badd831d6 DIFF:

[Lldb-commits] [PATCH] D122882: Add JSONGenerator::DumpBinaryEscaped method in debugserver, update most callers to use this, skip escaping step

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, jingham. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Most packets which return JSON use JSONGenerator::Dump

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 419656. zrthxn edited the summary of this revision. zrthxn added a comment. The difference in memory usage is appreciable with large number of instructions, as shown below # Before (with current metrics, total memory does not include raw trace size)

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good thanks. I didn't really check the pdb code, but it looks like @rnk already reviewed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D122856: [lldb] Refactor DataBuffer so we can map files as read-only

labath added a comment. Yeah, I tried doing this (well, i used `const DataBuffer` to represent read-only data) last time this topic came up, and ran into the same problem. Since there was no pressing need for it, I put the patch away. I think the best way to fix this is to allow the object

[Lldb-commits] [PATCH] D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc04fdfa17e6d: Update callers to SendPacket with std::strings to not devolve to c-strs (authored by jasonmolenda).

[Lldb-commits] [lldb] c04fdfa - Update callers to SendPacket with std::string's to not devolve to c-strs

Author: Jason Molenda Date: 2022-03-31T23:46:44-07:00 New Revision: c04fdfa17e6df33f6805f083bee22f5901d88344 URL: https://github.com/llvm/llvm-project/commit/c04fdfa17e6df33f6805f083bee22f5901d88344 DIFF: https://github.com/llvm/llvm-project/commit/c04fdfa17e6df33f6805f083bee22f5901d88344.diff

[Lldb-commits] [PATCH] D122848: Reduce extraneous temp strings in debugserver, free objects when they're not longer needed

jasonmolenda updated this revision to Diff 419637. jasonmolenda added a comment. Address Jonas' feedback by removing the parts of the patch that freed the ostringstream's after binary-escaped versions of them had been generated. Instead I'll add DumpEscaped methods to the JSONGenerator class.