[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

kastiglione added a comment. nice, I've wanted this too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127355/new/ https://reviews.llvm.org/D127355 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127378: [lldb] Use assertState in more tests (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow to D127355 , converting

[Lldb-commits] [lldb] aaaf8e4 - Add help text for "breakpoint name", describing the feature more fully.

Author: Jim Ingham Date: 2022-06-08T16:55:53-07:00 New Revision: aaaf8e4c409f080f35ea227b20dc6ac8a45c2fa4 URL: https://github.com/llvm/llvm-project/commit/aaaf8e4c409f080f35ea227b20dc6ac8a45c2fa4 DIFF: https://github.com/llvm/llvm-project/commit/aaaf8e4c409f080f35ea227b20dc6ac8a45c2fa4.diff

[Lldb-commits] [lldb] d671002 - [LLDB][NativePDB] Fix several crashes when parsing debug info.

Author: Zequan Wu Date: 2022-06-08T16:41:23-07:00 New Revision: d6710023e396aa55f92e3906755d68b06489d95f URL: https://github.com/llvm/llvm-project/commit/d6710023e396aa55f92e3906755d68b06489d95f DIFF: https://github.com/llvm/llvm-project/commit/d6710023e396aa55f92e3906755d68b06489d95f.diff

[Lldb-commits] [PATCH] D127362: [lldb/crashlog] Show help when the command is called without any argument

mib updated this revision to Diff 435383. mib added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127362/new/ https://reviews.llvm.org/D127362 Files: lldb/examples/python/crashlog.py lldb/test/Shell/ScriptInterpreter/Python/Crashlog/no-args.test Index:

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

This revision was automatically updated to reflect the committed changes. Closed by commit rGce825e46743b: [lldb] Add assertState function to the API test suite (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ce825e4 - [lldb] Add assertState function to the API test suite

Author: Jonas Devlieghere Date: 2022-06-08T16:16:38-07:00 New Revision: ce825e46743be3e402820484bef639d12deefc2a URL: https://github.com/llvm/llvm-project/commit/ce825e46743be3e402820484bef639d12deefc2a DIFF:

[Lldb-commits] [PATCH] D127362: [lldb/crashlog] Show help when the command is called without any argument

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with a test :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127362/new/ https://reviews.llvm.org/D127362

[Lldb-commits] [PATCH] D127362: [lldb/crashlog] Show help when the command is called without any argument

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the `crashlog` command behavior to print the help message if no argument was

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Awesome! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127355/new/ https://reviews.llvm.org/D127355 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

JDevlieghere updated this revision to Diff 435372. JDevlieghere added a comment. Implement Ismail's suggestion: AssertionError: stopped (5) != exited (10) : Got exit event CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127355/new/ https://reviews.llvm.org/D127355 Files:

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

mib added a comment. Pretty cool but it would be nice to have the following formatting: "AssertionError: stopped (5) != exited (10) : message" ... I feel like it's easier to read this way CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127355/new/ https://reviews.llvm.org/D127355

[Lldb-commits] [PATCH] D127331: [lldb] Update TestModuleLoadedNotifys.py for macOS Ventura

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b55eb80734: [lldb] Update TestModuleLoadedNotifys.py for macOS Ventura (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] c9b55eb - [lldb] Update TestModuleLoadedNotifys.py for macOS Ventura

Author: Jonas Devlieghere Date: 2022-06-08T15:33:33-07:00 New Revision: c9b55eb80734a6a840d3210796149f9042ff60c5 URL: https://github.com/llvm/llvm-project/commit/c9b55eb80734a6a840d3210796149f9042ff60c5 DIFF:

[Lldb-commits] [PATCH] D127016: [lldb] Prevent crash due to reading memory from page zero.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f02dd34f226: [lldb/Commands] Prevent crash due to reading memory from page zero. (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D127016?vs=434172=435359#toc Repository:

[Lldb-commits] [lldb] 0f02dd3 - [lldb/Commands] Prevent crash due to reading memory from page zero.

Author: Chelsea Cassanova Date: 2022-06-08T18:10:41-04:00 New Revision: 0f02dd34f22650d8af0070e7ad21632525e33da8 URL: https://github.com/llvm/llvm-project/commit/0f02dd34f22650d8af0070e7ad21632525e33da8 DIFF:

[Lldb-commits] [PATCH] D127355: [lldb] Add assertState function

JDevlieghere created this revision. JDevlieghere added reviewers: kastiglione, mib. Herald added a project: All. JDevlieghere requested review of this revision. Add a function to make it easier to debug a test failure caused by an unexpected state. Currently, tests are using `assertEqual` which

[Lldb-commits] [PATCH] D127336: [lldb] Remove default argument from getBuildArtifact

JDevlieghere created this revision. Herald added a project: All. JDevlieghere requested review of this revision. Remove default argument from lldbtest.getBuildArtifact. https://reviews.llvm.org/D127336 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [PATCH] D127331: [lldb] Update TestModuleLoadedNotifys.py for macOS Ventura

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127331/new/ https://reviews.llvm.org/D127331 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D127331: [lldb] Update TestModuleLoadedNotifys.py for macOS Ventura

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. On macOS Ventura and later, dyld and the main binary will be loaded again when dyld moves itself into the shared cache. Update the test

[Lldb-commits] [lldb] 4636b93 - [lldb] Improve error reporting from TestAppleSimulatorOSType.py

Author: Jonas Devlieghere Date: 2022-06-08T11:47:26-07:00 New Revision: 4636b93044faf1fbf54139e872af4856adafe435 URL: https://github.com/llvm/llvm-project/commit/4636b93044faf1fbf54139e872af4856adafe435 DIFF:

[Lldb-commits] [PATCH] D127252: [lldb] Use objc_getRealizedClassList_trylock if available

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc43703481d8: [lldb] Use objc_getRealizedClassList_trylock on macOS Ventura and later (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D127252?vs=434941=435269#toc

[Lldb-commits] [lldb] fc43703 - [lldb] Use objc_getRealizedClassList_trylock on macOS Ventura and later

Author: Jonas Devlieghere Date: 2022-06-08T11:34:27-07:00 New Revision: fc43703481d858351a72d7ea6f439f4f682ba351 URL: https://github.com/llvm/llvm-project/commit/fc43703481d858351a72d7ea6f439f4f682ba351 DIFF:

[Lldb-commits] [PATCH] D127252: [lldb] Use objc_getRealizedClassList_trylock if available

JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Thanks Jim, I've addressed your comments in the final commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127252/new/ https://reviews.llvm.org/D127252

[Lldb-commits] [PATCH] D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server.

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:40 +IntelPTCollector::FetchPerfTscConversionParameters() { + if (!m_cached_tsc_conversion) { +if (Expected tsc_conversion = jj10306 wrote: > Don't we want to

[Lldb-commits] [PATCH] D127001: [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case

wallace updated this revision to Diff 435263. wallace added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127001/new/ https://reviews.llvm.org/D127001 Files: lldb/include/lldb/Target/Trace.h

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3567278 , @dblaikie wrote: >> Then I still don't know what the problem is supposed to be. If the StringMap >> hash implementation ever changes, the necessary LLDB rebuild will detect >> this, the relevant LLDB parts

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham updated this revision to Diff 435248. jingham added a comment. Fixed the option definition to specify this is a bkpt_id_list not a breakpoint id (since that's what it is now that we're using the breakpoint id list parser), and removed the verbiage that that made redundant. Added one

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

dblaikie added a comment. >>> If the theory is that this should keep working even with the library >>> changing without LLDB rebuild, then as I wrote above that theory needs >>> double-checking first. And additionally a good question to ask would be if >>> it's really a good idea to do

[Lldb-commits] [PATCH] D127252: [lldb] Use objc_getRealizedClassList_trylock if available

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. One grammatical correction and a couple of questions. But I'm also fine with the way it is. Comment at:

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun updated this revision to Diff 435214. alvinhochun edited the summary of this revision. alvinhochun added a comment. This revision is now accepted and ready to land. Added the fix to the Minidump find-module test, also updated the commit message. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3202a592317: [lldb] Parse the dotest output to determine the most appropriate result code (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 37028d3 - [lldb] Update TestMultithreaded to report FAIL for a non-zero exit code

Author: Jonas Devlieghere Date: 2022-06-08T08:58:15-07:00 New Revision: 37028d3ea7fc9fa7e640c91faa9c347808598dd6 URL: https://github.com/llvm/llvm-project/commit/37028d3ea7fc9fa7e640c91faa9c347808598dd6 DIFF:

[Lldb-commits] [lldb] d3202a5 - [lldb] Parse the dotest output to determine the most appropriate result code

Author: Jonas Devlieghere Date: 2022-06-08T08:58:15-07:00 New Revision: d3202a5923173bc69767d86e605b012ad09de2a2 URL: https://github.com/llvm/llvm-project/commit/d3202a5923173bc69767d86e605b012ad09de2a2 DIFF:

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

kastiglione accepted this revision. kastiglione added inline comments. Comment at: lldb/test/API/lldbtest.py:126 +# being stable for ties. +lit_results.sort(reverse=True, key=operator.itemgetter(0)) +return lit_results[0][1], output you

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

JDevlieghere added a comment. In D127258#3565279 , @kastiglione wrote: > instead of reducing and picking returning a single result, can we return the > raw counts and then report the totals of the counts? No, the lit test format does not support that.

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

JDevlieghere updated this revision to Diff 435170. JDevlieghere added a comment. Mark the test as FAIL or PASS if there's at least one test that respectively failed or passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127258/new/ https://reviews.llvm.org/D127258 Files:

[Lldb-commits] [PATCH] D127291: [lldb] [llgs] Add a test for detach-all packet

mgorny updated this revision to Diff 435162. mgorny added a comment. Remove leftover local `fork_regex`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127291/new/ https://reviews.llvm.org/D127291 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

[Lldb-commits] [PATCH] D127290: [lldb] [llgs] Refactor fork/vfork tests, verify state

mgorny updated this revision to Diff 435160. mgorny added a comment. Remove leftover local `fork_regex`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127290/new/ https://reviews.llvm.org/D127290 Files: lldb/test/API/tools/lldb-server/TestGdbRemoteFork.py Index:

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

alvinhochun added a comment. Thanks @mstorsjo for answering for me. >> 4. What more information can we get from debug info in this case? DWARF may >> not be a good guess as we can generate it for MSVC abi as well. > > Exactly, one could use presence of DWARF as a heuristic hint for this, but >

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D127291: [lldb] [llgs] Add a test for detach-all packet

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Add a test verifying that plain 'D' packet correctly detaches all processes. Sponsored by: The FreeBSD

[Lldb-commits] [PATCH] D127290: [lldb] [llgs] Refactor fork/vfork tests, verify state

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Refactor the fork and vfork tests to reuse the code better, avoid unnecessary regexps and avoid

[Lldb-commits] [PATCH] D127289: [lldb] [llgs] Refactor SendStopReplyPacketForThread for multiprocess

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Refactor SendStopReplyPacketForThread() to accept process instance as a parameter rather than use

[Lldb-commits] [PATCH] D126702: [lldb] Fix TCPSocket::Connect when getaddrinfo returns multiple addrs

ddiproietto added a comment. I do not have commit access, can someone commit this for me, please? Also, would it be possible for this to be cherry picked somewhere (apologies, I'm not familiar with the LLVM branching model), for an eventual 14.0.1 release? Thanks! Repository: rG LLVM

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

mstorsjo added a comment. In D127048#3565557 , @omjavaid wrote: > I am not fully familiar with PE/COFF but lets try to get this merged. For > starters I have a couple of questions here: > > 1. This rev apparently assumes x86_64 only but what about

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

omjavaid added a comment. I am not fully familiar with PE/COFF but lets try to get this merged. For starters I have a couple of questions here: 1. This rev apparently assumes x86_64 only but what about Arm/AArch64? 2. If we have DLLs what abi setting they ll follow the one set by the user or