[Lldb-commits] [PATCH] D127586: [lldb][Interpreter] Add newline terminal to one-line script calls

mib added a comment. A bit late to this ... thanks for your fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127586/new/ https://reviews.llvm.org/D127586 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127937: [lldb] Add RotatingLogHandler

JDevlieghere created this revision. JDevlieghere added reviewers: labath, kastiglione, mib. Herald added a project: All. JDevlieghere requested review of this revision. Add a log handler that maintains a circular buffer. https://reviews.llvm.org/D127937 Files: lldb/include/lldb/Utility/Log.h

[Lldb-commits] [PATCH] D127586: [lldb][Interpreter] Add newline terminal to one-line script calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9349ef9e6d8: Fix `script -lpython` to handle control flow in one-line commands. (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D127586?vs=436191=437446#toc Repository:

[Lldb-commits] [lldb] e9349ef - Fix `script -lpython` to handle control flow in one-line commands.

Author: Dave Lee Date: 2022-06-15T22:20:48-07:00 New Revision: e9349ef9e6d83aa8900b5e534f1d15fb4d44a33c URL: https://github.com/llvm/llvm-project/commit/e9349ef9e6d83aa8900b5e534f1d15fb4d44a33c DIFF: https://github.com/llvm/llvm-project/commit/e9349ef9e6d83aa8900b5e534f1d15fb4d44a33c.diff

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

This revision was automatically updated to reflect the committed changes. Closed by commit rGe30c493894c4: [lldb] Support non-pointer implicit this/self in… (authored by kastiglione). Herald added a subscriber: Michael137. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e30c493 - [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

Author: Dave Lee Date: 2022-06-15T22:04:02-07:00 New Revision: e30c493894c410825ad7467f4996aca7f613ce81 URL: https://github.com/llvm/llvm-project/commit/e30c493894c410825ad7467f4996aca7f613ce81 DIFF: https://github.com/llvm/llvm-project/commit/e30c493894c410825ad7467f4996aca7f613ce81.diff

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

wallace added a comment. @stella.stamenova, I've just tried that compile command with several versions of gcc, including g++ (GCC) 8.5.0 on CentOS and got no error Sadly I couldn't install 7.3.1. Could you try again in top of tree? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

JDevlieghere updated this revision to Diff 437409. JDevlieghere added a comment. Update unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127922/new/ https://reviews.llvm.org/D127922 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Utility/Log.h

[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, mib, kastiglione. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. This patch introduces the concept of a log handlers. Log handlers allow

[Lldb-commits] [PATCH] D127586: [lldb][Interpreter] Add newline terminal to one-line script calls

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Michael137. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127586/new/

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. In D125943#3586910 , @wallace wrote: > yes, i'm trying to fix it now. Thanks! Thanks! One more to add to the list: FAILED:

[Lldb-commits] [lldb] 1af4561 - [lldb] Skip ScriptInterpreter/Python/exit.test on Windows

Author: Jonas Devlieghere Date: 2022-06-15T15:50:04-07:00 New Revision: 1af4561ee5ed56139b28b75ed7d46df2aeb223cb URL: https://github.com/llvm/llvm-project/commit/1af4561ee5ed56139b28b75ed7d46df2aeb223cb DIFF:

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cde6ac03c2c: [lldb] Dont overwrite quit and exit builtins in the Python interpreter (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 6cde6ac - [lldb] Don't overwrite quit and exit builtins in the Python interpreter

Author: Jonas Devlieghere Date: 2022-06-15T14:53:40-07:00 New Revision: 6cde6ac03c2c1851b1156dd334b87b38fff79f70 URL: https://github.com/llvm/llvm-project/commit/6cde6ac03c2c1851b1156dd334b87b38fff79f70 DIFF:

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. Before this, I didn't realize that `quit`/`exit` worked without being a function call. I think it's unfortunate we have to preserve that, but oh well. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3ba71f1 - Reland "[lldb/Fuzzer] Create ninja target for target fuzzer"

Author: Chelsea Cassanova Date: 2022-06-15T17:37:38-04:00 New Revision: 3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7 URL: https://github.com/llvm/llvm-project/commit/3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7 DIFF:

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

JDevlieghere added a comment. This needs to be moved into the `if(TARGET lldb-target-fuzzer)` clause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

JDevlieghere updated this revision to Diff 437328. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127895/new/ https://reviews.llvm.org/D127895 Files: lldb/source/Interpreter/embedded_interpreter.py

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/test/Shell/ScriptInterpreter/Python/exit.test:1-5 +# RUN: %lldb -o 'script quit' | FileCheck %s --check-prefix SILENT +# RUN: %lldb -o 'script quit()' | FileCheck %s

[Lldb-commits] [lldb] b97b082 - Fix failures

Author: Walter Erquinigo Date: 2022-06-15T13:54:04-07:00 New Revision: b97b082c5a0d2b1d8a4c18865408aad35844016e URL: https://github.com/llvm/llvm-project/commit/b97b082c5a0d2b1d8a4c18865408aad35844016e DIFF:

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3586352 , @dblaikie wrote: > ^ I think it's still worthwhile/necessary to separate LLDB's use case/hashing > algorithm choice from LLVM's so LLVM's code can be changed to be more change > resilient in a way that

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

mib added inline comments. Comment at: lldb/source/Interpreter/embedded_interpreter.py:49-52 +if line == 'exit': +raise LLDBExit +if line == 'quit': +raise LLDBExit kastiglione wrote: > could do: > ``` > if line in ('exit', 'quit'): > ```

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added a comment. > The main thing I am wondering is if it wouldn't be better to (instead of > essentially duplicating the DWARFExpression interface in the > DWARFExpressionList class) somehow split the process of finding the > appropriate expression (for the given PC value or

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 437316. zequanwu marked an inline comment as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files:

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

wallace added a comment. yes, i'm trying to fix it now. Thanks! Il giorno mer 15 giu 2022 alle ore 13:24 Stella Stamenova via Phabricator < revi...@reviews.llvm.org> ha scritto: > stella.stamenova added a comment. > > These changes (the set of [trace][intelpt] changes) broke the windows lldb >

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

kastiglione added inline comments. Comment at: lldb/source/Interpreter/embedded_interpreter.py:49-52 +if line == 'exit': +raise LLDBExit +if line == 'quit': +raise LLDBExit could do: ``` if line in ('exit', 'quit'): ```

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

stella.stamenova added a comment. These changes (the set of [trace][intelpt] changes) broke the windows lldb bot. It's most likely this particular change, but it could be one of the others. Unfortunately, the bot had just been broken by https://reviews.llvm.org/D127882, so it didn't show the

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3749 +return SendErrorResponse(Status("No pending notification to ack")); + m_stop_notification_queue.pop_front(); + if

[Lldb-commits] [lldb] b10579d - Revert "[lldb/Fuzzer] Create ninja target for target fuzzer"

Author: Stella Stamenova Date: 2022-06-15T12:40:33-07:00 New Revision: b10579d0b519571fa7487399d82e1e809fbfe6cb URL: https://github.com/llvm/llvm-project/commit/b10579d0b519571fa7487399d82e1e809fbfe6cb DIFF:

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

jingham added a comment. For some reason I'm not getting mail notifications for review changes, sorry about that. This is certainly better than the original implementation. Among other things, if we find an exact match, we really shouldn't be doing any more inexact matches, so after the

[Lldb-commits] [PATCH] D127895: [lldb] Don't overwrite quit and exit builtins in the interactive python interpreter

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib. Herald added a project: All. JDevlieghere requested review of this revision. The interactive interpreter is overwriting the `exit` and `quit` builtins with an instance of `LLDBQuitter` in order to make `exit` and

[Lldb-commits] [PATCH] D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0a46473c3df: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf… (authored by Walter Erquinigo wall...@fb.com). Herald added a subscriber: Michael137. Repository: rG LLVM

[Lldb-commits] [PATCH] D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f2d49a8e763: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc… (authored by Walter Erquinigo wall...@fb.com).

[Lldb-commits] [PATCH] D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa758205951d3: [trace][intelpt] Support system-wide tracing [9] - Collect and return context… (authored by Walter Erquinigo wall...@fb.com).

[Lldb-commits] [PATCH] D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a92632dc477: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer… (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f56f7fc16bc: [trace][intelpt] Support system-wide tracing [7] - Create a base… (authored by Walter Erquinigo wall...@fb.com). Changed prior to commit:

[Lldb-commits] [lldb] a0a4647 - [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client

Author: Walter Erquinigo Date: 2022-06-15T12:08:00-07:00 New Revision: a0a46473c3df488c9ea63988595cea0bd0521fb4 URL: https://github.com/llvm/llvm-project/commit/a0a46473c3df488c9ea63988595cea0bd0521fb4 DIFF:

[Lldb-commits] [lldb] a758205 - [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces

Author: Walter Erquinigo Date: 2022-06-15T12:07:59-07:00 New Revision: a758205951d3a1eb60bdb65146ab23e8567f30a7 URL: https://github.com/llvm/llvm-project/commit/a758205951d3a1eb60bdb65146ab23e8567f30a7 DIFF:

[Lldb-commits] [lldb] 1f2d49a - [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server.

Author: Walter Erquinigo Date: 2022-06-15T12:08:00-07:00 New Revision: 1f2d49a8e7636a11cc4660a779dce81770943bf5 URL: https://github.com/llvm/llvm-project/commit/1f2d49a8e7636a11cc4660a779dce81770943bf5 DIFF:

[Lldb-commits] [lldb] 1f56f7f - [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

Author: Walter Erquinigo Date: 2022-06-15T12:07:59-07:00 New Revision: 1f56f7fc16bcb9966d508e462e0f408080fdb362 URL: https://github.com/llvm/llvm-project/commit/1f56f7fc16bcb9966d508e462e0f408080fdb362 DIFF:

[Lldb-commits] [lldb] 5a92632 - [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration

Author: Walter Erquinigo Date: 2022-06-15T12:07:59-07:00 New Revision: 5a92632dc477fcd42d912b2c781cc406e6d073f6 URL: https://github.com/llvm/llvm-project/commit/5a92632dc477fcd42d912b2c781cc406e6d073f6 DIFF:

[Lldb-commits] [lldb] f3250da - [lldb/Fuzzer] Create ninja target for target fuzzer

Author: Chelsea Cassanova Date: 2022-06-15T14:55:43-04:00 New Revision: f3250da1b94fed260ea5da8264ba366c42aaf34c URL: https://github.com/llvm/llvm-project/commit/f3250da1b94fed260ea5da8264ba366c42aaf34c DIFF:

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3250da1b94f: [lldb/Fuzzer] Create ninja target for target fuzzer (authored by cassanova). Changed prior to commit:

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

mib added a comment. In D127882#3586516 , @mib wrote: > How is this any different from running `ninja lldb-target-fuzzer` ? I might > be missing something ... Never mind, I assumed `lldb-target-fuzzer` would not only build the fuzzer but also run it

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

labath added a comment. I think this is a pretty good start. The main thing bugging me is the two bool flags on the stop reply packet functions. I wonder if it would be more readable to split this into two functions. Something like: SendStopReplyForThread(bool force_synchronous /*seems

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

mib added a comment. How is this any different from running `ninja lldb-target-fuzzer` ? I might be missing something ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. The case comes out of how

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

cassanova updated this revision to Diff 437266. cassanova added a comment. Moved changes to lldb-target-fuzzer/CMakeLists.txt file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 Files: lldb/tools/lldb-fuzzer/CMakeLists.txt

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

cassanova added a comment. Yes it can, updating the diff to reflect that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

JDevlieghere added a comment. Can this go into `lldb-target-fuzzer/CMakeLists.txt`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127882/new/ https://reviews.llvm.org/D127882 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

dblaikie added a comment. >>> Finally, there have been already attempts to change the hash function to >>> use the better non-zero seed (D97396 ), >>> and they were reverted because something depended on the hash function not >>> changing, so I don't see it

[Lldb-commits] [PATCH] D127882: [lldb/Fuzzer] Create ninja target for target fuzzer

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added subscribers: Michael137, mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. Create a ninja target

[Lldb-commits] [PATCH] D127819: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON

wallace added inline comments. Comment at: lldb/source/Utility/TraceIntelPTGDBRemotePackets.cpp:25 +json::Value toJSON(const JSONUINT64 , bool hex) { + if (hex) jj10306 wrote: > should there be an option to write it as an integer or would the user just be >

[Lldb-commits] [PATCH] D127752: [trace][intelpt] Support system-wide tracing [18] - some more improvements

wallace requested review of this revision. wallace added a comment. Fixed in https://reviews.llvm.org/D127881 Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:205-217 if (data_head > data_size) { uint64_t actual_data_head = data_head % data_size; // The

[Lldb-commits] [PATCH] D127881: [trace][intelpt] Support system-wide tracing [22] - Some final touches

wallace updated this revision to Diff 437247. wallace retitled this revision from "[trace][intelpt] Support system-wide tracing [22] - Use a weak pointer to avoid using a pointer to the Trace" to "[trace][intelpt] Support system-wide tracing [22] - Some final touches". wallace edited the summary

[Lldb-commits] [PATCH] D127817: [trace][intelpt] Support system-wide tracing [20] - Rename some fields in the schema

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:566 // } -// -// INTEL PT jj10306 wrote: > why delete this? because these are already specified in line 518. I'm afraid of these getting out of sync, so I prefer to specify these kinds

[Lldb-commits] [PATCH] D127804: [trace][intelpt] Support system-wide tracing [19] - Some other minor improvements

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.h:53 +/// +/// \param[in] decoded_thread +/// All decoded instructions, errors and events will be appended to this object. jj10306 wrote: > isn't this really an out

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:188 + + bool was_enabled = m_enabled; if (Error err = DisableWithIoctl()) wallace wrote: >

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTMultiCoreDecoder.h:65 - TraceIntelPT _trace; - std::set m_cores; + TraceIntelPT *m_trace; std::set m_tids; wallace wrote: > jj10306 wrote: > > why are we storing a

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

wallace requested review of this revision. wallace added a comment. Address in https://reviews.llvm.org/D127881 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127456/new/ https://reviews.llvm.org/D127456

[Lldb-commits] [PATCH] D127881: [trace][intelpt] Support system-wide tracing [22] - Use a weak pointer to avoid using a pointer to the Trace

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Having a member variable TraceIntelPT * makes it look as if it was optional. I'm using

[Lldb-commits] [PATCH] D127819: [trace][intelpt] Support system-wide tracing [21] - Support long numbers in JSON

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/TraceIntelPTGDBRemotePackets.cpp:25 +json::Value toJSON(const JSONUINT64 , bool hex) { + if (hex) should there be

[Lldb-commits] [PATCH] D127817: [trace][intelpt] Support system-wide tracing [20] - Rename some fields in the schema

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/docs/lldb-gdb-remote.txt:566 // } -// -// INTEL PT why delete this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D127804: [trace][intelpt] Support system-wide tracing [19] - Some other minor improvements

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.h:53 +/// +/// \param[in] decoded_thread +/// All decoded instructions, errors and events will be

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:188 + + bool was_enabled = m_enabled; if (Error err = DisableWithIoctl()) jj10306 wrote: > why this intermediate `was_enabled` variable? it stores the original state of

[Lldb-commits] [PATCH] D127752: [trace][intelpt] Support system-wide tracing [18] - some more improvements

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Herald added a subscriber: Michael137. looks great overall, just a couple minor things. Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:205-217 if

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham added a comment. Herald added a subscriber: Michael137. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127456: [trace][intelpt] Support system-wide tracing [17] - Some improvements

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Herald added a subscriber: Michael137. Looks great overall, thanks for making these improvements - just a couple minor things Comment at:

[Lldb-commits] [PATCH] D125897: [trace][intelpt] Support system-wide tracing [9] - Collect and return context switch traces

wallace requested review of this revision. wallace added a comment. Herald added a subscriber: Michael137. This was fixed in https://reviews.llvm.org/D127456 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125897/new/

[Lldb-commits] [PATCH] D125850: [trace][intelpt] Support system-wide tracing [8] - Improve the single buffer perf_event configuration

wallace requested review of this revision. wallace added a comment. Herald added a subscriber: Michael137. This was fixed in https://reviews.llvm.org/D127456 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125850/new/

[Lldb-commits] [PATCH] D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

wallace requested review of this revision. wallace added a comment. Herald added a subscriber: Michael137. This was fixed in https://reviews.llvm.org/D127456 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125503/new/

[Lldb-commits] [PATCH] D127001: [trace][intelpt] Support system-wide tracing [16] - Create threads automatically from context switch data in the post-mortem case

wallace requested review of this revision. wallace added a comment. This was improved in https://reviews.llvm.org/D127804 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127001/new/ https://reviews.llvm.org/D127001

[Lldb-commits] [PATCH] D126394: [trace][intelpt] Support system-wide tracing [14] - Decode per cpu

wallace requested review of this revision. wallace added a comment. This was improved in https://reviews.llvm.org/D127804 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126394/new/ https://reviews.llvm.org/D126394

[Lldb-commits] [PATCH] D126267: [trace][intelpt] Support system-wide tracing [13] - Add context switch decoding

wallace requested review of this revision. wallace added a comment. This was improved in https://reviews.llvm.org/D127804 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126267/new/ https://reviews.llvm.org/D126267

[Lldb-commits] [PATCH] D126015: [trace][intelpt] Support system-wide tracing [12] - Support multi-core trace load and save

wallace requested review of this revision. wallace added a comment. Herald added a subscriber: Michael137. This was improved in https://reviews.llvm.org/D127752 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126015/new/

[Lldb-commits] [PATCH] D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server.

wallace requested review of this revision. wallace added a comment. This was improved https://reviews.llvm.org/D127456 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125932/new/ https://reviews.llvm.org/D125932

[Lldb-commits] [PATCH] D126267: [trace][intelpt] Support system-wide tracing [13] - Add context switch decoding

wallace added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTMultiCoreDecoder.cpp:22-42 +struct PerfContextSwitchRecord { + struct perf_event_header header; + uint32_t next_prev_pid; + uint32_t

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

labath added a comment. Herald added a subscriber: Michael137. Overall, I like this. The main thing I am wondering is if it wouldn't be better to (instead of essentially duplicating the DWARFExpression interface in the DWARFExpressionList class) somehow split the process of finding the

[Lldb-commits] [PATCH] D125932: [trace][intelpt] Support system-wide tracing [10] - Return warnings and tsc information from lldb-server.

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Herald added a subscriber: Michael137. sending this back to you based on the one minor thing we discussed related to reloading. If this is addressed in one of the cleanup diffs,

[Lldb-commits] [PATCH] D127862: [lldb] [llgs] Support resuming one process with PID!=current via vCont

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Extend vCont function to support resuming a process with an arbitrary PID, that could be

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

mstorsjo added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/DebuggerThread.cpp:445 + std::array drive = {L"_:"}; + for (auto it = drive_strings.cbegin(); *it != L'\0'; it += wcslen(it) + 1) { +// Copy the drive letter to the template string

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun added a comment. Herald added a subscriber: Michael137. In D126367#3580683 , @labath wrote: > Is there any difference in functionality between SymbolVendorELF and the new > class introduced here? Could this have been achieved by teaching >

[Lldb-commits] [PATCH] D126657: [lldb] Fix loading DLL from some ramdisk on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG87a2dba14ec8: [lldb] Fix loading DLL from some ramdisk on Windows (authored by alvinhochun, committed by mstorsjo). Herald added a subscriber: Michael137. Changed prior to commit:

[Lldb-commits] [lldb] 87a2dba - [lldb] Fix loading DLL from some ramdisk on Windows

Author: Alvin Wong Date: 2022-06-15T17:02:33+03:00 New Revision: 87a2dba14ec82629317e13c2bce4c93b4d0a837d URL: https://github.com/llvm/llvm-project/commit/87a2dba14ec82629317e13c2bce4c93b4d0a837d DIFF: https://github.com/llvm/llvm-project/commit/87a2dba14ec82629317e13c2bce4c93b4d0a837d.diff

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sorry for the delay, looks good with the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. Herald added a subscriber: Michael137. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122974/new/ https://reviews.llvm.org/D122974 ___ lldb-commits mailing list lldb-commits@lists.llvm.org