[Lldb-commits] [PATCH] D131312: [LLDB][NFC] Fix suspicious bitwise expression in PrintBTEntry()

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Current application of bitwise-OR to a

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} rnk wrote: > mstorsjo wrote:

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

fixathon added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:640 + } + return {}; +} JDevlieghere wrote: > fixathon wrote: > > JDevlieghere wrote: > > > fixathon wrote: > > > > Could we delete this unreachable return

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon updated this revision to Diff 450466. fixathon added a comment. Code update to address the comments Differential Revision: https://reviews.llvm.org/D131244 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131244/new/

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon updated this revision to Diff 450460. fixathon added a comment. Addressed comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131244/new/ https://reviews.llvm.org/D131244 Files: lldb/source/Plugins/Process/Utility/ARMUtils.h Index:

[Lldb-commits] [PATCH] D131308: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Looks like a typo from the past code changes.

[Lldb-commits] [lldb] bcac7b3 - [LLDB] Missing break in a switch statement alters the execution flow.

Author: Slava Gurevich Date: 2022-08-05T18:33:18-07:00 New Revision: bcac7b3acb1972bdfabe3c84f51243e9a353e7fe URL: https://github.com/llvm/llvm-project/commit/bcac7b3acb1972bdfabe3c84f51243e9a353e7fe DIFF:

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

hawkinsw added a comment. Not that my opinion means much, but the changes look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131294/new/ https://reviews.llvm.org/D131294 ___ lldb-commits

[Lldb-commits] [PATCH] D131305: [lldb] Tidy some regex in crashlog.py (NFC)

kastiglione added a comment. this includes changes in D131032 and so depends on it merging first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131305/new/ https://reviews.llvm.org/D131305

[Lldb-commits] [PATCH] D131305: [lldb] Tidy some regex in crashlog.py (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A spiritual follow up to D131032

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added a comment. @mib the tests pass on my machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione updated this revision to Diff 450444. kastiglione added a comment. Restore some "str" variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304 Files: lldb/bindings/interface/SBData.i

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2278-2281 +assert not isinstance(patterns, str), \ "patterns must be a collection of strings" -assert not isinstance(substrs, six.string_types), \ +

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:5 -@six.add_metaclass(ABCMeta) -class ScriptedProcess: +class ScriptedProcess(metaclass=ABCMeta): mib wrote: > nit: no need to specify `metaclass=ABCMeta`, it

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Very cool! Thanks for taking care of this! LGTM with the 2 comments and assuming the test suite runs fine :) Comment at:

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

JDevlieghere updated this revision to Diff 450442. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131303/new/ https://reviews.llvm.org/D131303 Files: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp Index: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

JDevlieghere updated this revision to Diff 450441. JDevlieghere added a comment. - Fix typo - Still resolve the LLDB_APPLE_DSYMFORUUID_EXECUTABLE in case it's a relative path CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131303/new/ https://reviews.llvm.org/D131303 Files:

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added a comment. I left `third_party/Python/module/six`, in case there are any lldb scripts that depend on the existence of `six`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131304/new/ https://reviews.llvm.org/D131304

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

mib added a comment. In D131138#3703554 , @kastiglione wrote: > @JDevlieghere @mib what do you think of introducing type annotations as code > is being touched? Since we're basically building an API, it makes a lot of sense of add type annotations.

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/support/encoded_file.py:17-25 -def _encoded_read(old_read, encoding): -def impl(size): -result = old_read(size) -# If this is Python 2 then we need to convert the resulting

[Lldb-commits] [PATCH] D131304: [lldb] Remove uses of six module (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. With lldb (& llvm) requiring Python 3.6+, use of the `six`

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

JDevlieghere updated this revision to Diff 450436. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. - Don't cache the value of `LLDB_APPLE_DSYMFORUUID_EXECUTABLE` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131303/new/ https://reviews.llvm.org/D131303

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

kastiglione requested review of this revision. kastiglione added a comment. @JDevlieghere @mib what do you think of introducing type annotations as code is being touched? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131138/new/

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

kastiglione updated this revision to Diff 450434. kastiglione added a comment. Fix bug; Add type annotations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131138/new/ https://reviews.llvm.org/D131138 Files:

[Lldb-commits] [PATCH] D131303: [lldb] Refactor Symbols::DownloadObjectAndSymbolFile

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. - Reduce indentation - Extract caching of the DbgShellCommand and the dsymForUUID executable (or equivalent) - Check the DBGShellCommands

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu updated this revision to Diff 450408. zequanwu added a comment. - Recurse into parent classes when filling the offset to size map. - Previously the range parsed earlier is preferred, now it's the range parsed later is preferred, since it makes the code cleaner and it doesn't really

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} mstorsjo wrote: > rnk wrote: > >

[Lldb-commits] [PATCH] D131294: [LLDB][NFC] Reliability fixes to TCPSocket code

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Patch the following issues found by static code

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 450364. thieta added a comment. Fixed spelling error and added links to C++ standard libraries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files:

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

kastiglione added a comment. I wonder how much breakage there would be if you implemented a bunch of the dunder methods. Ex: class StopReason: def __int__(self) -> int: ... def __eq__(self, other: StopReason | int) -> bool: ... # ... This would cover many cases, but not

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:640 + } + return {}; +} fixathon wrote: > JDevlieghere wrote: > > fixathon wrote: > > > Could we delete this

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

fixathon added a comment. Added comments Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:640 + } + return {}; +} JDevlieghere wrote: > fixathon wrote: > > Could we delete this unreachable return statement? It's tripping up static > >

[Lldb-commits] [PATCH] D131130: [lldb] Improve EXC_RESOURCE exception reason

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c81b743e31a: [lldb] Improve EXC_RESOURCE exception reason (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131130?vs=449835=450335#toc

[Lldb-commits] [lldb] 9c81b74 - [lldb] Improve EXC_RESOURCE exception reason

Author: Jonas Devlieghere Date: 2022-08-05T11:19:46-07:00 New Revision: 9c81b743e31a7dca288b37b6cf6cca3213bfd923 URL: https://github.com/llvm/llvm-project/commit/9c81b743e31a7dca288b37b6cf6cca3213bfd923 DIFF:

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { fixathon wrote: > This will default

[Lldb-commits] [PATCH] D131275: [lldb] Make Process and subclass constructors protected

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Make constructors of the Process and its subclasses class protected, to prevent accidentally

[Lldb-commits] [PATCH] D131130: [lldb] Improve EXC_RESOURCE exception reason

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131130/new/ https://reviews.llvm.org/D131130 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D130674: Accurate watchpoint hit counts redux

This revision was automatically updated to reflect the committed changes. Closed by commit rG0948f1cf8177: Reapply the commits to enable accurate hit-count detection for watchpoints. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0948f1c - Reapply the commits to enable accurate hit-count detection for watchpoints.

Author: Jim Ingham Date: 2022-08-05T11:01:27-07:00 New Revision: 0948f1cf8177e378bdea2239b8c3ffb9db31f9ad URL: https://github.com/llvm/llvm-project/commit/0948f1cf8177e378bdea2239b8c3ffb9db31f9ad DIFF: https://github.com/llvm/llvm-project/commit/0948f1cf8177e378bdea2239b8c3ffb9db31f9ad.diff

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

JDevlieghere added a comment. In D131138#3702608 , @jingham wrote: > In D131138#3698508 , @mib wrote: > >> This is awesome 朗 ! I was also thinking of changing the way enums are >> exposed to python: instead of

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

jingham added a comment. In D131138#3698508 , @mib wrote: > This is awesome 朗 ! I was also thinking of changing the way enums are exposed > to python: instead of having everything added to the `lldb` python module, we > could create a class per enum

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

kastiglione added a comment. @mib I like that idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131138/new/ https://reviews.llvm.org/D131138 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/ARMUtils.h:29 +// assert(0 && "Invalid shift type"); +break; case 0: Looking at the codepaths and the reason this function exists, it's either called with a 2 bit

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

fixathon added a comment. Herald added a project: All. Added some follow up comments Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:561 + default: +LLVM_FALLTHROUGH; + case ArchSpec::eCore_arm_arm64: { This will default to the

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. BTW do you need me to implement the POSIX counterpart to this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131160/new/ https://reviews.llvm.org/D131160 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon added a comment. Added in-code comments with details Comment at: lldb/source/Plugins/Process/Utility/ARMUtils.h:48-49 } shift_t = SRType_Invalid; return UINT32_MAX; } These lines were unreachable prior to the fix due to the **default** label

[Lldb-commits] [PATCH] D131244: [LLDB] Missing break in a switch statement alters the execution flow.

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett. Herald added a project: All. fixathon requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Looks like a typo from the past code changes.

[Lldb-commits] [PATCH] D131159: [WIP][lldb] Use WSAEventSelect for MainLoop polling

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Only guessing what various WSA functions do, it seems to all make sense to me. Just don't forget to `clang-format` ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

kpdev42 updated this revision to Diff 450244. kpdev42 added a comment. Update test case so it compares JIT’ed and interpreted FP division results and also check operations on float type. Patch doesn’t implement long double, because IR interpreter currently doesn’t support instruction argument

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. To be honest, I'm not sure if "event" is the best name for it. I get it's a WSA name but it's a bit non-obvious to outsiders (I mean, technically everything is an event). Not that I have a better name in mind. Comment at: