[Lldb-commits] [PATCH] D141972: Delay loading of qProcessInfo-informed binaries until later in the Process setup

jingham added a comment. This seems okay to me, I can't see why you would be required to fill in the "main binary" or "extra binaries" when we're just stopping for the attach. We shouldn't need them till we've decided we're launched or attached and need to print any info about that. But

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. In D138618#4004866 , @labath wrote: > I think that the main reason we've arrived at such different conclusions is > that I treat the "user IDs of DIEs" and and "user IDs of symbol files" as > essentially two different things

[Lldb-commits] [PATCH] D141972: Delay loading of qProcessInfo-informed binaries until later in the Process setup

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I handle two types of

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

bulbazord requested changes to this revision. bulbazord added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:421 Target = GetTarget(); + bool force_lookup = m_scripted_metadata.GetClassName().contains("CrashLog");

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:421 Target = GetTarget(); + bool force_lookup =

[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

mib added a comment. ping @JDevlieghere @bulbazord :p CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/ https://reviews.llvm.org/D141702 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 7ef075a - [lldb] Only allow SymbolFiles to construct Types

Author: Augusto Noronha Date: 2023-01-17T10:30:29-08:00 New Revision: 7ef075a6d7a2bccbeedb9b5a1689e8545d5753e9 URL: https://github.com/llvm/llvm-project/commit/7ef075a6d7a2bccbeedb9b5a1689e8545d5753e9 DIFF:

[Lldb-commits] [PATCH] D141629: Run address expression argument values through ABI::FixCodeAddress to strip TBI/pointer auth bytes on AArch64

DavidSpickett added a comment. I am looking at this, just taking some time to get a PAC enabled environment going again. At first glance it seems like a better way to do things. I just want to run the test from my patch against this one. I can port the test to AArch64 Linux though that's not

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4058807 , @erichkeane wrote: > In D131858#4054348 , @v.g.vassilev > wrote: > >> In D131858#4052031 , @erichkeane >> wrote: >>

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4054348 , @v.g.vassilev wrote: > In D131858#4052031 , @erichkeane > wrote: > >> In D131858#4052026 , @v.g.vassilev >> wrote: >>

[Lldb-commits] [PATCH] D140839: [lldb] Enable TestFrameFormatNameWithArgs in case of cross compilation

Michael137 added inline comments. Comment at: lldb/test/Shell/helper/build.py:29 default='host', -choices=['32', '64', 'host'], help='Specify the architecture to target.') asahay wrote: > Michael137

[Lldb-commits] [PATCH] D140839: [lldb] Enable TestFrameFormatNameWithArgs in case of cross compilation

asahay added inline comments. Comment at: lldb/test/Shell/helper/build.py:29 default='host', -choices=['32', '64', 'host'], help='Specify the architecture to target.') Michael137 wrote: > Why was this

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada created this revision. domada added reviewers: dpalermo, skatrak, kiranktp, RogerV-AMD, NimishMishra, jsjodin. Herald added subscribers: pmatos, asb, guansong, kbarton, hiraditya, jgravelle-google, sbc100, yaxunl, nemanjai, dschuff. Herald added a project: All. domada requested review of

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice created this revision. paperchalice added reviewers: phosek, Ericson2314. Herald added a subscriber: Enna1. Herald added a project: All. paperchalice requested review of this revision. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Herald added subscribers:

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto max_instruction_size = g_vsc.target.GetMaximumOpcodeByteSize(); + const auto bytes_offset = -instruction_offset * max_instruction_size; + auto start_addr = base_addr -