[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Michael137 added a comment. Test variable renaming committed in https://reviews.llvm.org/rG8e8dd110be5f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140030/new/ https://reviews.llvm.org/D140030 ___

[Lldb-commits] [lldb] 8e8dd11 - [lldb][Test][NFC] TestCreateClassTemplateDecl: make variable names more readable

Author: Michael Buch Date: 2023-01-27T03:46:50Z New Revision: 8e8dd110be5f1b4944a9dacd4f4a09bf8ecc6892 URL: https://github.com/llvm/llvm-project/commit/8e8dd110be5f1b4944a9dacd4f4a09bf8ecc6892 DIFF: https://github.com/llvm/llvm-project/commit/8e8dd110be5f1b4944a9dacd4f4a09bf8ecc6892.diff LOG:

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Michael137 added a comment. Argh seems like Phabricator didn't like the fact I linked the revision in a different commit. So to see the actual change that got landed as part of this you need to visit the history tab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

This revision was automatically updated to reflect the committed changes. Closed by commit rG41a2d7a37cb1: [lldb][NFC] Build fix: use TemplateParameterInfos public APIs instead of… (authored by Michael137). Changed prior to commit: https://reviews.llvm.org/D140030?vs=483759=492631#toc

[Lldb-commits] [lldb] 41a2d7a - [lldb][NFC] Build fix: use TemplateParameterInfos public APIs instead of accessing private members

Author: Michael Buch Date: 2023-01-27T03:10:21Z New Revision: 41a2d7a37cb1665f061a6ec6edd31a749417b024 URL: https://github.com/llvm/llvm-project/commit/41a2d7a37cb1665f061a6ec6edd31a749417b024 DIFF: https://github.com/llvm/llvm-project/commit/41a2d7a37cb1665f061a6ec6edd31a749417b024.diff LOG:

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Michael137 added a comment. Didn't rebase properly and broke the build Fixing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140030/new/ https://reviews.llvm.org/D140030 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D140030: [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Michael137 added a comment. Got landed in https://reviews.llvm.org/rGa29e06bbeaad7012ac85b221f1aaba3fe1d5fd35 Forgot about your last comment re. variable names in the tests Pavel. Will change in a follow-up commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1aee040c6545: [lldb] Add support for DW_AT_default_value in template params (authored by Michael137). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 1aee040 - [lldb] Add support for DW_AT_default_value in template params

Author: Michael Buch Date: 2023-01-27T02:24:36Z New Revision: 1aee040c6545ad65d87b14a694078c182b9fa359 URL: https://github.com/llvm/llvm-project/commit/1aee040c6545ad65d87b14a694078c182b9fa359 DIFF: https://github.com/llvm/llvm-project/commit/1aee040c6545ad65d87b14a694078c182b9fa359.diff LOG:

[Lldb-commits] [lldb] a29e06b - [lldb][TypeSystemClang][NFC] Make TemplateParameterInfos members private

Author: Michael Buch Date: 2023-01-27T02:24:35Z New Revision: a29e06bbeaad7012ac85b221f1aaba3fe1d5fd35 URL: https://github.com/llvm/llvm-project/commit/a29e06bbeaad7012ac85b221f1aaba3fe1d5fd35 DIFF: https://github.com/llvm/llvm-project/commit/a29e06bbeaad7012ac85b221f1aaba3fe1d5fd35.diff LOG:

[Lldb-commits] [lldb] dd9b31e - [test] Remove unused `unittest2` import from concurrent_base.py

Author: Jordan Rupprecht Date: 2023-01-26T18:23:23-08:00 New Revision: dd9b31e2c2a271c9e6059dde6a406aea5ed8b663 URL: https://github.com/llvm/llvm-project/commit/dd9b31e2c2a271c9e6059dde6a406aea5ed8b663 DIFF:

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 updated this revision to Diff 492621. Michael137 added a comment. - Remove redundant includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 Files:

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM! (I think you some superfluous #includes now) Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:21 +#include +#include + I

[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:167 if (unit.GetDWOId()) { if (SymbolFileDWARFDwo *dwo_symbol_file = unit.GetDwoSymbolFile()) { // Type units in a dwp file are indexed separately, so we just

[Lldb-commits] [PATCH] D142683: Manual DWARF index: don't skip over -gmodules debug info

aprantl created this revision. aprantl added reviewers: clayborg, JDevlieghere. Herald added a subscriber: arphaman. Herald added a project: All. aprantl requested review of this revision. This fixes a regression introduced by https://reviews.llvm.org/D131437. The intention of the patch was to

[Lldb-commits] [lldb] d5c0b1f - [test] Remove unused `unittest2` import

Author: Jordan Rupprecht Date: 2023-01-26T18:02:16-08:00 New Revision: d5c0b1f73b0502158d9b3afa0ba7b22b69f0823e URL: https://github.com/llvm/llvm-project/commit/d5c0b1f73b0502158d9b3afa0ba7b22b69f0823e DIFF:

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

jgorbe marked an inline comment as done. jgorbe added inline comments. Comment at: lldb/source/API/SBSection.cpp:187-189 +DataExtractorSP result_data_sp = +std::make_shared(section_data, offset, size); +sb_data.SetOpaque(result_data_sp); dblaikie

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

jgorbe updated this revision to Diff 492602. jgorbe added a comment. Addressing review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142672/new/ https://reviews.llvm.org/D142672 Files: lldb/source/API/SBSection.cpp lldb/test/API/python_api/section/TestSectionAPI.py

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

dblaikie added inline comments. Comment at: lldb/source/API/SBSection.cpp:187-189 +DataExtractorSP result_data_sp = +std::make_shared(section_data, offset, size); +sb_data.SetOpaque(result_data_sp); Probably either use `std::move` when passing

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 updated this revision to Diff 492580. Michael137 added a comment. - Remove dead code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 Files:

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

jgorbe created this revision. jgorbe added a reviewer: labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. `SBSection::GetSectionData` and `Section::GetSectionData` are implemented differently, and

[Lldb-commits] [lldb] dc682ed - [test][lldb-vscode] Fix unclean shutdown in test_terminate_commands

Author: Jordan Rupprecht Date: 2023-01-26T14:29:48-08:00 New Revision: dc682ed590f73f7b7417ecf66d18b303ab957c62 URL: https://github.com/llvm/llvm-project/commit/dc682ed590f73f7b7417ecf66d18b303ab957c62 DIFF:

[Lldb-commits] [PATCH] D139957: [LLDB] Change OSO to use DieRef

ayermolo marked an inline comment as done. ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:32 - DIERef(std::optional dwo_num, Section section, + DIERef(std::optional dwo_oso_num, Section section, dw_offset_t die_offset)

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. As long as there are no regressions in the test suite this looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142552/new/

[Lldb-commits] [PATCH] D142663: Improve disable-language-runtime-unwindplans description to be more searchable

jasonmolenda created this revision. jasonmolenda added a reviewer: kastiglione. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. The current

[Lldb-commits] [PATCH] D142662: Allow bytes-only mach-o corefile to load into lldb

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142662/new/ https://reviews.llvm.org/D142662 ___

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca446037af01: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend (authored by domada). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] ca44603 - [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-01-26T15:10:19-06:00 New Revision: ca446037af019d1aa01b1352a30a18df33038359 URL: https://github.com/llvm/llvm-project/commit/ca446037af019d1aa01b1352a30a18df33038359 DIFF:

[Lldb-commits] [PATCH] D142662: Allow bytes-only mach-o corefile to load into lldb

jasonmolenda created this revision. jasonmolenda added reviewers: JDevlieghere, mib. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. `ProcessMachCore::DoLoadCore` has an error check that if

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 updated this revision to Diff 492538. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 Files:

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:38 +Platform::SetHostPlatform( +PlatformRemoteMacOSX::CreateInstance(true, , nullptr, nullptr)); + } aprantl wrote: > Does this work on Linux?

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 updated this revision to Diff 492537. Michael137 added a comment. - Use `GetInputFilePath` and `MemoryBuffer` to read test YAML file - Remove redundant test-fixture initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. We just need to create all DIERef objects using the GetID() from the symbol file as the file index, and we should be able to remove the SymbolFile::GetUID() function now. As long as file index zero is reserved for "vanilla DWARF that doesn't use DWO or OSO we will

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. In D138618#4080706 , @labath wrote: > In D138618#4077851 , @ayermolo > wrote: > >> In D138618#4073329 , @labath wrote: >> >>> I think that the

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

jdoerfert accepted this revision. jdoerfert added a comment. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2057 +case DW_AT_default_value: + if (attributes.ExtractFormValueAtIndex(i, form_value)) { +is_default_template_arg = form_value.Boolean();

[Lldb-commits] [PATCH] D141828: [lldb] Add support for DW_AT_default_value in template params

Michael137 updated this revision to Diff 492456. Michael137 added a comment. - Use constructor instead of setter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141828/new/ https://reviews.llvm.org/D141828 Files:

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

Michael137 added a comment. Not needed anymore due to simpler implementation at https://reviews.llvm.org/D141828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140262/new/ https://reviews.llvm.org/D140262