[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

omjavaid added a comment. HI Manoj Which linux distro are you using for your cross build? I am wondering which version of gcc (aarch64-linux-gnu) are you using for your cross compilation build. I believe sve headers are not defined in older versions of gcc or its packaged sysroot causing cross

[Lldb-commits] [PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai updated this revision to Diff 515194. vsapsai added a comment. Don't touch HeaderSearch.cpp as the actual change in header search will be a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148776/new/

[Lldb-commits] [PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:358-373 +#if ALLOW_SUBDIRECTORY_MODULE_MAP_SEARCH // If we've already performed the exhaustive search for module maps in this // search directory, don't do it again. if

[Lldb-commits] [PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai created this revision. vsapsai added reviewers: EricWF, aprantl, chapuni. Herald added subscribers: ributzka, s.egerton, simoncook, asb, fedor.sergeev, dschuff. Herald added a reviewer: deadalnix. Herald added a project: All. vsapsai requested review of this revision. Herald added

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f160dfc1aa: [lldb] Fix bug to update process public run lock with process state (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] a4f160d - [lldb] Fix bug to update process public run lock with process state

Author: Med Ismail Bennani Date: 2023-04-19T16:54:57-07:00 New Revision: a4f160dfc1aa508a88a83a9cb1420d762f863408 URL: https://github.com/llvm/llvm-project/commit/a4f160dfc1aa508a88a83a9cb1420d762f863408 DIFF:

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

mib updated this revision to Diff 515137. mib edited the summary of this revision. mib added a comment. Fix condition typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148400/new/ https://reviews.llvm.org/D148400 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

mib added inline comments. Comment at: lldb/source/Target/Process.cpp:1395 +llvm::StringRef hijacking_name = GetHijackingListenerName(); +if (hijacking_name.starts_with("lldb.internal")) return true; I think I forgot to negate this: if

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

manojgupta created this revision. Herald added subscribers: ctetreau, omjavaid, kristof.beyls, tschuett. Herald added a project: All. manojgupta requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use correct internal sve functions for arm64.

[Lldb-commits] [PATCH] D148715: [LLDB] Discard register flags where the size doesn't match the register

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148715/new/ https://reviews.llvm.org/D148715

[Lldb-commits] [PATCH] D148679: [lldb] Change setting descriptions to use StringRef instead of ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rG96a800c07f02: [lldb] Change setting descriptions to use StringRef instead of ConstString (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 96a800c - [lldb] Change setting descriptions to use StringRef instead of ConstString

Author: Alex Langford Date: 2023-04-19T14:45:02-07:00 New Revision: 96a800c07f0220f840560e78bbd77104121d24cf URL: https://github.com/llvm/llvm-project/commit/96a800c07f0220f840560e78bbd77104121d24cf DIFF: https://github.com/llvm/llvm-project/commit/96a800c07f0220f840560e78bbd77104121d24cf.diff

[Lldb-commits] [PATCH] D148676: [lldb][NFCI] Stop creating additional temporary string in Log::VAPrintf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77e3914be7c9: [lldb][NFCI] Stop creating additional temporary string in Log::VAPrintf (authored by bulbazord). Repository: rG LLVM Github

[Lldb-commits] [lldb] 77e3914 - [lldb][NFCI] Stop creating additional temporary string in Log::VAPrintf

Author: Alex Langford Date: 2023-04-19T14:16:12-07:00 New Revision: 77e3914be7c99a76a2f728adbb2a169d7cfc5a10 URL: https://github.com/llvm/llvm-project/commit/77e3914be7c99a76a2f728adbb2a169d7cfc5a10 DIFF: https://github.com/llvm/llvm-project/commit/77e3914be7c99a76a2f728adbb2a169d7cfc5a10.diff

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

mib added a comment. Reverting this because it introduced some failures on the linux bot: https://lab.llvm.org/buildbot/#/builders/68/builds/51397/steps/6/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148400/new/

[Lldb-commits] [lldb] f2f3755 - Revert "[lldb] Fix bug to update process public run lock with process state"

Author: Med Ismail Bennani Date: 2023-04-19T10:46:33-07:00 New Revision: f2f37557e722a4d41378bd53c119ee89cb3ec93d URL: https://github.com/llvm/llvm-project/commit/f2f37557e722a4d41378bd53c119ee89cb3ec93d DIFF:

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14f00213b202: [lldb] Fix bug to update process public run lock with process state (authored by mib). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 14f0021 - [lldb] Fix bug to update process public run lock with process state

Author: Med Ismail Bennani Date: 2023-04-19T10:04:56-07:00 New Revision: 14f00213b202a82b895a6ab749262d4382435012 URL: https://github.com/llvm/llvm-project/commit/14f00213b202a82b895a6ab749262d4382435012 DIFF:

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

JDevlieghere accepted this revision. JDevlieghere added a comment. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148400/new/ https://reviews.llvm.org/D148400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D148679: [lldb] Change setting descriptions to use StringRef instead of ConstString

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148679/new/ https://reviews.llvm.org/D148679

[Lldb-commits] [PATCH] D148715: [LLDB] Discard register flags where the size doesn't match the register

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In the particular case I was looking at I autogenerated a 128 bit set of flags that is only 64 bit. This

[Lldb-commits] [PATCH] D143374: [LLDB][RISCV] Add RVV register infos

DavidSpickett added a comment. In the time since this was written and landed, I added an extra field to register information. Fixed that here: https://github.com/llvm/llvm-project/commit/ee9a646192db1cc5d1df57d69232fdd2a5c89fc5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ee9a646 - [lldb][RISCV] Add missing flags pointer to register infos

Author: David Spickett Date: 2023-04-19T11:42:14Z New Revision: ee9a646192db1cc5d1df57d69232fdd2a5c89fc5 URL: https://github.com/llvm/llvm-project/commit/ee9a646192db1cc5d1df57d69232fdd2a5c89fc5 DIFF: https://github.com/llvm/llvm-project/commit/ee9a646192db1cc5d1df57d69232fdd2a5c89fc5.diff

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I don't know enough to review the other patches but I understand the layering issue. So assuming the other patches are ok, this one LGTM. Comment at:

[Lldb-commits] [PATCH] D143374: [LLDB][RISCV] Add RVV register infos

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd64c2f2506: [LLDB][RISCV] Add RVV register infos (authored by Emmmer). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D143374?vs=495161=514857#toc

[Lldb-commits] [lldb] efd64c2 - [LLDB][RISCV] Add RVV register infos

Author: Emmmer Date: 2023-04-19T16:26:33+08:00 New Revision: efd64c2f2506df3e2ed6d9da68e49f03fc31763c URL: https://github.com/llvm/llvm-project/commit/efd64c2f2506df3e2ed6d9da68e49f03fc31763c DIFF: https://github.com/llvm/llvm-project/commit/efd64c2f2506df3e2ed6d9da68e49f03fc31763c.diff LOG:

[Lldb-commits] [PATCH] D148400: [lldb] Fix bug to update process public run lock with process state

mib updated this revision to Diff 514832. mib added a comment. Turning hijack listener name getters into public `static constexpr llvmStringRef` as @JDevlieghere suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148400/new/ https://reviews.llvm.org/D148400 Files: