[Lldb-commits] [lldb] e0466a7 - [lldb][NFCI] Qualify param type in SBDebugger::FindTargetWithProcessID

Author: Alex Langford Date: 2023-05-17T17:34:36-07:00 New Revision: e0466a7463ecbd6a3bbe3296f5f7c5ece749564f URL: https://github.com/llvm/llvm-project/commit/e0466a7463ecbd6a3bbe3296f5f7c5ece749564f DIFF: https://github.com/llvm/llvm-project/commit/e0466a7463ecbd6a3bbe3296f5f7c5ece749564f.diff

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/ https://reviews.llvm.org/D150826

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 updated this revision to Diff 523219. augusto2112 added a comment. Add llvm_unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/ https://reviews.llvm.org/D150826 Files: lldb/include/lldb/Core/Value.h

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 added a comment. In D150826#4351518 , @bulbazord wrote: > Where do you plan on using this? Downstream I assume? Yes, I need this downstream, but seemed general enough to add upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

bulbazord added a comment. Where do you plan on using this? Downstream I assume? Comment at: lldb/source/Core/Value.cpp:134-135 + return Value::ValueType::Invalid; + } +} + This switch is exhaustive, could you add an `llvm_unreachable` somewhere to

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Value::ValueType is a superset of AddressType. Add a function to convert an

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

arsenm closed this revision. arsenm added a comment. 44096e6904e10bb313fef2f6aaff25c25d1325f7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine added a comment. This update switches to a time-based approach as suggested by Jordan. However, the timing is about the same as the original. I believe because calling getCurrentTime every iteration is comparably slow as printing the progress report itself. It probably is still a

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine updated this revision to Diff 523191. saugustine added a comment. Switch rate-limiting to a time-based mechanism Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150805/new/ https://reviews.llvm.org/D150805 Files:

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine updated this revision to Diff 523188. saugustine added a comment. Swtich rate-limiting to a time-based mechanism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150805/new/ https://reviews.llvm.org/D150805 Files:

[Lldb-commits] [lldb] 6dcad42 - [lldb][NFCI] Clean up ThreadSafeDenseMap

Author: Alex Langford Date: 2023-05-17T13:31:51-07:00 New Revision: 6dcad42acbd5d047ac276ca73f1dc0012a39e99e URL: https://github.com/llvm/llvm-project/commit/6dcad42acbd5d047ac276ca73f1dc0012a39e99e DIFF: https://github.com/llvm/llvm-project/commit/6dcad42acbd5d047ac276ca73f1dc0012a39e99e.diff

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

glandium added a comment. In D144509#4349051 , @hans wrote: > In D144509#4347562 , @glandium > wrote: > >> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c >>

[Lldb-commits] [lldb] 147a616 - [lldb][NFCI] Move ThreadSafeDenseMap to Utility

Author: Alex Langford Date: 2023-05-17T12:51:36-07:00 New Revision: 147a61618989b6cca1f5f77ed96f930620ff193f URL: https://github.com/llvm/llvm-project/commit/147a61618989b6cca1f5f77ed96f930620ff193f DIFF: https://github.com/llvm/llvm-project/commit/147a61618989b6cca1f5f77ed96f930620ff193f.diff

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

JDevlieghere added a comment. Given that here we know the `total_progress` in advance and assuming the operation is relatively evenly distributed, would it make sense to report for every percentage? We could do this in `ManualDWARFIndex::Index` or we could add something like a "Policy" or

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

rupprecht added a comment. This is a nice proof of concept, but I think we should go with a time-based approach to rate limit this. (Anyone else in LLDB know if we have some utils around to help with this?) e.g. if the first 1000 files are small and the last 1000 are large, the user will see

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine created this revision. Herald added subscribers: arphaman, kristof.beyls. Herald added a project: All. saugustine requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reporting progress for every DIE read turns out to be very slow

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord created this revision. bulbazord added reviewers: jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. LLDB should guarantee that the strings returned by SBAPI methods live forever.

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/test/Transforms/InferAddressSpaces/masked-gather-scatter.ll:3 + +; CHECK-LABEL: @masked_gather_inferas( +; CHECK: tail call <4 x i32> @llvm.masked.gather.v4i32.v4p1 CaprYang wrote: > arsenm wrote: > > CaprYang

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/test/Transforms/InferAddressSpaces/masked-gather-scatter.ll:3 + +; CHECK-LABEL: @masked_gather_inferas( +; CHECK: tail call <4 x i32> @llvm.masked.gather.v4i32.v4p1 arsenm wrote: > CaprYang wrote: > > arsenm

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang updated this revision to Diff 523087. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 Files: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp llvm/test/Transforms/InferAddressSpaces/AMDGPU/icmp.ll

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. Is https://reviews.llvm.org/D144509#4347562 fixed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4350148 , @thakis wrote: > https://github.com/llvm/llvm-project/issues/62719 is independent of chromium > and others have reported problems above too, from what I understand. Is that > not accurate? That bug report

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349017 , @dyung wrote: > I'm not really sure where else to post this, but the pre-merge linux bot > still seems to be running 3.18.4. > >

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. https://github.com/llvm/llvm-project/issues/62719 is independent of chromium and others have reported problems above too, from what I understand. Is that not accurate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4349921 , @thakis wrote: > Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 > for now. > > Sorry this is such a pain to

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

thakis added a comment. Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 for now. Sorry this is such a pain to land :( (See also discussion over in D150688 )

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4349399 , @mstorsjo wrote: > In D144509#4349051 , @hans wrote: > >> In D144509#4347562 , @glandium >> wrote: >> >>> FYI,

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder updated this revision to Diff 523045. tbaeder added a comment. Updated the test and split up the expected output into multiple lines so it's easier to read. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 Files:

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder added a comment. In D150772#4349595 , @Michael137 wrote: > In D150772#4349592 , @tbaeder wrote: > >> Can you tell me what I have to do so `ninja check-lldb-api` actually runs >> the test? All 1114 tests

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

Michael137 added a comment. In D150772#4349592 , @tbaeder wrote: > Can you tell me what I have to do so `ninja check-lldb-api` actually runs the > test? All 1114 tests are currently marked "unsupported" for me. Did you configure LLDB with

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder added a comment. Can you tell me what I have to do so `ninja check-lldb-api` actually runs the test? All 1114 tests are currently marked "unsupported" for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

teemperor added a comment. I think, given the support for multi-line expressions, updating the test case is IMHO the right call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772

[Lldb-commits] [lldb] eb5a3e2 - [lldb][SymbolFileDWARF] Fix format specifier when logging FindDefinitionTypeForDWARFDeclContext

Author: Michael Buch Date: 2023-05-17T13:40:21+01:00 New Revision: eb5a3e247aa2ec4f0089e6518fc815915ab24228 URL: https://github.com/llvm/llvm-project/commit/eb5a3e247aa2ec4f0089e6518fc815915ab24228 DIFF: https://github.com/llvm/llvm-project/commit/eb5a3e247aa2ec4f0089e6518fc815915ab24228.diff

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder created this revision. tbaeder added a reviewer: LLDB. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Clang prints a margin with line numbers to the left of code snippets now, introduced in

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b6264738f3d: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on… (authored by sgraenitz). Changed prior to commit: https://reviews.llvm.org/D146154?vs=522951=523004#toc

[Lldb-commits] [lldb] 0b62647 - [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

Author: Stefan Gränitz Date: 2023-05-17T13:56:01+02:00 New Revision: 0b6264738f3d3688719b23c5d272725d3d9bf4e0 URL: https://github.com/llvm/llvm-project/commit/0b6264738f3d3688719b23c5d272725d3d9bf4e0 DIFF:

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

mstorsjo added a comment. In D144509#4349051 , @hans wrote: > In D144509#4347562 , @glandium > wrote: > >> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c >>

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. In D128612#4349291 , @asb wrote: > In D128612#4349259 , @djtodoro > wrote: > >> In D128612#4345912 , @asb wrote: >> >>> In D128612#4337037

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. In D128612#4349259 , @djtodoro wrote: > In D128612#4345912 , @asb wrote: > >> In D128612#4337037 , @djtodoro >> wrote: >> >>> Hi! I am wondering if

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. In D128612#4345912 , @asb wrote: > In D128612#4337037 , @djtodoro > wrote: > >> Hi! I am wondering if someone knows what is the status of this. > > I've not seen any further progress. I

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4347562 , @glandium wrote: > FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c > is > causing problems on Windows compiler-rt for some reason I haven't

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz updated this revision to Diff 522951. sgraenitz added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D146154 Files:

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

dyung added a comment. I'm not really sure where else to post this, but the pre-merge linux bot still seems to be running 3.18.4. https://buildkite.com/llvm-project/premerge-checks/builds/152678#018828d2-1837-4fc2-baec-fca595969219 CMake Error at CMakeLists.txt:3 (cmake_minimum_required):

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4241ac542d69: [lldb][gnustep] Add basic test and infrastructure

[Lldb-commits] [lldb] 4241ac5 - [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

Author: Stefan Gränitz Date: 2023-05-17T10:37:38+02:00 New Revision: 4241ac542d691289f08c3229cfc58641f5659ec7 URL: https://github.com/llvm/llvm-project/commit/4241ac542d691289f08c3229cfc58641f5659ec7 DIFF: