[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack added a comment. @yinghuitan yup, `RetryAfterSignal::Open` helper functions look better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712 ___

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

splhack updated this revision to Diff 531186. splhack added a comment. Add lldb/include/lldb/Host/common/RetryAfterSignal.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712 Files:

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:340-343 +for key in path_remapping: +source_path = os.path.expanduser( +path_remapping[key] +

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. It can be tricky to troubleshoot why the crashlog script can't show inline sources. The two most common causes are that we couldn't find

[Lldb-commits] [lldb] 1ae6a78 - [lldb] Fix Debugger whitespace and formatting (NFC)

Author: Jonas Devlieghere Date: 2023-06-13T20:50:30-07:00 New Revision: 1ae6a782f096a9870c3f5bd7c3489abeaa238d0f URL: https://github.com/llvm/llvm-project/commit/1ae6a782f096a9870c3f5bd7c3489abeaa238d0f DIFF:

[Lldb-commits] [lldb] d132b85 - [lldb] Include in LLDBAssert

Author: Jonas Devlieghere Date: 2023-06-13T20:50:29-07:00 New Revision: d132b854b3cbd094a06023f394d9b3dfd44e9b4f URL: https://github.com/llvm/llvm-project/commit/d132b854b3cbd094a06023f394d9b3dfd44e9b4f DIFF:

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG83a6a0a62047: [lldb] Print lldbassert to debugger diagnostics (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D152866?vs=531126=531161#toc

[Lldb-commits] [lldb] 83a6a0a - [lldb] Print lldbassert to debugger diagnostics

Author: Jonas Devlieghere Date: 2023-06-13T20:46:33-07:00 New Revision: 83a6a0a620476d2fa181cb663ccbf06cc9d7a24f URL: https://github.com/llvm/llvm-project/commit/83a6a0a620476d2fa181cb663ccbf06cc9d7a24f DIFF:

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

yinghuitan accepted this revision. yinghuitan added a comment. Can we wrap this as a helper function and shared to avoid duplication? Otherwise looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531147. splhack added a comment. fix EXPECT_EQ warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added inline comments. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES "Android") + list(APPEND ANDROID_SOURCES

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 531126. JDevlieghere added a comment. Separate out message, backtrace and prompt. This works better for a custom (downstream) callback that prompts the user to automatically file a bug report. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152872: Add support for __debug_line_str in Mach-O

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152872/new/ https://reviews.llvm.org/D152872 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D152872: Add support for __debug_line_str in Mach-O

aprantl created this revision. aprantl added reviewers: bulbazord, fdeazeve, rastogishubham, JDevlieghere. Herald added a project: All. aprantl requested review of this revision. This patch resolves an issue that currently accounts for the vast majority of failures on the matrix bot.

[Lldb-commits] [PATCH] D152870: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a subscriber: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the next step in

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

splhack updated this revision to Diff 531118. splhack added a comment. Herald added a subscriber: JDevlieghere. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ https://reviews.llvm.org/D152757 Files:

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord added inline comments. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES "Android") + list(APPEND ANDROID_SOURCES

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. In D152866#4419413 , @JDevlieghere wrote: > In D152866#4419406 , @bulbazord > wrote: > >> I like

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 53. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152866/new/ https://reviews.llvm.org/D152866 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Utility/LLDBAssert.h lldb/source/API/SystemInitializerFull.cpp

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 531110. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152866/new/ https://reviews.llvm.org/D152866 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Utility/LLDBAssert.h

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere added a comment. In D152866#4419406 , @bulbazord wrote: > I like this idea quite a bit! I assume that when somebody hits a bug, they > can give us their diagnostics file and we will hopefully see the assertion > somewhere (if there was

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

bulbazord added a comment. I like this idea quite a bit! I assume that when somebody hits a bug, they can give us their diagnostics file and we will hopefully see the assertion somewhere (if there was one)? Comment at: lldb/source/Target/Target.cpp:115 + lldbassert(false

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. @bulbazord thanks for reviewing! will address the types, formats. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere created this revision. JDevlieghere added reviewers: labath, rupprecht, bulbazord, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. When hitting an lldbassert in a non-assert build, we emit a blurb including the assertion, the triggering file and

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531104. bulbazord added a comment. Avoid construction of temporary std::string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files:

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531103. bulbazord added a comment. Update other 2 functions (and one callsite) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files:

[Lldb-commits] [PATCH] D152597: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString overloads involving ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rGe669011c3cca: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e669011 - [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString overloads involving ConstString

Author: Alex Langford Date: 2023-06-13T15:51:56-07:00 New Revision: e669011c3cca4b7b4a1c2e8d96467cecbc05df4d URL: https://github.com/llvm/llvm-project/commit/e669011c3cca4b7b4a1c2e8d96467cecbc05df4d DIFF: https://github.com/llvm/llvm-project/commit/e669011c3cca4b7b4a1c2e8d96467cecbc05df4d.diff

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the other two functions updated as well. Comment at: lldb/include/lldb/Target/Platform.h:453 - void SetSDKRootDirectory(ConstString dir) {

[Lldb-commits] [lldb] a1a74f7 - [lldb] Default can_create to true in GetChildAtIndex (NFC)

Author: Dave Lee Date: 2023-06-13T15:51:32-07:00 New Revision: a1a74f7cdea3db6e1a557eb1466f56b59e2d7fec URL: https://github.com/llvm/llvm-project/commit/a1a74f7cdea3db6e1a557eb1466f56b59e2d7fec DIFF: https://github.com/llvm/llvm-project/commit/a1a74f7cdea3db6e1a557eb1466f56b59e2d7fec.diff

[Lldb-commits] [PATCH] D152031: [lldb] Default can_create to true in GetChildAtIndex (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a74f7cdea3: [lldb] Default can_create to true in GetChildAtIndex (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord added a comment. Herald added a subscriber: JDevlieghere. This is definitely useful to support, I had a few comments mostly about matching lldb's coding style. Also, are you running clang-format on your patches? There are a few places where I'm not sure if the formatting is right.

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda updated this revision to Diff 531092. jasonmolenda added a comment. Address Alex's feedback of not extracting the ABI pointer out of the shared pointer; simply use the shared pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

bulbazord added a comment. An environment variable isn't the worst thing in the world, but what would be better is an lldb setting so we can change it at runtime instead of needing to restart the debugging session. That may happen if you make a typo or make a mistake. Something like

[Lldb-commits] [PATCH] D152863: [lldb] NFC Add Process methods to Fix.*Address, to simplify this bit clearing across the codebase

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. Right now to clear

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I don't really work on android-related code anymore but this change seems alright to me. There's prior art in LLVM which makes it a lot easier to accept. It's unfortunate that we need

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack created this revision. Herald added a subscriber: danielkiss. Herald added a project: All. splhack added reviewers: clayborg, labath, lanza, srhines. splhack edited the summary of this revision. splhack updated this revision to Diff 531075. splhack added a comment. splhack updated this

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda added a comment. In D152861#4419197 , @bulbazord wrote: > I noticed you're pulling a lot of raw pointers out of shared pointers. Is > there a particular reason you're doing that? `operator bool` on > `std::shared_ptr` returns true if the

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531084. bulbazord added a comment. Implement Jonas's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files:

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

bulbazord added a comment. I noticed you're pulling a lot of raw pointers out of shared pointers. Is there a particular reason you're doing that? `operator bool` on `std::shared_ptr` returns true if the held pointer is non-null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151951: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cff6ca81335: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3cff6ca - [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName

Author: Alex Langford Date: 2023-06-13T14:53:24-07:00 New Revision: 3cff6ca81335ceff4ddd823b87daa38eedba5130 URL: https://github.com/llvm/llvm-project/commit/3cff6ca81335ceff4ddd823b87daa38eedba5130 DIFF: https://github.com/llvm/llvm-project/commit/3cff6ca81335ceff4ddd823b87daa38eedba5130.diff

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber:

[Lldb-commits] [lldb] 68d964d - Revert "[lldb] Fix failure in TestStackCoreScriptedProcess on x86_64"

Author: Med Ismail Bennani Date: 2023-06-13T13:45:59-07:00 New Revision: 68d964d02418576c7b9ecbe5e8426d9681a1d3a8 URL: https://github.com/llvm/llvm-project/commit/68d964d02418576c7b9ecbe5e8426d9681a1d3a8 DIFF:

[Lldb-commits] [lldb] ec05cf5 - [lldb] Improve corefile saving ergonomics

Author: Med Ismail Bennani Date: 2023-06-13T13:44:51-07:00 New Revision: ec05cf50daece35e0b01d3761e64ae54efe8a78e URL: https://github.com/llvm/llvm-project/commit/ec05cf50daece35e0b01d3761e64ae54efe8a78e DIFF:

[Lldb-commits] [lldb] 4177b49 - [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64

Author: Med Ismail Bennani Date: 2023-06-13T13:44:51-07:00 New Revision: 4177b490358432a457935ba5d6d076ae60de588f URL: https://github.com/llvm/llvm-project/commit/4177b490358432a457935ba5d6d076ae60de588f DIFF:

[Lldb-commits] [PATCH] D152842: [lldb] Improve corefile saving ergonomics

This revision was automatically updated to reflect the committed changes. Closed by commit rGec05cf50daec: [lldb] Improve corefile saving ergonomics (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152842/new/

[Lldb-commits] [PATCH] D152842: [lldb] Improve corefile saving ergonomics

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM, what do you think @jasonmolenda ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152842/new/ https://reviews.llvm.org/D152842

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

mib added inline comments. Comment at: lldb/source/Utility/Listener.cpp:214 } else { -pos = std::find_if(m_events.begin(), m_events.end(), - EventMatcher(broadcaster, event_type_mask)); +pos = std::find_if(m_events.begin(), m_events.end(),

[Lldb-commits] [PATCH] D152848: [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:253 case lldb::eStopReasonSignal: { -int signal; +unsigned int signal;

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:52 - void SetSDKRootDirectory(ConstString sdk_root_directory) { -m_sdk_sysroot = sdk_root_directory; + void SetSDKRootDirectory(llvm::StringRef sdk_root_directory) { +

[Lldb-commits] [PATCH] D152848: [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64

mib updated this revision to Diff 531017. mib added a comment. Re-enable test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152848/new/ https://reviews.llvm.org/D152848 Files: lldb/include/lldb/Utility/StructuredData.h lldb/source/Plugins/Process/scripted/ScriptedThread.cpp

[Lldb-commits] [PATCH] D152848: [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64

mib created this revision. mib added reviewers: bulbazord, jingham, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: pengfei. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should address the failure of

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4fcd411b3d: [lldb] Default can_create to true in GetChildMemberWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 7d4fcd4 - [lldb] Default can_create to true in GetChildMemberWithName (NFC)

Author: Dave Lee Date: 2023-06-13T11:37:41-07:00 New Revision: 7d4fcd411b3d790e5347c302e6a610ed793ece77 URL: https://github.com/llvm/llvm-project/commit/7d4fcd411b3d790e5347c302e6a610ed793ece77 DIFF: https://github.com/llvm/llvm-project/commit/7d4fcd411b3d790e5347c302e6a610ed793ece77.diff

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of writing boilerplate classes to serve as

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

bulbazord accepted this revision. bulbazord added a comment. I'm alright with this if Jim is. I think we should remove this parameter since it's never set to anything other than `true` from what I understand, but that can be done in a follow-up. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

This revision was automatically updated to reflect the committed changes. Closed by commit rGf94c7ffe4640: [lldb] Never print children if the max depth has been reached (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D152409?vs=529673=530994#toc Repository: rG

[Lldb-commits] [lldb] f94c7ff - [lldb] Never print children if the max depth has been reached

Author: Augusto Noronha Date: 2023-06-13T11:03:04-07:00 New Revision: f94c7ffe46400559740e7f81d7c60d8c0fe7df82 URL: https://github.com/llvm/llvm-project/commit/f94c7ffe46400559740e7f81d7c60d8c0fe7df82 DIFF:

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

aprantl added inline comments. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:169 + if (known_type == lldb::eLanguageTypeObjC && + UseSwiftRuntime(*m_parent, exe_ctx)) { +runtime = process->GetLanguageRuntime(lldb::eLanguageTypeSwift); This

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione added inline comments. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:119-123 +if (auto *runtime = llvm::dyn_cast_or_null( +process->GetLanguageRuntime(lldb::eLanguageTypeObjC))) + if (auto class_sp =

[Lldb-commits] [PATCH] D152842: [lldb] Improve corefile saving ergonomics

mib created this revision. mib added reviewers: bulbazord, jasonmolenda. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch improves the way the user can save

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

bulbazord added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:10 #include "lldb/Core/ValueObjectDynamicValue.h" +#include "Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h" #include "lldb/Core/Value.h"

[Lldb-commits] [PATCH] D151951: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151951/new/ https://reviews.llvm.org/D151951

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. It's OK to retain this as the default, and as you say, taking it out would be a trivial patch after this work. The control does allow you to do "Have I already made this child" before

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:52 - void SetSDKRootDirectory(ConstString sdk_root_directory) { -m_sdk_sysroot = sdk_root_directory; + void SetSDKRootDirectory(llvm::StringRef sdk_root_directory) { +

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Classes implemented in Swift can be exposed to ObjC.

[Lldb-commits] [PATCH] D152031: [lldb] Default can_create to true in GetChildAtIndex (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I can dream up a few speculative uses of `can_create => false` but they are all a little far-fetched. Certainly passing `true` is the dominant mode, so making it a default seems fine to me

[Lldb-commits] [PATCH] D152579: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map instead of name map

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. That does look like a thinko. Nothing about a file's section addresses changing will change the name to symbol map as that isn't dependent on load addresses. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D152573: [lldb][NFCI] Remove use of ConstString from Listener

This revision was automatically updated to reflect the committed changes. Closed by commit rG35419651c53c: [lldb][NFCI] Remove use of ConstString from Listener (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152573/new/

[Lldb-commits] [lldb] 3541965 - [lldb][NFCI] Remove use of ConstString from Listener

Author: Alex Langford Date: 2023-06-13T10:14:38-07:00 New Revision: 35419651c53c9f9a58d2b86a4ec61d47c2105c55 URL: https://github.com/llvm/llvm-project/commit/35419651c53c9f9a58d2b86a4ec61d47c2105c55 DIFF: https://github.com/llvm/llvm-project/commit/35419651c53c9f9a58d2b86a4ec61d47c2105c55.diff

[Lldb-commits] [PATCH] D152806: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae704bad900: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152806/new/

[Lldb-commits] [lldb] fae704b - [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test

Author: Michael Buch Date: 2023-06-13T15:08:21+01:00 New Revision: fae704bad90077a22e4534222903a6b03407650e URL: https://github.com/llvm/llvm-project/commit/fae704bad90077a22e4534222903a6b03407650e DIFF: https://github.com/llvm/llvm-project/commit/fae704bad90077a22e4534222903a6b03407650e.diff

[Lldb-commits] [PATCH] D152806: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test

oontvoo accepted this revision. oontvoo added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152806/new/ https://reviews.llvm.org/D152806

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

DavidSpickett updated this revision to Diff 530880. DavidSpickett added a comment. Correct size getter in read method. This just happened to work because the MTE set also contains one register. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152806: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This was un-XFAILed in `83cb2123be487302070562c45e6eb4955b22c2b4` due to D144999 .

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

hans edited reviewers, added: labath; removed: hans. hans added a comment. Herald added a subscriber: JDevlieghere. +labath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D152708: [RFC][Draft] Enable primitive support for Two-Level Line Tables in LLVM

StephenTozer added a comment. In D152708#4414402 , @dblaikie wrote: > It is unfortunate to hear that TLLT are a significant size increase, though > not entirely surprising - it's a bunch of extra info to encode. I'll be glad > to have this example to