[Lldb-commits] [lldb] b927490 - [lldb][NFCI] Remove unused struct ConstString::StringIsEqual

Author: Alex Langford Date: 2023-09-19T17:39:22-07:00 New Revision: b927490d73eebe0a7e8071047d79a330145b0488 URL: https://github.com/llvm/llvm-project/commit/b927490d73eebe0a7e8071047d79a330145b0488 DIFF: https://github.com/llvm/llvm-project/commit/b927490d73eebe0a7e8071047d79a330145b0488.diff

[Lldb-commits] [lldb] [lldb] Add interface to check if UserExpression::Parse() is cacheable (PR #66826)

https://github.com/jimingham approved this pull request. Presumably this will do something for Swift expressions? I don't think there's any reason that the expression for a location in C/C++/ObjC code would not be cacheable, so the fact that this is a no-op in all of llvm.org lldb is

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

jimingham wrote: Good eye! The cleanup actually does run but it was told to reset the directory to the "testdir" which is: build/lldb-test-build.noindex/commands/process/attach/TestProcessAttach.test_attach_to_process_from_different_dir_by_id but the tests are supposed to start in the source

[Lldb-commits] [lldb] 74338bf - A test was changing directory and then incorrectly restoring the directory

Author: Jim Ingham Date: 2023-09-19T16:46:08-07:00 New Revision: 74338bfe0cfec8b8db24af131cdeb664e346a1b5 URL: https://github.com/llvm/llvm-project/commit/74338bfe0cfec8b8db24af131cdeb664e346a1b5 DIFF: https://github.com/llvm/llvm-project/commit/74338bfe0cfec8b8db24af131cdeb664e346a1b5.diff

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:135 +process_sp->SetCanInterpretFunctionCalls(true); +process_sp->SetCanJIT(false); + } These should not be set in the ABI, please remove these. These are

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66551 >From 4c9d8d3f5be34d5ffec502a8fa891b603549b2cc Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:50:35 -0400 Subject: [PATCH] [lldb-vscode] Use auto summaries when variables have

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

mysterymath wrote: It looks like this is breaking buildbots: https://lab.llvm.org/buildbot/#/builders/68/builds/60267 The test can't find `main.cpp`, and it looks like the immediately preceding test issues an `os.chdir`. It has a hook to reset it, but maybe there's some problem with it?

[Lldb-commits] [lldb] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/66021 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add interface to check if UserExpression::Parse() is cacheable (PR #66826)

https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/66826 When setting conditional breakpoints, we currently assume that a call to UserExpression::Parse() can be cached and resued multiple times. This may not be true for every user expression. Add a new method so

[Lldb-commits] [lldb] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/5] [Clang] Static member initializers are not immediate

[Lldb-commits] [lldb] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/4] [Clang] Static member initializers are not immediate

[Lldb-commits] [lldb] Fix a bug with cancelling "attach -w" after you have run a process previously (PR #65822)

https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/65822 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7265f79 - Fix a bug with cancelling "attach -w" after you have run a process previously (#65822)

Author: jimingham Date: 2023-09-19T11:25:53-07:00 New Revision: 7265f792dc8e1157a3874aee5f8aed6d4d8236e7 URL: https://github.com/llvm/llvm-project/commit/7265f792dc8e1157a3874aee5f8aed6d4d8236e7 DIFF: https://github.com/llvm/llvm-project/commit/7265f792dc8e1157a3874aee5f8aed6d4d8236e7.diff

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneccessary allocation in ScriptInterpreterPythonImpl::GetSyntheticTypeName (PR #66724)

bulbazord wrote: Fixed with `f1097e88d22511f3ec96386ca165b75bb75aaa7a`. https://github.com/llvm/llvm-project/pull/66724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f1097e8 - [lldb] Fix build after d5a62b78b8ae

Author: Alex Langford Date: 2023-09-19T10:56:13-07:00 New Revision: f1097e88d22511f3ec96386ca165b75bb75aaa7a URL: https://github.com/llvm/llvm-project/commit/f1097e88d22511f3ec96386ca165b75bb75aaa7a DIFF: https://github.com/llvm/llvm-project/commit/f1097e88d22511f3ec96386ca165b75bb75aaa7a.diff

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneccessary allocation in ScriptInterpreterPythonImpl::GetSyntheticTypeName (PR #66724)

bulbazord wrote: I'm aware this has broken the build, working on it. Thanks for your patience. https://github.com/llvm/llvm-project/pull/66724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] d5a62b7 - [lldb][NFCI] Remove unneccessary allocation in ScriptInterpreterPythonImpl::GetSyntheticTypeName (#66724)

Author: Alex Langford Date: 2023-09-19T10:49:53-07:00 New Revision: d5a62b78b8ae1856e9eecf7d034ce6a1fbc0a76a URL: https://github.com/llvm/llvm-project/commit/d5a62b78b8ae1856e9eecf7d034ce6a1fbc0a76a DIFF: https://github.com/llvm/llvm-project/commit/d5a62b78b8ae1856e9eecf7d034ce6a1fbc0a76a.diff

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneccessary allocation in ScriptInterpreterPythonImpl::GetSyntheticTypeName (PR #66724)

https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/66724 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 45e6e4d - [lldb][NFCI] Remove unneeded ConstString from intel-pt plugin (#66721)

Author: Alex Langford Date: 2023-09-19T10:49:38-07:00 New Revision: 45e6e4d70e1e5bdd7d9f04dfd0f4cc8798bcde0c URL: https://github.com/llvm/llvm-project/commit/45e6e4d70e1e5bdd7d9f04dfd0f4cc8798bcde0c DIFF: https://github.com/llvm/llvm-project/commit/45e6e4d70e1e5bdd7d9f04dfd0f4cc8798bcde0c.diff

[Lldb-commits] [lldb] [lldb][NFCI] Remove unneeded ConstString from intel-pt plugin (PR #66721)

https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/66721 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

@@ -18,19 +18,45 @@ Please refer to the `LLVM Developer Policy authoring and uploading a patch. LLDB differs from the LLVM Developer Policy in the following respects. - - **Test infrastructure**: Like LLVM it is important to submit tests with your - patches, but note that

[Lldb-commits] [lldb] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

goldsteinn wrote: Created: https://github.com/llvm/llvm-project/pull/66793 which fixes the backend regression this can cause. https://github.com/llvm/llvm-project/pull/66740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. FYI I will be away next week, and the week after that Phab is supposed to be made read-only. So look to @jasonmolenda to approve in that time frame, or we can take this to a PR after that. Comment at:

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:262 + // NOTE: It's unsafe to iterate through LLDB_REGNUM_GENERICs + // But the a registers re sequential in the RISC-V register space + ++reg_index;

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted updated this revision to Diff 557049. ted added a comment. Fix crash when there was no process. Remove bugs in function call setup when using IR interpreter. Change flag tests to use lldb_private::Flags for flags testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

llvmbot wrote: @llvm/pr-subscribers-lldb Changes This fixes a bug where writing vg during streaming mode could prevent you reading za directly afterwards. vg is invalided when the write happens. SVE is reconfigured by reading back the new value from the remote. So far so good. For SME,

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett abandoned this revision. DavidSpickett added a comment. Moved to https://github.com/llvm/llvm-project/pull/66768. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

DavidSpickett wrote: Replaces https://reviews.llvm.org/D158514. https://github.com/llvm/llvm-project/pull/66768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef (PR #66768)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/66768 This fixes a bug where writing vg during streaming mode could prevent you reading za directly afterwards. vg is invalided when the write happens. SVE is reconfigured by reading back the new value from

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

llvmbot wrote: @llvm/pr-subscribers-lldb Changes This adds a release note for all the SME support now in LLDB and a page where I have documented the user experience (for want of a better term) when using SVE and SME. This includes things like which mode transitions can or cannot be

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett abandoned this revision. DavidSpickett added a comment. Moved to https://github.com/llvm/llvm-project/pull/66767. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

DavidSpickett wrote: Replaces https://reviews.llvm.org/D158506. https://github.com/llvm/llvm-project/pull/66767 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Add release notes and documentation for SME (PR #66767)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/66767 This adds a release note for all the SME support now in LLDB and a page where I have documented the user experience (for want of a better term) when using SVE and SME. This includes things like which

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: Thanks, man! On Tue, Sep 19, 2023, 4:53 AM David Spickett ***@***.***> wrote: > 9568601 > > > — > Reply to this email directly, view it on GitHub >

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe96adfd0dbcf: [lldb][AArch64] Add testing for SMEs ZA and SVG registers (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e96adfd - [lldb][AArch64] Add testing for SME's ZA and SVG registers

Author: David Spickett Date: 2023-09-19T12:18:23Z New Revision: e96adfd0dbcf84c27be2087371890f4228890609 URL: https://github.com/llvm/llvm-project/commit/e96adfd0dbcf84c27be2087371890f4228890609 DIFF: https://github.com/llvm/llvm-project/commit/e96adfd0dbcf84c27be2087371890f4228890609.diff

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557034. DavidSpickett added a comment. Fix some python formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files:

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

This revision was automatically updated to reflect the committed changes. Closed by commit rG46b961f36bc5: [lldb][AArch64] Implement resizing of SMEs ZA register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/

[Lldb-commits] [lldb] 46b961f - [lldb][AArch64] Implement resizing of SME's ZA register

Author: David Spickett Date: 2023-09-19T12:05:22Z New Revision: 46b961f36bc5b1105356d1701f0c7c9d439be9c8 URL: https://github.com/llvm/llvm-project/commit/46b961f36bc5b1105356d1701f0c7c9d439be9c8 DIFF: https://github.com/llvm/llvm-project/commit/46b961f36bc5b1105356d1701f0c7c9d439be9c8.diff

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0768b8237ad: [lldb][AArch64] Add SME streaming vector length pseduo register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a0768b8 - [lldb][AArch64] Add SME streaming vector length pseduo register

Author: David Spickett Date: 2023-09-19T11:18:27Z New Revision: a0768b8237ad83a6493a5053e615e0c38d7410ee URL: https://github.com/llvm/llvm-project/commit/a0768b8237ad83a6493a5053e615e0c38d7410ee DIFF: https://github.com/llvm/llvm-project/commit/a0768b8237ad83a6493a5053e615e0c38d7410ee.diff

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

This revision was automatically updated to reflect the committed changes. Closed by commit rGd99d9d8b74ff: [lldb][AArch64] Add SMEs Array Storage (ZA) register (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/

[Lldb-commits] [lldb] d99d9d8 - [lldb][AArch64] Add SME's Array Storage (ZA) register

Author: David Spickett Date: 2023-09-19T10:49:57Z New Revision: d99d9d8b74ffcb8ac418fcdafa750b07f2bd9935 URL: https://github.com/llvm/llvm-project/commit/d99d9d8b74ffcb8ac418fcdafa750b07f2bd9935 DIFF: https://github.com/llvm/llvm-project/commit/d99d9d8b74ffcb8ac418fcdafa750b07f2bd9935.diff

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557021. DavidSpickett added a comment. Clarify comment about SIGILL from inactive ZA. Fix some leftover clang-format issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/main.c:12 +// (this is just how ptrace works). +// * Writing to an inactive ZA produces a SIGILL. + omjavaid wrote: > Is this a

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. this looks good Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/main.c:12 +// (this is just how ptrace works). +// *

[Lldb-commits] [PATCH] D158514: [lldb][AArch64] Invalidate SVG prior to reconfiguring ZA regdef

DavidSpickett updated this revision to Diff 557014. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158514/new/ https://reviews.llvm.org/D158514 Files:

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 557013. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 Files: lldb/docs/index.rst lldb/docs/use/aarch64-linux.rst

[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

DavidSpickett updated this revision to Diff 557012. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158500/new/ https://reviews.llvm.org/D158500 Files:

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 557011. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files:

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett updated this revision to Diff 557010. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 Files:

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/Makefile:3 + +CFLAGS_EXTRAS := -march=armv8-a+sve+sme -lpthread + DavidSpickett

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

DavidSpickett updated this revision to Diff 557009. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 Files:

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

DavidSpickett updated this revision to Diff 557008. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 Files:

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

DavidSpickett updated this revision to Diff 557007. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ https://reviews.llvm.org/D159502 Files: lldb/include/lldb/Utility/RegisterValue.h

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

DavidSpickett wrote: https://github.com/llvm/llvm-project/commit/956860168b56f135b9facf3827ae9f3634d41f40 https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 91f46ec - [lldb][AArch64] Document how to control the SVE/SSVE tests

Author: David Spickett Date: 2023-09-19T08:51:37Z New Revision: 91f46ece9efca7a1109b5837a1b24f2a251bb0cc URL: https://github.com/llvm/llvm-project/commit/91f46ece9efca7a1109b5837a1b24f2a251bb0cc DIFF: https://github.com/llvm/llvm-project/commit/91f46ece9efca7a1109b5837a1b24f2a251bb0cc.diff

[Lldb-commits] [lldb] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

nikic wrote: I think this is the right canonicalization at the IR level, as select allows better analysis than zext(icmp). However, this seems to be universally worse for the backend: https://llvm.godbolt.org/z/Yh7brfc8b So I think we would need an SDAG undo transform. Interestingly, this

[Lldb-commits] [lldb] 9568601 - [lldb] Correct expected output for variable on 32 bit platforms

Author: David Spickett Date: 2023-09-19T08:28:34Z New Revision: 956860168b56f135b9facf3827ae9f3634d41f40 URL: https://github.com/llvm/llvm-project/commit/956860168b56f135b9facf3827ae9f3634d41f40 DIFF: https://github.com/llvm/llvm-project/commit/956860168b56f135b9facf3827ae9f3634d41f40.diff

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

@@ -1696,6 +1696,40 @@ TEST(Support, ReplacePathPrefix) { EXPECT_EQ(Path, "C:\\old/foo\\bar"); } +TEST(Support, FindProgramName) { + StringRef WindowsProgName = + path::program_name("C:\\Test\\foo.exe", path::Style::windows); + EXPECT_EQ(WindowsProgName, "foo"); + +

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

https://github.com/jh7370 approved this pull request. Force pushing (and therefore rebasing) is [supposed to be avoided](https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes) unless it's absolutely necessary. Was a rebase actually required for this change? One of the

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

@@ -5,11 +5,14 @@ # RUN: mkdir %t # RUN: ln -s llvm-ranlib %t/llvm-ranlib-9 # RUN: ln -s llvm-ranlib %t/ranlib.exe +# RUN: ln -s llvm-ranlib %t/x86_64-unknown-freebsd13.2-llvm-ranlib jh7370 wrote: Let's put the new test files and deletion of this old test in

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:201 +self.runCmd("register write za '{}'".format(za_value)) +self.expect("register read za", substrs=[za_value])

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

DavidSpickett wrote: This is failing on Arm 32 bit (https://lab.llvm.org/buildbot/#/builders/17/builds/43300), I'll reproduce and fix it. I expect it just needs to expect 8 hex characters instead of 16. https://github.com/llvm/llvm-project/pull/66548

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:201 +self.runCmd("register write za '{}'".format(za_value)) +self.expect("register read za", substrs=[za_value])

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/66345 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ca723f2 - [lldb][Docs] Document our major differences from the LLVM style (#66345)

Author: David Spickett Date: 2023-09-19T08:23:00+01:00 New Revision: ca723f2d40baf6c84e4c0907040e0c3f226d6302 URL: https://github.com/llvm/llvm-project/commit/ca723f2d40baf6c84e4c0907040e0c3f226d6302 DIFF:

[Lldb-commits] [lldb] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

dtcxzyw wrote: > We should use rebase instead of merge. And I recommend force push to change > the code before the review starts. I am confused with the LLVM GitHub user guide. I witnessed someone mess up by doing rebase + force push. Examples: #65853 #65543 #65535

[Lldb-commits] [lldb] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

DianQK wrote: We should use rebase instead of merge. I recommend force push to change the code before the review starts. https://github.com/llvm/llvm-project/pull/66740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org