llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Peixotto (dmpots)
Changes
This commit adds a new `ValueMatcher` class that can be used in gtest matching
contexts to match against `lldb_private::Value` objects. We always match
against the values `value_type` and `context_type`. For
@@ -0,0 +1,67 @@
+"""
+Test lldb-dap stackTrace request for compiler generated code
+"""
+
+import os
+
+import lldbdap_testcase
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+
+
+class
TestDAP_stackTraceCompilerGeneratedCode(lldbdap_testcase.DAP
https://github.com/JDevlieghere approved this pull request.
LGTM. Maybe try to add a little bit more context in the PR summary (e.g. that
this was incorrectly copy/pasted when adding support for the v16 layout). Just
listing the radar makes it seem like there might be more to it that external
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/161870
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/161870
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -986,6 +987,42 @@ class LLDB_API SBTarget {
lldb::SBMutex GetAPIMutex() const;
+ /// Register a scripted frame provider for this target.
+ /// If a scripted frame provider with the same name is already registered on
+ /// this target, it will be overwritten.
+ ///
+
JustinStitt wrote:
It is my understanding that we cannot have both 1) overloading on OBT and 2) no
mangling on OBT. FWIW, our first user of this may very well be the Linux kernel
and I don't think they care much about the overloading semantics of OBTs.
Personally, I also don't care which way w
qxy11 wrote:
@ashgti Thanks for the suggestion! Do you have recommendations for what to
include if we were to implement Initialize/Terminate? I was trying to think of
what we'd do, but DAPSessionManager's just a coordinator/registry that keeps
some maps that
qxy11 wrote:
This didn't end up working here and we may need to keep this intentional leak
due to issues w/ the destructor chain. It seemed to cause DAP to hang since the
ManagedStatic seemed to try to destroy the DAPSessionManager and some resources
may have
@@ -295,4 +307,267 @@ void SendMemoryEvent(DAP &dap, lldb::SBValue variable) {
dap.Send(protocol::Event{"memory", std::move(body)});
}
+// Note: EventThread() is architecturally different from the other functions in
+// this file. While the functions above are event helpers
@@ -986,6 +987,42 @@ class LLDB_API SBTarget {
lldb::SBMutex GetAPIMutex() const;
+ /// Register a scripted frame provider for this target.
+ /// If a scripted frame provider with the same name is already registered on
+ /// this target, it will be overwritten.
+ ///
+
@@ -419,15 +421,17 @@ def __init__(self, thread, args):
self.register_ctx = {}
self.variables = []
-if (
-isinstance(thread, ScriptedThread)
-or isinstance(thread, lldb.SBThread)
-and thread.IsValid()
+if isin
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff origin/main HEAD --extensions cpp,h --
lldb/tools/lldb-dap/DAPSessionManager.cpp
lld
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/164794
>From 0a169b49add9f12cb3558b6147e784819de4b3ca Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Thu, 23 Oct 2025 09:09:36 +0200
Subject: [PATCH 01/10] Test no-LLVM gtest
---
cmake/Modules/AddGTest.cmake
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/163659
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/163659
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -188,8 +188,13 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
// This addresses the cases where the embedded interpreter session
// dictionary is passed to the extension initializer which is not used
// most of the time.
+ // No
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/166876
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/n2h9 updated https://github.com/llvm/llvm-project/pull/165163
>From aba4890ee4ce4e3c37961a3997d21832f904f599 Mon Sep 17 00:00:00 2001
From: Nikita B
Date: Sun, 26 Oct 2025 18:49:43 +0100
Subject: [PATCH 01/18] [lldb] [disassembler] chore: enhance VariableAnnotator
to return s
@@ -15,11 +15,11 @@
#include "clang/Driver/Action.h"
#include "clang/Driver/DriverDiagnostic.h"
#include "clang/Driver/InputInfo.h"
-#include "clang/Driver/Options.h"
#include "clang/Driver/Phases.h"
#include "clang/Driver/ToolChain.h"
#include "clang/Driver/Types.h"
#inclu
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/163659
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -15,11 +15,11 @@
#include "clang/Driver/Action.h"
#include "clang/Driver/DriverDiagnostic.h"
#include "clang/Driver/InputInfo.h"
-#include "clang/Driver/Options.h"
#include "clang/Driver/Phases.h"
#include "clang/Driver/ToolChain.h"
#include "clang/Driver/Types.h"
#inclu
https://github.com/naveen-seth deleted
https://github.com/llvm/llvm-project/pull/163659
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
naveen-seth wrote:
> @naveen-seth there's still a reference to `Options.h` in
> https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Driver.h#L22
> that makes clang unbuildable.
Hmm this is odd. Looking at the git diff here, it should hav
dmpots wrote:
@JDevlieghere @felipepiovezan What should be the next steps here? Do we need to
spin up a discussion with the community?
https://github.com/llvm/llvm-project/pull/167018
___
lldb-commits mailing list
[email protected]
https://l
@@ -16,14 +16,27 @@
namespace lldb_dap {
+static bool CheckAddress(DAP &dap, lldb::addr_t load_addr) {
ashgti wrote:
nit: Can we give this a more descriptive name? Like `IsRW` or `IsMutable` I
think thats what this is checking...?
https://github.com/llvm/l
@@ -1234,16 +1234,24 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
return response
def request_dataBreakpointInfo(
-self, variablesReference, name, frameIndex=0, threadId=None
+self, variablesReference, name, s
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/166876
>From 38d0bd20d4b3d7b5fb7c053684a533b15510897f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 6 Nov 2025 16:07:30 -0800
Subject: [PATCH 1/2] [lldb] Fix crash in BreakpointSite::BumpHitCounts
F
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/166876
>From 38d0bd20d4b3d7b5fb7c053684a533b15510897f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 6 Nov 2025 16:07:30 -0800
Subject: [PATCH 1/2] [lldb] Fix crash in BreakpointSite::BumpHitCounts
F
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/167348
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
It sounds like you're on the fence. If you're looking for a tie-breaker... I
hate recursive mutexes as much as anyone else, but it's nice that you don't
have to think about it and it takes away a potential foot gun down the road.
https://github.com/llvm/llvm-project/pull/16
llvmbot wrote:
@llvm/pr-subscribers-backend-powerpc
@llvm/pr-subscribers-clang
Author: Naveen Seth Hanig (naveen-seth)
Changes
Reverts llvm/llvm-project#163659 due to missing one reference
clang/Driver/Options.h in `clang/include/clang/Driver/Driver.h`.
See https://github.com/llvm/llvm-p
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Naveen Seth Hanig (naveen-seth)
Changes
Reverts llvm/llvm-project#163659 due to missing one reference
clang/Driver/Options.h in `clang/include/clang/Driver/Driver.h`.
See https://github.com/llvm/llvm-project/pull/163659#issuecomment
https://github.com/naveen-seth edited
https://github.com/llvm/llvm-project/pull/167348
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
naveen-seth wrote:
Thank you. Reverting now.
https://github.com/llvm/llvm-project/pull/163659
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
npanchen wrote:
@naveen-seth there's still a reference to `Options.h` in
https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Driver/Driver.h#L22
that makes clang unbuildable
https://github.com/llvm/llvm-project/pull/163659
___
lldb-com
https://github.com/naveen-seth closed
https://github.com/llvm/llvm-project/pull/163659
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Meinersbur updated
https://github.com/llvm/llvm-project/pull/164794
>From 0a169b49add9f12cb3558b6147e784819de4b3ca Mon Sep 17 00:00:00 2001
From: Michael Kruse
Date: Thu, 23 Oct 2025 09:09:36 +0200
Subject: [PATCH 1/8] Test no-LLVM gtest
---
cmake/Modules/AddGTest.cmake
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/163659
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
naveen-seth wrote:
> I would say if there are no negative comments by Friday, I'll accept the RFC
> and we should be fine to land.
Hi @AaronBallman, I wasn't sure if I was supposed to merge after Friday if
there were no negative comments (without an explicit approval). Just wanted to
confirm
da-viper wrote:
It came from the `InitializeRequestHandler` file. I don't mind moving it to
`EventHelper` but the DAP file is not really large (approx 1701 LOC)
https://github.com/llvm/llvm-project/pull/166948
___
lldb-commits mailing list
lldb-commi
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/166948
>From d0a0878fd7eec48d6923b5503ee475723be49a05 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Fri, 7 Nov 2025 14:44:41 +
Subject: [PATCH 1/2] [lldb-dap] Refactor event thread
Handle each event type in a
@@ -0,0 +1,17 @@
+void bar() {
+ int val = 32; // breakpoint here
+}
+
+void at_line_zero() {}
+
+int foo() {
da-viper wrote:
please, forward declare `foo()` and move the definition to bottom of the file
so the line directive does not affect the `main()` functi
@@ -0,0 +1,67 @@
+"""
+Test lldb-dap stackTrace request for compiler generated code
+"""
+
+import os
+
+import lldbdap_testcase
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+
+
+class
TestDAP_stackTraceCompilerGeneratedCode(lldbdap_testcase.DAP
https://github.com/da-viper approved this pull request.
https://github.com/llvm/llvm-project/pull/165944
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -657,18 +657,29 @@ std::optional DAP::ResolveSource(const
lldb::SBFrame &frame) {
if (!frame.IsValid())
return std::nullopt;
- const lldb::SBAddress frame_pc = frame.GetPCAddress();
- if (DisplayAssemblySource(debugger, frame_pc))
+ // IMPORTANT: Get line entry fr
@@ -0,0 +1,67 @@
+"""
+Test lldb-dap stackTrace request for compiler generated code
+"""
+
+import os
+
+import lldbdap_testcase
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+
+
+class
TestDAP_stackTraceCompilerGeneratedCode(lldbdap_testcase.DAP
Fznamznon wrote:
cc @llvm/clang-vendors as it is potentially breaking change.
https://github.com/llvm/llvm-project/pull/165598
___
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8?q?Košík?= ,
Matej =?utf-8
49 matches
Mail list logo
