[Lldb-commits] [lldb] f21fccc - [LLDB] Fix 37 tests on Windows

Author: Adrian McCarthy Date: 2020-10-12T11:10:00-07:00 New Revision: f21fcccef7197f911a27b960aa2a180e0c7724aa URL: https://github.com/llvm/llvm-project/commit/f21fcccef7197f911a27b960aa2a180e0c7724aa DIFF:

[Lldb-commits] [lldb] 7ddfb95 - [lldb] Fix unit test parsing to handle CR+LF as well as LF

Author: Adrian McCarthy Date: 2020-08-12T13:56:16-07:00 New Revision: 7ddfb956e1a5ee91d0d30f33ca0c84faeb471db4 URL: https://github.com/llvm/llvm-project/commit/7ddfb956e1a5ee91d0d30f33ca0c84faeb471db4 DIFF:

[Lldb-commits] [lldb] 479f5bf - [LLDB] Improve PDB discovery

Author: Adrian McCarthy Date: 2020-08-11T13:44:14-07:00 New Revision: 479f5bfdb02b191f03b3de1a7c3d5a5098b3fcaf URL: https://github.com/llvm/llvm-project/commit/479f5bfdb02b191f03b3de1a7c3d5a5098b3fcaf DIFF:

[Lldb-commits] [lldb] 72958c9 - [lldb] Eliminated unused local variable

Author: Adrian McCarthy Date: 2020-07-16T14:44:24-07:00 New Revision: 72958c9ab1cdf18c447778b836f13694a7e4e9e1 URL: https://github.com/llvm/llvm-project/commit/72958c9ab1cdf18c447778b836f13694a7e4e9e1 DIFF:

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

On Wed, Mar 25, 2020 at 9:49 AM Adrian McCarthy wrote: > > > On Wed, Mar 25, 2020 at 9:10 AM Pavel Labath wrote: > >> On 25/03/2020 01:04, Adrian McCarthy wrote: >> > I took a stab at this, but I'm not seeing any new test failures. >> >> That is odd. >> >> I was doing some stuff on windows

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

On Wed, Mar 25, 2020 at 9:10 AM Pavel Labath wrote: > On 25/03/2020 01:04, Adrian McCarthy wrote: > > I took a stab at this, but I'm not seeing any new test failures. > > That is odd. > > I was doing some stuff on windows today, so I figured I'd take a stab at > this. I was kind of right that

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

Oh, and in case I wasn't clear: I re-enabled the test TestSettings.py locally. On Tue, Mar 24, 2020 at 5:04 PM Adrian McCarthy wrote: > I took a stab at this, but I'm not seeing any new test failures. Can you > point me to the specific test and provide a log showing the failures? > > I've

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

I took a stab at this, but I'm not seeing any new test failures. Can you point me to the specific test and provide a log showing the failures? I've been using `ninja check-lldb`, which runs (almost everything) and none of the failures I'm seeing are related to inherit-env. I assume the problem

Re: [Lldb-commits] [lldb] b4a6e63 - [lldb/Target] Rework the way the inferior environment is created

I'll take a look this morning. On Tue, Mar 24, 2020 at 7:00 AM Pavel Labath wrote: > On 23/03/2020 17:17, Frédéric Riss via lldb-commits wrote: > > The new testing for “inherit-env=false” is failing on Windows. I skipped > the test for now. > > > > Could it be that it never worked there? (In

[Lldb-commits] [lldb] fb0d2d4 - Fix after c25938d

Author: Adrian McCarthy Date: 2020-02-04T16:37:22-08:00 New Revision: fb0d2d455f56bca239041c8d7ad7b57da1087b35 URL: https://github.com/llvm/llvm-project/commit/fb0d2d455f56bca239041c8d7ad7b57da1087b35 DIFF:

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

t; > Seems like your change is more informative. Could we just fix the tests? > > > > Jim > > > > > > > On Feb 4, 2020, at 11:18 AM, Adrian McCarthy via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > > > I see why the

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

> > > On Feb 4, 2020, at 11:18 AM, Adrian McCarthy via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > I see why the behavior is different, but I'm not sure whether the new > behavior is wrong. > > > > The old code nested a bunch of if-su

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

ol file 'FILENAME' does not match any existing module >> > >> > but we're now getting, >> > >> > error: the object file could not be loaded >> > >> > and the test doesn't expect that. >> > >> > >> > I'm looking into this

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

t that. > > > > > > I'm looking into this, to see if I can get the more specific error > message back in here again. I may xfail the test if I don't have a patch > done tonight. I'd rather not test for this new generic error message if > it's avoidable. > > >

[Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

Author: Adrian McCarthy Date: 2020-02-03T14:22:05-08:00 New Revision: c25938d57b1cf9534887313405bc409e570a9b69 URL: https://github.com/llvm/llvm-project/commit/c25938d57b1cf9534887313405bc409e570a9b69 DIFF:

[Lldb-commits] [lldb] 0e362d8 - Improve help text for (lldb) target symbols add

Author: Adrian McCarthy Date: 2020-02-03T14:22:05-08:00 New Revision: 0e362d82b97fe16b5671ceeb2f3e5b6f4ccf00dd URL: https://github.com/llvm/llvm-project/commit/0e362d82b97fe16b5671ceeb2f3e5b6f4ccf00dd DIFF:

[Lldb-commits] [lldb] 3b69f0c - [NFC] Refactor and improve comments in CommandObjectTarget

Author: Adrian McCarthy Date: 2019-11-21T08:37:35-08:00 New Revision: 3b69f0c5550a229dd6d39e361182cdd7cecc36a4 URL: https://github.com/llvm/llvm-project/commit/3b69f0c5550a229dd6d39e361182cdd7cecc36a4 DIFF:

Re: [Lldb-commits] [lldb] f8a92af - [LLDB] Remove incorrect dotest.py invocation

It looks like this was the only call to getRerunArgs, so why not delete it? On Mon, Oct 28, 2019 at 1:24 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Jonas Devlieghere > Date: 2019-10-28T13:24:07-07:00 > New Revision:

[Lldb-commits] [lldb] 5a3c657 - Fix after 738af7a6241c98164625b9cd1ba9f8af4e36f197

Author: Adrian McCarthy Date: 2019-10-25T15:57:52-07:00 New Revision: 5a3c657f3e8fe83ed5074edee94fb2303cd5fa2e URL: https://github.com/llvm/llvm-project/commit/5a3c657f3e8fe83ed5074edee94fb2303cd5fa2e DIFF:

[Lldb-commits] [lldb] r371882 - Fix error in ProcessLauncherWindows.cpp

Author: amccarth Date: Fri Sep 13 11:50:39 2019 New Revision: 371882 URL: http://llvm.org/viewvc/llvm-project?rev=371882=rev Log: Fix error in ProcessLauncherWindows.cpp Restored missing parens on a function call. Modified: lldb/trunk/source/Host/windows/ProcessLauncherWindows.cpp

[Lldb-commits] [lldb] r371090 - Fix windows-x86-debug compilation with python enabled using multi-target generator

Author: amccarth Date: Thu Sep 5 10:22:30 2019 New Revision: 371090 URL: http://llvm.org/viewvc/llvm-project?rev=371090=rev Log: Fix windows-x86-debug compilation with python enabled using multi-target generator [Patch by Leonid Mashinskiy] Visual Studio CMake generator is multi-target and

Re: [Lldb-commits] [lldb] r370776 - [lldb][NFC] Disable added frame select and all log option test on windows

Does disabling tests really quality a patch for the [NFC] label? Are these buggy tests or is there something that makes the actually not relevant on Windows? On Tue, Sep 3, 2019 at 9:20 AM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: teemperor > Date: Tue Sep

[Lldb-commits] [lldb] r367573 - Fix TestThreadSpecificBreakpoint on Windows

Author: amccarth Date: Thu Aug 1 07:49:54 2019 New Revision: 367573 URL: http://llvm.org/viewvc/llvm-project?rev=367573=rev Log: Fix TestThreadSpecificBreakpoint on Windows This test was frequently hanging on Windows, causing a timeout after 10 minutes. The short delay (100 microsecond) in the

[Lldb-commits] [lldb] r366703 - [Windows] Fix race condition between state changes

Author: amccarth Date: Mon Jul 22 10:03:20 2019 New Revision: 366703 URL: http://llvm.org/viewvc/llvm-project?rev=366703=rev Log: [Windows] Fix race condition between state changes Patch by Martin Andersson (martin.anders...@evoma.se) If the process is resumed before the state is changed to

[Lldb-commits] [lldb] r366383 - [NFC] Clarify a Cmake status message regarding Python on LLDBConfig

Author: amccarth Date: Wed Jul 17 15:36:26 2019 New Revision: 366383 URL: http://llvm.org/viewvc/llvm-project?rev=366383=rev Log: [NFC] Clarify a Cmake status message regarding Python on LLDBConfig Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake Modified:

Re: [Lldb-commits] [lldb] r366356 - [dotest] Disable color while testing.

I thought the color code was smart enough to figure out whether it was actually going to an actual terminal or being redirected. Is this hiding a bug in that logic? On Wed, Jul 17, 2019 at 10:56 AM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jdevlieghere >

[Lldb-commits] [lldb] r364361 - Fix a typo in help text.

Author: amccarth Date: Tue Jun 25 16:13:16 2019 New Revision: 364361 URL: http://llvm.org/viewvc/llvm-project?rev=364361=rev Log: Fix a typo in help text. Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp URL:

[Lldb-commits] [lldb] r362845 - NFC: Fix typo in a cmake message

Author: amccarth Date: Fri Jun 7 14:14:01 2019 New Revision: 362845 URL: http://llvm.org/viewvc/llvm-project?rev=362845=rev Log: NFC: Fix typo in a cmake message Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake Modified: lldb/trunk/cmake/modules/LLDBConfig.cmake URL:

[Lldb-commits] [lldb] r362844 - Fix lit tests on Windows related to CR+LF

Author: amccarth Date: Fri Jun 7 14:13:30 2019 New Revision: 362844 URL: http://llvm.org/viewvc/llvm-project?rev=362844=rev Log: Fix lit tests on Windows related to CR+LF Problem discovered in the breakpoint lit test, but probably exists in others. lldb-test splits lines on LF. Input files

[Lldb-commits] [lldb] r357626 - Fix and simplify PrepareCommandsForSourcing

Author: amccarth Date: Wed Apr 3 12:49:14 2019 New Revision: 357626 URL: http://llvm.org/viewvc/llvm-project?rev=357626=rev Log: Fix and simplify PrepareCommandsForSourcing Spotted some problems in the Driver's PrepareCommandsForSourcing while helping a colleague track another problem. 1. One

[Lldb-commits] [lldb] r355943 - Correcting some comments in PdbIndex.cpp [NFC]

Author: amccarth Date: Tue Mar 12 10:40:51 2019 New Revision: 355943 URL: http://llvm.org/viewvc/llvm-project?rev=355943=rev Log: Correcting some comments in PdbIndex.cpp [NFC] ICF can cause multiple symbols to start at the same virtual address. I plan to handle this shortly, but I wanted to

[Lldb-commits] [lldb] r355121 - Improve process launch comments for Windows

Author: amccarth Date: Thu Feb 28 11:14:02 2019 New Revision: 355121 URL: http://llvm.org/viewvc/llvm-project?rev=355121=rev Log: Improve process launch comments for Windows The existing comment about over-allocating the command line was incorrect. The contents of the command line may be

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

> But here, we're talking about a situation where there is no EXE, only a minidump. If there is a minidump and no EXE then neither WinDbg nor VS will search the minidump folder for the PDB. For the record, the experiments do not bear this out. VS will indeed search in the minidump folder for

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

I believe the PDB is searched for in the EXE directory before the symbol search path is used. At least, that's what it used to do, back when I used VS debugger for post-mortem debugging. It was the only sane way to ensure it would find the right version of the PDB if you didn't have a local

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

It's really frustrating how the email discussion doesn't always make it to Phabricator. The Windowsy thing to do is what Zach said: Check the directory that contains the .dmp for the .pdb. It's the first place the VS debugger looks when opening a minidump. It's less sensitive to the user's

Re: [Lldb-commits] Support of MSVC function-level linking

Can you post your patch to https://reviews.llvm.org/ ? On Thu, May 31, 2018 at 10:36 AM, Leonard Mosescu via lldb-commits < lldb-commits@lists.llvm.org> wrote: > If anyone's working on this I'd suggest adding a test case for the "split > code" case as well (where even a single function is split

[Lldb-commits] [lldb] r326130 - Partial fix for TestConflictingSymbol.py on Windows

Author: amccarth Date: Mon Feb 26 13:22:39 2018 New Revision: 326130 URL: http://llvm.org/viewvc/llvm-project?rev=326130=rev Log: Partial fix for TestConflictingSymbol.py on Windows Without this fix, the test ERRORs because the link of the inferior fails. This patch adds the LLDB_TEST_API macro

[Lldb-commits] [lldb] r326095 - Fix tabs/spaces indentation problem in TestUnicodeSymbols.py

Author: amccarth Date: Mon Feb 26 07:53:31 2018 New Revision: 326095 URL: http://llvm.org/viewvc/llvm-project?rev=326095=rev Log: Fix tabs/spaces indentation problem in TestUnicodeSymbols.py Differential Revision: https://reviews.llvm.org/D43705 Modified:

[Lldb-commits] [lldb] r325836 - Fix TestMoveNearest on Windows

Author: amccarth Date: Thu Feb 22 14:47:47 2018 New Revision: 325836 URL: http://llvm.org/viewvc/llvm-project?rev=325836=rev Log: Fix TestMoveNearest on Windows The header file for the DLL tried to declare inline functions and a local function as dllexport which broke the compile and link.

[Lldb-commits] [lldb] r325835 - Fix TestSBData.py on Windows

Author: amccarth Date: Thu Feb 22 14:47:14 2018 New Revision: 325835 URL: http://llvm.org/viewvc/llvm-project?rev=325835=rev Log: Fix TestSBData.py on Windows Ensure that the test data is an array of bytes rather than a string that gets encoded differently between Python 2 and Python 3.

[Lldb-commits] [lldb] r325704 - Fix TestBreakpointInGlobalConstructor for Windows

Author: amccarth Date: Wed Feb 21 10:08:23 2018 New Revision: 325704 URL: http://llvm.org/viewvc/llvm-project?rev=325704=rev Log: Fix TestBreakpointInGlobalConstructor for Windows Summary: This test was failing on Windows because it expected the breakpoint in the dynamic library to be resolved

[Lldb-commits] [lldb] r325188 - Supply missing break in case statement.

Author: amccarth Date: Wed Feb 14 15:16:36 2018 New Revision: 325188 URL: http://llvm.org/viewvc/llvm-project?rev=325188=rev Log: Supply missing break in case statement. Summary: All the tests pass without hitting the situation mentioned in the FIXME, so, per Aaron Smith's suggestion, this case

[Lldb-commits] [lldb] r324925 - Remove dead code for handling DWARF pubnames

Author: amccarth Date: Mon Feb 12 11:19:04 2018 New Revision: 324925 URL: http://llvm.org/viewvc/llvm-project?rev=324925=rev Log: Remove dead code for handling DWARF pubnames Summary: LLDB doesn't use this code, the code has no tests, and the code does suspicious things like hashing pointers to

Re: [Lldb-commits] [lldb] r320242 - Change uses of strncpy in debugserver to strlcpy

I have some concerns about this change. 1. strlcpy is not a C++ standard function, so it's not available for non-POSIX targets. As far as I can tell, this is the first use of strlcpy in LLVM. 2. In some of the changed calls, the buffer size argument still has a -1, which is redundant with

[Lldb-commits] [lldb] r313540 - Revert "Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)"

Author: amccarth Date: Mon Sep 18 08:59:44 2017 New Revision: 313540 URL: http://llvm.org/viewvc/llvm-project?rev=313540=rev Log: Revert "Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)" Broke Windows and FreeBSD (at least). This reverts commit

[Lldb-commits] [lldb] r313210 - Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Author: amccarth Date: Wed Sep 13 15:57:11 2017 New Revision: 313210 URL: http://llvm.org/viewvc/llvm-project?rev=313210=rev Log: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump) The main change is to avoid setting the process state as running when

[Lldb-commits] [lldb] r312735 - Fix for bug 34510 - Minidump target does not resolve new symbols correctly

Author: amccarth Date: Thu Sep 7 11:29:48 2017 New Revision: 312735 URL: http://llvm.org/viewvc/llvm-project?rev=312735=rev Log: Fix for bug 34510 - Minidump target does not resolve new symbols correctly Even though the content of the minidump does not change in a debugging session, frames

Re: [Lldb-commits] [lldb] r300610 - Fix Windows bot failure

Actually, Windows does have `struct timespec`. It's defined in `` and ``. https://msdn.microsoft.com/en-us/library/mt633792.aspx I suspect somebody had suppressed it for some reason. On Tue, Apr 18, 2017 at 2:47 PM, Chris Bieneman via lldb-commits < lldb-commits@lists.llvm.org> wrote: >

[Lldb-commits] [lldb] r293336 - NFC: Improve comments in SymbolFilePDB.cpp

Author: amccarth Date: Fri Jan 27 15:42:28 2017 New Revision: 293336 URL: http://llvm.org/viewvc/llvm-project?rev=293336=rev Log: NFC: Improve comments in SymbolFilePDB.cpp Mostly this just fixes bad wrapping caused by the reformat, with tiny changes sprinkled here and there. Modified:

[Lldb-commits] [lldb] r287113 - Remove Windows-specific minidump plugin

Author: amccarth Date: Wed Nov 16 10:04:14 2016 New Revision: 287113 URL: http://llvm.org/viewvc/llvm-project?rev=287113=rev Log: Remove Windows-specific minidump plugin With the cross-platform minidump plugin working, the Windows-specific one is no longer needed. This eliminates the

[Lldb-commits] [PATCH] D26697: Remove Windows-specific minidump plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rL287113: Remove Windows-specific minidump plugin (authored by amccarth). Changed prior to commit: https://reviews.llvm.org/D26697?vs=78065=78194#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D26697: Remove Windows-specific minidump plugin

amccarth created this revision. amccarth added reviewers: labath, zturner. amccarth added a subscriber: lldb-commits. Herald added subscribers: modocache, mgorny. With the cross-platform minidump plugin working, the Windows-specific one is no longer needed. This eliminates the unnecessary code.

[Lldb-commits] [PATCH] D26643: Fix TestMiniDumpNew.py test for Python 2/3 issue

This revision was automatically updated to reflect the committed changes. Closed by commit rL286909: Fix TestMiniDumpNew.py test for Python 2/3 issue (authored by amccarth). Changed prior to commit: https://reviews.llvm.org/D26643?vs=77900=77907#toc Repository: rL LLVM

[Lldb-commits] [lldb] r286909 - Fix TestMiniDumpNew.py test for Python 2/3 issue

Author: amccarth Date: Mon Nov 14 17:53:45 2016 New Revision: 286909 URL: http://llvm.org/viewvc/llvm-project?rev=286909=rev Log: Fix TestMiniDumpNew.py test for Python 2/3 issue On Windows, where we use Python 3 for testing, we have to be more explicit about converting between binary and

[Lldb-commits] [PATCH] D26643: Fix TestMiniDumpNew.py test for Python 2/3 issue

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. On Windows, where we use Python 3 for testing, we have to be more explicit about converting between binary and string representations. I believe this should still work for Python 2,

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Problem was at my end. This patch works fine for me now. I'm planning to do some more minidump work, so I'd be happy to take over with eliminating the old Windows-specific

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

amccarth added a comment. In https://reviews.llvm.org/D26393#589421, @labath wrote: > In https://reviews.llvm.org/D26393#589363, @amccarth wrote: > > > I started testing the new plugin on Windows yesterday, and it doesn't work > > (all the tests fail). I'm planning to debug today, and, once I

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

amccarth added a comment. I started testing the new plugin on Windows yesterday, and it doesn't work (all the tests fail). I'm planning to debug today, and, once I get it working, I'd be happy to switch it over. https://reviews.llvm.org/D26393

[Lldb-commits] [PATCH] D25905: Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin in SystemInitializerFull

amccarth accepted this revision. amccarth added a reviewer: amccarth. amccarth added a comment. This revision is now accepted and ready to land. I like that this keeps the WoW64 detection and support. That's a very Windows-specific thing, and I was concerned that doing generic minidump parsing

[Lldb-commits] [PATCH] D25832: Minidump plugin: Adding x86_32 register context converter

amccarth accepted this revision. amccarth added a reviewer: amccarth. amccarth added inline comments. Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:340 std::map reg_values; + reg_values[lldb_rax_x86_64] = 0x;

[Lldb-commits] [PATCH] D26081: Improve ".." handling in FileSpec normalization

amccarth added inline comments. Comment at: source/Host/common/FileSpec.cpp:550 + (m_filename.GetStringRef() != ".." && m_filename.GetStringRef() != ".")) +return *this; Do we have to worry about an unnecessary single dot in the directory, like

[Lldb-commits] [PATCH] D25247: Make LLDB -Werror clean under clang

amccarth accepted this revision. amccarth added a comment. lgtm > UDPSocket.cpp:106 > +#if defined(_MSC_VER) && defined(UNICODE) > +"getaddrinfo(%s, %s, , ) returned error %i (%S)", > +#else Yuck. Given that this is going to get reduced from UTF-16 to MBCS, it might be cleaner to

[Lldb-commits] [PATCH] D25196: Adding a new Minidump post-mortem debugging plugin

amccarth added a comment. I was hoping that, with your new mini dump parser, you'd be able to eliminate the need for the Windows-specific minidump process plugin. When I wrote the Windows mini dump plugin, I tried to isolate the Windows API-specific bits using the pimpl idiom. Now that you've

[Lldb-commits] [PATCH] D25099: Refactor Args a different way

amccarth added a comment. Just a drive by. > Args.h:449 >//-- >// Classes that inherit from Args can see and modify these >//-- This comment is no longer

[Lldb-commits] [lldb] r282871 - Add namespace qualifiers for UTF functions that just moved.

Author: amccarth Date: Fri Sep 30 11:11:42 2016 New Revision: 282871 URL: http://llvm.org/viewvc/llvm-project?rev=282871=rev Log: Add namespace qualifiers for UTF functions that just moved. Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

amccarth added inline comments. Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:177 @@ +176,3 @@ +#define REG_VAL(x) *(reinterpret_cast(x)) + +TEST_F(MinidumpParserTest, ConvertRegisterContext) { `EXPECT_xxx` will check the condition and report if

Re: [Lldb-commits] [PATCH] D24952: Remove Args::m_argv

amccarth added a subscriber: amccarth. Comment at: include/lldb/Interpreter/Args.h:154 @@ -167,3 +153,3 @@ //-- - const char **GetConstArgumentVector() const; + void GetArgumentVector(std::vector ) const;

Re: [Lldb-commits] [PATCH] D24919: Adding a RegisterContextMinidump_x86_64 converter

amccarth added inline comments. Comment at: source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:1 @@ +1,2 @@ +//===-- Registers_x86_64.cpp *- C++ -*-===// +// Should match file name. Comment

Re: [Lldb-commits] [lldb] r282112 - Fix integer sign warning from r282105

Thanks for fixing it. On Wed, Sep 21, 2016 at 4:20 PM, Ed Maste wrote: > On 21 September 2016 at 21:38, Adrian McCarthy > wrote: > > That fix doesn't look complete: > > Thanks, I've applied your fix in r282119, and sorry for being hasty > with the

Re: [Lldb-commits] [lldb] r282112 - Fix integer sign warning from r282105

That fix doesn't look complete: for (size_t i = 0; i < column - 1 && i < src_line.length(); ++i) `column` is an unsigned integral type, so doing subtraction from it can lead to surprising results. It's probably best to write it as: for (size_t i = 0; i + 1 < column && i <

Re: [Lldb-commits] [PATCH] D24385: MinidumpParsing: pid, modules, exceptions

> Even if it's length prefixed, the logic here basically just consumes the entire buffer, which doesn't seem right Yes, agreed. On Fri, Sep 9, 2016 at 5:45 PM, Zachary Turner wrote: > Even if it's length prefixed, the logic here basically just consumes the > entire buffer,

Re: [Lldb-commits] [PATCH] D24385: MinidumpParsing: pid, modules, exceptions

amccarth added inline comments. Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:21 @@ +20,3 @@ +llvm::StringRef +lldb_private::minidump::consumeString(llvm::ArrayRef ) { + return llvm::StringRef(reinterpret_cast(Buffer.data()), zturner wrote: >

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

amccarth added a comment. LGTM. https://reviews.llvm.org/D23545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

amccarth added a comment. In https://reviews.llvm.org/D23545#519675, @dvlahovski wrote: > In https://reviews.llvm.org/D23545#516808, @amccarth wrote: > > > Are we putting this code in the right place? I wouldn't expect minidump > > parsing to fall under Plugins/Process. > > > > I assume the

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

amccarth added a comment. Are we putting this code in the right place? I wouldn't expect minidump parsing to fall under Plugins/Process. I assume the eventual intent is to turn the Windows-specific code into a user of your new code? I look forward to seeing that happen.

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

I patched it in this morning, but it doesn't compile on Windows. I was able to make it work with a few tweaks at the top of SelectHelper.cpp: // C Includes #include #if defined(_WIN32) #define NOMINMAX #include #else #include #endif The key bits: don't include on Windows and #define

Re: [Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

amccarth accepted this revision. amccarth added a reviewer: amccarth. amccarth added a comment. LGTM. Thanks! Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338 @@ -315,4 +337,3 @@ // truncated. -error.SetErrorString("address is not in a

Re: [Lldb-commits] [PATCH] D22352: Implement GetMemoryRegions() for Windows Minidumps and live processes.

amccarth added a subscriber: amccarth. Comment at: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:338 @@ -315,4 +337,3 @@ // truncated. -error.SetErrorString("address is not in a known range"); return error; } I'm not clear why you

[Lldb-commits] [lldb] r274277 - Fix for Windows builds.

Author: amccarth Date: Thu Jun 30 15:55:50 2016 New Revision: 274277 URL: http://llvm.org/viewvc/llvm-project?rev=274277=rev Log: Fix for Windows builds. Modified: lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp Modified: lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp

Re: [Lldb-commits] [PATCH] D19943: XFail TestEnumTypes.py on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL268574: XFail TestEnumTypes.py on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19943?vs=56216=56222#toc Repository: rL LLVM http://reviews.llvm.org/D19943

[Lldb-commits] [lldb] r268574 - XFail TestEnumTypes.py on Windows

Author: amccarth Date: Wed May 4 18:33:19 2016 New Revision: 268574 URL: http://llvm.org/viewvc/llvm-project?rev=268574=rev Log: XFail TestEnumTypes.py on Windows Differential Revision: http://reviews.llvm.org/D19943 Modified:

Re: [Lldb-commits] [PATCH] D19606: XFail TestLambdas.py on Windows after fixing some of the problems

This revision was automatically updated to reflect the committed changes. Closed by commit rL268573: XFail TestLambdas.py on Windows after fixing some of the problems (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19606?vs=55263=56221#toc Repository: rL LLVM

[Lldb-commits] [lldb] r268573 - XFail TestLambdas.py on Windows after fixing some of the problems

Author: amccarth Date: Wed May 4 18:32:35 2016 New Revision: 268573 URL: http://llvm.org/viewvc/llvm-project?rev=268573=rev Log: XFail TestLambdas.py on Windows after fixing some of the problems 1. Fixed semicolon placement in the lambda in the test itself. 2. Fixed lldbinline tests in general

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

amccarth added a comment. The test expects `expr *f.op` to fail because f is a null pointer, but on Windows it yields `(ops) $2 = 0`. I suspect this is a latent expression evaluation bug exposed by the new test, as it also happens for other types of pointers and not just pointers to enums.

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

amccarth added a subscriber: amccarth. amccarth added a comment. Chaoren: Did this completely fix the test for you? It's still failing for me on Windows, but for a reason not addressed here. Repository: rL LLVM http://reviews.llvm.org/D19751

Re: [Lldb-commits] [PATCH] D19606: XFail TestLambdas.py on Windows after fixing some of the problems

amccarth added a comment. Zach is hoping to enable tests on our Windows build bot this week, so I'd like to land this in the next day or two if possible. If not, I can just xfail this test on Windows and postpone the other fixes until there's more time for a review. Thanks.

Re: [Lldb-commits] [PATCH] D18017: Eliminate the TestStarted-XXX and TestFinished-XXX files from the test traces

amccarth closed this revision. amccarth added a comment. This was submitted last month. r263122 http://reviews.llvm.org/D18017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19626: XFail TestIRInterpreter on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL267800: XFail TestIRInterpreter on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19626?vs=55326=55333#toc Repository: rL LLVM http://reviews.llvm.org/D19626

[Lldb-commits] [lldb] r267800 - XFail TestIRInterpreter on Windows

Author: amccarth Date: Wed Apr 27 16:53:19 2016 New Revision: 267800 URL: http://llvm.org/viewvc/llvm-project?rev=267800=rev Log: XFail TestIRInterpreter on Windows There's an open bug with calling functions in the inferior. And Windows doesn't have the POSIX function getpid(). Differential

[Lldb-commits] [PATCH] D19626: XFail TestIRInterpreter on Windows

amccarth created this revision. amccarth added a reviewer: spyffe. amccarth added a subscriber: lldb-commits. Test relies on a POSIX-only function `getpid()`, so the expression on Windows gets an undefined symbol. If you substitute `_getpid()`, the interpreter complains that it uses an opcode

[Lldb-commits] [PATCH] D19606: XFail TestLambdas.py on Windows after fixing some of the problems

amccarth created this revision. amccarth added a reviewer: spyffe. amccarth added a subscriber: lldb-commits. 1. Fixed semicolon placement in the lambda in the test itself. 2. Fixed lldbinline tests in general so that we don't attempt tests on platforms that don't use the given type of debug

Re: [Lldb-commits] [PATCH] D19548: Fix TestRegisterVariables.py on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL267616: Fix TestRegisterVariables.py on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19548?vs=55050=55112#toc Repository: rL LLVM http://reviews.llvm.org/D19548

[Lldb-commits] [lldb] r267616 - Fix TestRegisterVariables.py on Windows

Author: amccarth Date: Tue Apr 26 17:25:40 2016 New Revision: 267616 URL: http://llvm.org/viewvc/llvm-project?rev=267616=rev Log: Fix TestRegisterVariables.py on Windows Use __attribute__((regparm(x))) to ensure the compiler enregisters at least some arguments when calling functions.

[Lldb-commits] [PATCH] D19548: Fix TestRegisterVariables.py on Windows

amccarth created this revision. amccarth added a reviewer: tfiala. amccarth added a subscriber: lldb-commits. Herald added a subscriber: aemerson. 32-bit Windows calling conventions, by default, don't pass arguments in registers, but this test expects at least one of them to be. By adding

Re: [Lldb-commits] [PATCH] D19510: Fix send and receive of ACK byte in test infrastructure for Python 3.5

This revision was automatically updated to reflect the committed changes. Closed by commit rL267562: Fix send and receive of ACK byte in test infrastructure for Python 3.5 (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D19510?vs=54938=55005#toc Repository: rL LLVM

[Lldb-commits] [lldb] r267562 - Fix send and receive of ACK byte in test infrastructure for Python 3.5

Author: amccarth Date: Tue Apr 26 10:15:29 2016 New Revision: 267562 URL: http://llvm.org/viewvc/llvm-project?rev=267562=rev Log: Fix send and receive of ACK byte in test infrastructure for Python 3.5 Python 3.5 is pickier about the distinction between chars and bytes (and strings and

[Lldb-commits] [PATCH] D19510: Fix send and receive of ACK byte in test infrastructure for Python 3.5

amccarth created this revision. amccarth added a reviewer: tfiala. amccarth added a subscriber: lldb-commits. Python 3.5 is pickier about the distinction between chars and bytes (and strings and bytearrays) than Python 2.7. The call to ack_bytes.append(chr(42)) was causing a type error to be

Re: [Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

amccarth added a comment. We already limit threads on Windows to work around other problems. Technically, we force Windows to always use the multiprocessing-pool instead of the threading-pool, which I think has the effect of limiting the number of threads. I suspect that the first several

[Lldb-commits] [PATCH] D19489: Use llvm_unreachable to quiet a VC++ compiler warning.

amccarth created this revision. amccarth added a reviewer: spyffe. amccarth added a subscriber: lldb-commits. http://reviews.llvm.org/D19489 Files: source/Expression/DiagnosticManager.cpp Index: source/Expression/DiagnosticManager.cpp

Re: [Lldb-commits] [PATCH] D19214: fix a race is the LLDB test suite results collection

amccarth added a subscriber: amccarth. amccarth added a comment. FYI: This patch seems to have broken all LLDB testing on Windows. I'll investigate why. Lots of the socket calls now result in stack traces like this: Traceback (most recent call last): File

  1   2   3   >