[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

This revision was automatically updated to reflect the committed changes. Closed by commit rGebec53e2d7c7: [lldb] Introduce a macro to mark methods as unsupported with no replacement (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D153827: [lldb][NFCI] Remove use of ConstString from ProcessElfCore

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3921b8bff69: [lldb][NFCI] Remove use of ConstString from ProcessElfCore (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153827/new/

[Lldb-commits] [PATCH] D153825: [lldb][NFCI] Change return type of GetProcessPluginName

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b102886c0c3: [lldb][NFCI] Change return type of GetProcessPluginName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153825/new/ htt

[Lldb-commits] [PATCH] D153810: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2ff2921e84a: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

This revision was automatically updated to reflect the committed changes. Closed by commit rG673f91055a41: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

bulbazord added a comment. Making `m_lock_count`'s type into `std::atomic` makes sense to me, but I'm a little confused about why `Process::LoadOperatingSystemPlugin` is guarded by acquiring `m_thread_mutex`. My (admittedly limited) understanding of that is that it's a mutex that the Process ho

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord updated this revision to Diff 535199. bulbazord added a comment. Implement changes after discussing offline with Jonas and Ismail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153928/new/ https://reviews.llvm.org/D153928 Files: lldb/in

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord added inline comments. Comment at: lldb/include/lldb/lldb-defines.h:134-140 +#if defined(__clang__) +#define LLDB_UNSUPPORTED(MSG) \ + __attribute__((deprecated("This method is no longer supported: " MSG, ""))) +#else +

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We already have LLDB_DEPRECATED which is used to mark methods as

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

bulbazord added inline comments. Comment at: lldb/include/lldb/API/SBValue.h:286 + LLDB_DEPRECATED("SBValue::GetOpaqueType() is deprecated. Do not use.", "") void *GetOpaqueType(); mib wrote: > JDevlieghere wrote: > > Similar comment as in D153900: The "Do

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method, as far as I can ascertain, is non-triv

[Lldb-commits] [PATCH] D153917: [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead of pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We always assume that this is valid anyway, might as well take a

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

bulbazord updated this revision to Diff 535084. bulbazord added a comment. Remove unneeded newline from log line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153905/new/ https://reviews.llvm.org/D153905 Files: lldb/source/Plugins/ExpressionPars

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, Michael137, augusto2112, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. 2/3 of the ConstStrings in this class wer

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, teemperor, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For some context, Raphael tried to this befo

[Lldb-commits] [PATCH] D153824: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bd69ae0c5a7: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D153818: [lldb][NFCI] Remove use of ConstString from PluginManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec083107ff2: [lldb][NFCI] Remove use of ConstString from PluginManager (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153818/new/ h

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. LGTM with a few nits. There is one piece of logic that I think does need to be changed before this can go in however. Comment at: lldb/source/Commands/Comman

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153726/new/ https://reviews.llvm.org/D153726 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D153827: [lldb][NFCI] Remove use of ConstString from ProcessElfCore

bulbazord created this revision. bulbazord added reviewers: clayborg, DavidSpickett, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm not convinced that it makes sense for the paths to

[Lldb-commits] [PATCH] D153825: [lldb][NFCI] Change return type of GetProcessPluginName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of just returning a raw `const char *`, I think llvm::Str

[Lldb-commits] [PATCH] D153824: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Now that we have a proper way to deprecate things i

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ed3c2edf017: [lldb] Increase the maximum number of classes we can read from shared cache (authored by bulbazord). Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D153818: [lldb][NFCI] Remove use of ConstString from PluginManager

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The underlying structures no longer use ConstString so we can rem

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord updated this revision to Diff 534757. bulbazord added a comment. Updating number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153817/new/ https://reviews.llvm.org/D153817 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRunti

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord updated this revision to Diff 534753. bulbazord added a comment. Update FIXME with more info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153817/new/ https://reviews.llvm.org/D153817 Files: lldb/source/Plugins/LanguageRuntime/ObjC/Ap

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord added a comment. In D153817#4450534 , @jasonmolenda wrote: > LGTM. You might want to mention why it isn't sustainable -- because we must > allocate memory in the inferior process, and some inferior processes have > quite small memory limits.

[Lldb-commits] [PATCH] D153817: [lldb] Increase the maximum number of classes we can read from shared cache

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jasonmolenda, jingham, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The shared cache has grown past the previou

[Lldb-commits] [PATCH] D153810: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, Michael137, augusto2112, kastiglione, fdeazeve. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commi

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

bulbazord added inline comments. Comment at: lldb/source/Host/common/FileSystem.cpp:230 SmallString<128> resolved(path.begin(), path.end()); StandardTildeExpressionResolver Resolver; + m_tilde_resolver->ResolveFullPath(llvm::StringRef(path.begin(), path.size()), --

[Lldb-commits] [PATCH] D153675: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rG9442e81f02a7: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

bulbazord added a comment. In D153657#4449608 , @jingham wrote: > In D153657#4445292 , @bulbazord > wrote: > >> I think this patch is probably okay to do, but it does break a supported use >> case that I'm aware

[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

This revision was automatically updated to reflect the committed changes. Closed by commit rG2014572d9a68: [lldb][NFCI] Remove unneeded ConstString constructions for… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153673/new/

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f69e6682bf0: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D153710: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG718e0cd6e724: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We are assuming that the pointer is always valid, might as well

[Lldb-commits] [PATCH] D153710: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We always assume the Stream pointer is valid, might as well be t

[Lldb-commits] [PATCH] D153675: [lldb][NFCI] Remove ConstString from Process::ConfigureStructuredData

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a follow-up to b4827a3c0a7ef121ca376713e115b04e

[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I removed ConstString from OptionValueProperties in 643ba926c1f6

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

bulbazord added a comment. I think this patch is probably okay to do, but it does break a supported use case that I'm aware of: One way you can do "object oriented programming" in C is to do exactly what you're trying to prevent. Using the test, you could say that "MyStruct" is the base class a

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a397ecffdea: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153482/

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me. Does it make sense to add a test case where we mix "printable" characters with "non-printable" ones? I see you have a `\f` at the end there, but that's a special escap

[Lldb-commits] [PATCH] D153597: [lldb] Adjust for changes in objc runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG28fb39f16af1: [lldb] Adjust for changes in objc runtime (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153597/new/ https://reviews.l

[Lldb-commits] [PATCH] D153597: [lldb] Adjust for changes in objc runtime

bulbazord created this revision. bulbazord added a reviewer: JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The Objective-C runtime and the shared cache has changed slightly. Given a cla

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The use of ConstString in StructuredDataPlugin is unnec

[Lldb-commits] [PATCH] D153177: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient::ConfigureRemoteStructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4827a3c0a7e: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15317

[Lldb-commits] [PATCH] D153177: [lldb][NFCI] Remove ConstString from GDBRemoteCommunicationClient::ConfigureRemoteStructuredData

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstString's benefits are not being utilized here, StringRef is

[Lldb-commits] [PATCH] D152968: [lldb][NFCI] Remove use of ConstString in ProcessStructReader

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b90d09898ca: [lldb][NFCI] Remove use of ConstString in ProcessStructReader (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152968/new

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG193c7d10cb30: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c8b6fae4437: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D153088: [lldb] De-virtualize applicable functions in ValueObject (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Big fan of this kind of cleanup. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153088/new/

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rGe29cc5216a86: [lldb][NFCI] Remove use of ConstString from IOHandler (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https

[Lldb-commits] [PATCH] D152579: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map instead of name map

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fb919a1154a: [lldb] Symtab::SectionFileAddressesChanged should clear the file address map… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord added a comment. If nobody else has any comments, I plan on landing this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152569/new/ https://reviews.llvm.org/D152569 ___ lldb-commits ma

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.run-as

bulbazord added a comment. What happens if you do `run-as` with an empty package name? I'm also not tied to the name `"platform.plugin.remote-android.run-as"` if others don't like it. `platform.plugin.remote-android.package-name` is fine too. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

bulbazord added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:209 - return adb.ShellToFile(cmd, minutes(1), destination); + return adb->ShellToFile(cmd, minutes(1), destination); } `GetAdbClient()` calls `make_unique`

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for reworking it! You may want to wait a little bit before landing so others have some time to look over it, but I don't see anything that should prevent this from going in. Rep

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

bulbazord added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:592 if (data_sp->GetByteSize() < length) -data_sp = MapFileData(file, -1, file_offset); +data_sp = MapFileData(file, length, file_offset);

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp:76 + + compiler_type = scratch_ts_sp->GetTypeForIdentifier(g_lldb_autogen_nspair); + aprantl wrote: > why not directly pass in `"__lldb_autogen_nspair"` here? It's u

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

This revision was automatically updated to reflect the committed changes. Closed by commit rG35b0b244401a: [lldb] Introduce DynamicRegisterInfo::CreateFromDict (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/ https:

[Lldb-commits] [PATCH] D153054: [lldb][NFCI] TypeSystemClang::GetTypeForIdentifier should take a StringRef

bulbazord created this revision. bulbazord added reviewers: aprantl, Michael137, augusto2112, JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This method just takes its ConstString parame

[Lldb-commits] [PATCH] D152962: [lldb] Fix SBPlatform after f4be9ff6458f

This revision was automatically updated to reflect the committed changes. Closed by commit rG623ad8a8ddc9: [lldb] Fix SBPlatform after f4be9ff6458f (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152962/new/ https://reviews.ll

[Lldb-commits] [PATCH] D152968: [lldb][NFCI] Remove use of ConstString in ProcessStructReader

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. std::map is naturally replaced with `llvm::StringMap` here. Rep

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord added a comment. Looks like this actually causes TestDebuggerAPI.py to segfault because SBPlatform::SetSDKRoot can take `nullptr` for its argument, and the conversion from `nullptr -> std::string` blows up. I'm fixing that in https://reviews.llvm.org/D152962. Repository: rG LLVM G

[Lldb-commits] [PATCH] D152962: [lldb] Fix SBPlatform after f4be9ff6458f

bulbazord created this revision. bulbazord added a reviewer: jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If you pass `nullptr` (or `None` from python) to SBPlatform::SetSDKRoot, LLDB crash

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

bulbazord updated this revision to Diff 531407. bulbazord added a comment. Use STLExtras where appropriate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152846/new/ https://reviews.llvm.org/D152846 Files: lldb/source/Utility/Listener.cpp Index:

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4be9ff6458f: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D152870: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a subscriber: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the next step in rem

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord added inline comments. Comment at: lldb/source/Host/CMakeLists.txt:109-121 + +set(ANDROID_SOURCES + android/ZipFile.cpp + android/HostInfoAndroid.cpp + ) if (CMAKE_SYSTEM_NAME MATCHES "Android") + list(APPEND ANDROID_SOURCES

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. In D152866#4419413 , @JDevlieghere wrote: > In D152866#4419406 , @bulbazord > wrote: > >> I like this

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

bulbazord added a comment. I like this idea quite a bit! I assume that when somebody hits a bug, they can give us their diagnostics file and we will hopefully see the assertion somewhere (if there was one)? Comment at: lldb/source/Target/Target.cpp:115 + lldbassert(false &

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531104. bulbazord added a comment. Avoid construction of temporary std::string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files: lldb/include/lldb/Interprete

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531103. bulbazord added a comment. Update other 2 functions (and one callsite) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files: lldb/include/lldb/Interprete

[Lldb-commits] [PATCH] D152597: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString overloads involving ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rGe669011c3cca: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

bulbazord added a comment. Herald added a subscriber: JDevlieghere. This is definitely useful to support, I had a few comments mostly about matching lldb's coding style. Also, are you running clang-format on your patches? There are a few places where I'm not sure if the formatting is right.

[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

bulbazord added a comment. An environment variable isn't the worst thing in the world, but what would be better is an lldb setting so we can change it at runtime instead of needing to restart the debugging session. That may happen if you make a typo or make a mistake. Something like `plugin.pla

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I don't really work on android-related code anymore but this change seems alright to me. There's prior art in LLVM which makes it a lot easier to accept. It's unfortunate that we need th

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord updated this revision to Diff 531084. bulbazord added a comment. Implement Jonas's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152331/new/ https://reviews.llvm.org/D152331 Files: lldb/include/lldb/Interpreter/OptionGroupPl

[Lldb-commits] [PATCH] D152861: Clear non-addressable bits from fp/sp/lr/pc values in RegisterContextUnwind

bulbazord added a comment. I noticed you're pulling a lot of raw pointers out of shared pointers. Is there a particular reason you're doing that? `operator bool` on `std::shared_ptr` returns true if the held pointer is non-null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151951: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cff6ca81335: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D152842: [lldb] Improve corefile saving ergonomics

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM, what do you think @jasonmolenda ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152842/new/ https://reviews.llvm.org/D152842 __

[Lldb-commits] [PATCH] D152848: [lldb] Fix failure in TestStackCoreScriptedProcess on x86_64

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:253 case lldb::eStopReasonSignal: { -int signal; +unsigned int signal;

[Lldb-commits] [PATCH] D152846: [lldb][NFCI] Remove custom matcher classes in Listener in favor of lambdas

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of writing boilerplate classes to serve as matc

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

bulbazord accepted this revision. bulbazord added a comment. I'm alright with this if Jim is. I think we should remove this parameter since it's never set to anything other than `true` from what I understand, but that can be done in a follow-up. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D152837: [lldb] Identify Swift-implemented ObjC classes

bulbazord added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Core/ValueObjectDynamicValue.cpp:10 #include "lldb/Core/ValueObjectDynamicValue.h" +#include "Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h" #include "lldb/Core/Value.h" -

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

bulbazord added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:52 - void SetSDKRootDirectory(ConstString sdk_root_directory) { -m_sdk_sysroot = sdk_root_directory; + void SetSDKRootDirectory(llvm::StringRef sdk_root_directory) { +m_sd

[Lldb-commits] [PATCH] D152573: [lldb][NFCI] Remove use of ConstString from Listener

This revision was automatically updated to reflect the committed changes. Closed by commit rG35419651c53c: [lldb][NFCI] Remove use of ConstString from Listener (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152573/new/ https:

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

bulbazord updated this revision to Diff 530720. bulbazord added a comment. Renamed from `CreateFromDict` to `Create` to be more consistent with the rest of LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord updated this revision to Diff 530712. bulbazord marked an inline comment as done. bulbazord added a comment. Address the other suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https://reviews.llvm.org/D151597 Files:

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

This revision was automatically updated to reflect the committed changes. Closed by commit rGf687850de877: [lldb] Change return type of UnixSignals::GetShortName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152582/new/ http

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

bulbazord added a comment. In D152324#4415324 , @jingham wrote: > I wonder about this one. In every instance where the API is used, its result > is turned into a ConstString first. That's because this variable name lives > in the same slot as normal v

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord updated this revision to Diff 530694. bulbazord added a comment. Address Jonas's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151597/new/ https://reviews.llvm.org/D151597 Files: lldb/include/lldb/Core/Debugger.h lldb/includ

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord updated this revision to Diff 530692. bulbazord added a comment. Remove temp variables More multiline string literals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152569/new/ https://reviews.llvm.org/D152569 Files: lldb/scripts/genera

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

This revision was automatically updated to reflect the committed changes. Closed by commit rGf09cca4c6f67: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

bulbazord added a comment. In D152594#4410620 , @mib wrote: > Are we replacing all the constructors that can fail by static methods ? > Wouldn't it be easier to pass an `Status&` as an extra parameter ? It would probably be easier to do, but I don't thi

[Lldb-commits] [PATCH] D152597: [lldb][NFCI] Remove StructuredData::Dictionary::GetValueForKeyAsString overloads involving ConstString

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In an effort to keep the ConstString StringPool small,

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, mgorny. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I want to add some error handling to Dynami

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord marked 3 inline comments as done. bulbazord added inline comments. Comment at: lldb/scripts/generate-project.py:175 +# Building Objects and their respective swiftmodule +f.write(f"$(OBJDIR)/%.o: %.swift objdir\n") +f.write("\t$(SWIFT_FE) -c -prim

[Lldb-commits] [PATCH] D152569: [lldb] Introduce a tool to quickly generate projects with an arbitrary number of sources

bulbazord updated this revision to Diff 530084. bulbazord added a comment. - Converted some things to use multiline string literals - Converted some f-strings into string literals when they didn't need interpolation - Applied black formatting Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

bulbazord added a comment. In D152582#4410002 , @mib wrote: > Don't you need to update the callers as well ? Otherwise LGTM. ConstString can be implicitly converted to StringRef which is what's happening here. There are only 2 call sites, both pass in a

<    1   2   3   4   5   6   7   8   9   10   >