[Lldb-commits] [lldb] [lldb] Adds additional fields to ProcessInfo (PR #91544)

@@ -12,6 +12,9 @@ #include "lldb/Utility/ProcessInfo.h" #include "gtest/gtest.h" +#include +#include emaste wrote: Much of this file would work just fine on FreeBSD as well so that might make sense, although I'm not sure what the best structure would be

[Lldb-commits] [lldb] [lldb] Adds additional fields to ProcessInfo (PR #91544)

@@ -237,6 +250,16 @@ class ProcessInstanceInfo : public ProcessInfo { m_cumulative_system_time.tv_usec > 0; } + int8_t GetNiceValue() const { return m_nice_value; } emaste wrote: nice and priority are not synonymous though, nice is one input

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Remove xfails from TestGDBRemoteLoad (PR #84026)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/84026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Account for spsr being 8 bytes in newer versions (PR #84032)

@@ -362,7 +363,15 @@ TEST(RegisterContextFreeBSDTest, arm64) { EXPECT_GPR_ARM64(lr, lr); EXPECT_GPR_ARM64(sp, sp); EXPECT_GPR_ARM64(pc, elr); +#if __FreeBSD_version >= 1400084 emaste wrote: This will be correct when the host running the debugger is the

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Account for spsr being 8 bytes in newer versions (PR #84032)

emaste wrote: CC @zxombie https://github.com/llvm/llvm-project/pull/84032 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Narrow vectorcall xfail to x86 platforms (PR #84024)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/84024 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Remove corefile test xfails (PR #84022)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/84022 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add FreeBSD kernel coredump matching check. (PR #80785)

emaste wrote: > However, for minimal dump, the build-id section won't loaded because minimal > dump only dump the used memory by kernel. If we fall back to no-UUID-found in that case and don't require that it matches this is still an improvement, yeah?

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Fix some concurrent event tests (PR #84155)

emaste wrote: Yes I think it's likely fixed. I'll give it a try on my FreeBSD laptop shortly. https://github.com/llvm/llvm-project/pull/84155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][test][FreeBSD] Fix some concurrent event tests (PR #84155)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/84155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

emaste wrote: @zxombie fyi https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/81355 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Teach LocateExecutableSymbolFile to look into LOCALBASE on FreeBSD (PR #81355)

https://github.com/emaste approved this pull request. This is reasonable and in line with the existing special case for NetBSD, but it seems like this logic shouldn't really be here but in a target-specific file. When (live or corefile) cross-debugging a FreeBSD target we should look in

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies. // // Response is F, followed by the number of bytes written (base 16) +//-- +// vFile:MD5: +// +// BRIEF +// Generate an MD5 hash of the

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

emaste wrote: Ok, submitted https://github.com/llvm/llvm-project/issues/89271 for the MD5 migration. I agree that issue does not block this change. https://github.com/llvm/llvm-project/pull/88812 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Skip remote PutFile when MD5 hashes equal (PR #88812)

emaste wrote: MD5 is insufficient for claiming that files are identical; how do we migrate this to a secure hash? https://github.com/llvm/llvm-project/pull/88812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] adds additional information to the ProcessInfo object for elf processes (PR #88995)

emaste wrote: > is there not a Posix way to get these Not really. On FreeBSD these generally come from sysctl(s). Of the ones added in this pull request SetParentProcessID is already handled on FreeBSD, while SetProcessGroupID, SetProcessSessionID, SetUserTime, SetSystemTime,

[Lldb-commits] [lldb] [lldb] clang-format AuxVector.h (PR #85057)

https://github.com/emaste commented: It looks like the commit messages and content are mismatched - the commit message references AT_HWCAP2 but it doesn't look like that's included here? https://github.com/llvm/llvm-project/pull/85057 ___

[Lldb-commits] [lldb] [lldb][FreeBSD] Add FreeBSD specific AT_HWCAP value (PR #84147)

https://github.com/emaste approved this pull request. (Assuming the comment removal gets squashed into one commit) https://github.com/llvm/llvm-project/pull/84147 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

emaste wrote: commit message probably needs updating for the logic change (no longer beforehand) Another reason to defer the check until failure occurs - if the user happens to be running lldb as root ptrace will be able to attach independent of the state of that sysctl

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/79662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

emaste wrote: Thanks for picking this up -- I was starting to take a look but was sidetracked with a lot of yak shaving. https://github.com/llvm/llvm-project/pull/79662 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

@@ -48,14 +48,36 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + int proc_debug, ret; + size_t len = sizeof(proc_debug); + ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", _debug, + ,

[Lldb-commits] [lldb] [lldb] checks beforehand if lldb can trace/attach a process on FreeBSD. (PR #79662)

@@ -48,14 +48,37 @@ static Status EnsureFDFlags(int fd, int flags) { return error; } +static Status CanTrace() { + Status status; + int proc_debug, ret; + size_t len = sizeof(proc_debug); + ret = ::sysctlbyname("security.bsd.unprivileged_proc_debug", _debug, +

[Lldb-commits] [lldb] [lldb] Additional pieces towards OpenBSD support (PR #74198)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/74198 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Additional pieces towards OpenBSD support (PR #74198)

@@ -1245,9 +1245,10 @@ bool FormatEntity::Format(const Entry , Stream , llvm::Triple::OSType ostype = arch.IsValid() ? arch.GetTriple().getOS() : llvm::Triple::UnknownOS; -

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup (PR #69422)

emaste wrote: commit message has typo `coreected` https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] fix i386 size_t error when using LLDB_LOGF (PR #68210)

https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/68210 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

emaste wrote: I'm not sure why @aokblast's reply didn't appear here, but indeed `%zu` is the right format specifier. https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

https://github.com/emaste closed https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

emaste wrote: Hmm, when I attempt to close it via the GitHub UI I get:  I think I can just fetch the commit locally and then push it to the tree https://github.com/llvm/llvm-project/pull/67106

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

emaste wrote: Oh, I think we should also mention GSoC in the commit message. Something like `This project was part of FreeBSD's participation in Google Summer of Code 2023.` or so. https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

emaste wrote: https://llvm.org/docs/GitHub.html#landing-your-change > There are two different ways to do this: > > - [Interactive rebase](https://git-scm.com/docs/git-rebase#_interactive_mode) > with fixup’s. This is the recommended method since you can control the final > commit message and

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

https://github.com/emaste approved this pull request. https://github.com/llvm/llvm-project/pull/67106 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

emaste wrote: > I will let other FreeBSD folks do the final approval since I don't work on > FreeBSD. @clayborg this change LGTM for FreeBSD. I'm still not fully sorted on the approach for landing the commits post transition to GitHub. Also see the comment about author name above.

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

emaste wrote: > Excuse me. If the code works well now, I want to ask if I need to modify the > commit message by myself so the message looks tidy, or let somebody landing > this pull request modify the message? This will be the first substantial change I'd land after LLVM moved to use pull

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

emaste wrote: Needs to be adapted for f2d32ddcec82c20582c6aa32558b82ca7c3d3c50, `lldb/source/{Core => Host/common}/StreamFile.cpp` (I've applied the change locally for testing, and will just fold it into the patch series if otherwise ready to go.)

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

@@ -0,0 +1,770 @@ +#include "lldb/Breakpoint/StoppointCallbackContext.h" +#include "lldb/Core/Debugger.h" +#include "lldb/Core/Module.h" +#include "lldb/Core/ModuleSpec.h" +#include "lldb/Core/PluginManager.h" +#include "lldb/Core/Section.h" +#include "lldb/Core/StreamFile.h"

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

@@ -0,0 +1,165 @@ +#ifndef LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H +#define LLDB_SOURCE_PLUGINS_DYNAMICLOADER_FREEBSD_KERNEL_DYNAMICLOADERFREEBSDKERNEL_H + +#include +#include +#include + +#include "lldb/Target/DynamicLoader.h" +#include

[Lldb-commits] [lldb] 993ada0 - [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

Author: Andrew Turner Date: 2021-09-28T10:51:06-04:00 New Revision: 993ada05f5a05615ec16da4a69bd368529a7e5d1 URL: https://github.com/llvm/llvm-project/commit/993ada05f5a05615ec16da4a69bd368529a7e5d1 DIFF: https://github.com/llvm/llvm-project/commit/993ada05f5a05615ec16da4a69bd368529a7e5d1.diff

Re: [Lldb-commits] [lldb] 875be9f - [lldb] Mark command-process-connect as unsupported on Windows

On Fri, 13 Nov 2020 at 23:02, Jonas Devlieghere via lldb-commits wrote: > > > Author: Jonas Devlieghere > Date: 2020-11-13T20:02:05-08:00 > New Revision: 875be9f454c31c94701bdf4e28f8bea07a8c9c79 > > URL: > https://github.com/llvm/llvm-project/commit/875be9f454c31c94701bdf4e28f8bea07a8c9c79 >

[Lldb-commits] [lldb] f794160 - [lldb] Fix FreeBSD Arm Process Plugin build

Author: Ed Maste Date: 2020-09-30T09:25:27-04:00 New Revision: f794160c6cb7da4b5ef354a91fe498341f651d36 URL: https://github.com/llvm/llvm-project/commit/f794160c6cb7da4b5ef354a91fe498341f651d36 DIFF: https://github.com/llvm/llvm-project/commit/f794160c6cb7da4b5ef354a91fe498341f651d36.diff

[Lldb-commits] [lldb] 55e32e9 - [lldb] update eArgTypeScriptLang description to mention lua

Author: Ed Maste Date: 2020-04-02T09:43:01-04:00 New Revision: 55e32e92cda79a9eb4487ea8e4ec1b968fac5145 URL: https://github.com/llvm/llvm-project/commit/55e32e92cda79a9eb4487ea8e4ec1b968fac5145 DIFF: https://github.com/llvm/llvm-project/commit/55e32e92cda79a9eb4487ea8e4ec1b968fac5145.diff

[Lldb-commits] [lldb] af1b7d0 - Correct copy-pasteo in lua script language description

Author: Ed Maste Date: 2020-04-02T00:12:24-04:00 New Revision: af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f URL: https://github.com/llvm/llvm-project/commit/af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f DIFF: https://github.com/llvm/llvm-project/commit/af1b7d06d9e45c7e20540aa3bf81f1be5befaa0f.diff

Re: [Lldb-commits] [lldb] r364669 - [GDBRemote] Remove code that flushes GDB remote packets

On Fri, 28 Jun 2019 at 14:14, Jonas Devlieghere via lldb-commits wrote: > > Author: jdevlieghere > Date: Fri Jun 28 11:14:27 2019 > New Revision: 364669 > > URL: http://llvm.org/viewvc/llvm-project?rev=364669=rev > Log: > [GDBRemote] Remove code that flushes GDB remote packets > > The arbitrary

[Lldb-commits] [lldb] r330504 - Temporarily skip Go TestExpressions on FreeBSD as it hangs

Author: emaste Date: Sat Apr 21 06:59:07 2018 New Revision: 330504 URL: http://llvm.org/viewvc/llvm-project?rev=330504=rev Log: Temporarily skip Go TestExpressions on FreeBSD as it hangs llvm.org/pr37194 Modified:

[Lldb-commits] [lldb] r330500 - FreeBSD: propagate error to user if memory access fails

Author: emaste Date: Sat Apr 21 04:23:56 2018 New Revision: 330500 URL: http://llvm.org/viewvc/llvm-project?rev=330500=rev Log: FreeBSD: propagate error to user if memory access fails Previously, an attempt to read an unreadable address reported zeros. Now, if DoReadMemory or DoWriteMemory

[Lldb-commits] [lldb] r326166 - Mark test_*int*_t_dwarf as failing on FreeBSD

Author: emaste Date: Mon Feb 26 18:54:17 2018 New Revision: 326166 URL: http://llvm.org/viewvc/llvm-project?rev=326166=rev Log: Mark test_*int*_t_dwarf as failing on FreeBSD Further investigation required; tests will be enabled on the buildbot worker soon. Marking failing tests for now in order

[Lldb-commits] [lldb] r326139 - Revert r326134 due to broken buildbot

Author: emaste Date: Mon Feb 26 14:36:41 2018 New Revision: 326139 URL: http://llvm.org/viewvc/llvm-project?rev=326139=rev Log: Revert r326134 due to broken buildbot Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/enum_types/TestCPP11EnumTypes.py Modified:

[Lldb-commits] [lldb] r326134 - Mark test_*int*_t_dwarf as failing on FreeBSD

Author: emaste Date: Mon Feb 26 14:12:24 2018 New Revision: 326134 URL: http://llvm.org/viewvc/llvm-project?rev=326134=rev Log: Mark test_*int*_t_dwarf as failing on FreeBSD Further investigation required; tests will be enabled on the buildbot worker soon. Marking failing tests for now in order

[Lldb-commits] [lldb] r325856 - remove FreeBSD xfail from lit TestCallStdStringFunction

Author: emaste Date: Thu Feb 22 18:50:07 2018 New Revision: 325856 URL: http://llvm.org/viewvc/llvm-project?rev=325856=rev Log: remove FreeBSD xfail from lit TestCallStdStringFunction This test is consistently reporting unexpected pass for me, and the expectedFailure decorator was removed from

Re: [Lldb-commits] [lldb] r316728 - Default to using in-tree clang for building test executables

On 26 October 2017 at 22:24, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Thu Oct 26 19:24:04 2017 > New Revision: 316728 > > URL: http://llvm.org/viewvc/llvm-project?rev=316728=rev > Log: > Default to using in-tree clang for building test executables

Re: [Lldb-commits] [lldb] r314458 - [Expression parser] Setting to enable use of ExternalASTMerger

On 28 September 2017 at 22:20, Sean Callanan via lldb-commits wrote: > Author: spyffe > Date: Thu Sep 28 13:20:25 2017 > New Revision: 314458 > > URL: http://llvm.org/viewvc/llvm-project?rev=314458=rev > Log: > [Expression parser] Setting to enable use of

Re: [Lldb-commits] [lldb] r313655 - Re-land r313210 - Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

On 19 September 2017 at 14:07, Adrian McCarthy via lldb-commits wrote: > Author: amccarth > Date: Tue Sep 19 11:07:33 2017 > New Revision: 313655 > > URL: http://llvm.org/viewvc/llvm-project?rev=313655=rev > Log: > Re-land r313210 - Fix for bug 34532 - A few rough

Re: [Lldb-commits] [lldb] r313210 - Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

On 13 September 2017 at 18:57, Adrian McCarthy via lldb-commits wrote: > Author: amccarth > Date: Wed Sep 13 15:57:11 2017 > New Revision: 313210 > > URL: http://llvm.org/viewvc/llvm-project?rev=313210=rev > Log: > Fix for bug 34532 - A few rough corners related to

[Lldb-commits] [lldb] r312431 - Add test case for attach-by-pid from different cwd

Author: emaste Date: Sat Sep 2 18:44:35 2017 New Revision: 312431 URL: http://llvm.org/viewvc/llvm-project?rev=312431=rev Log: Add test case for attach-by-pid from different cwd This was failing on FreeBSD prior to r312430. Patch by Vignesh Balu. Differential Revision:

[Lldb-commits] [lldb] r312430 - FreeBSD: attach to pid from different cwd

Author: emaste Date: Sat Sep 2 18:41:31 2017 New Revision: 312430 URL: http://llvm.org/viewvc/llvm-project?rev=312430=rev Log: FreeBSD: attach to pid from different cwd attach by pid worked when running from the directory from which the target was launched, but failed from a different

[Lldb-commits] [lldb] r311003 - convert hard tabs to spaces in PlatformOpenBSD.cpp

Author: emaste Date: Wed Aug 16 06:10:07 2017 New Revision: 311003 URL: http://llvm.org/viewvc/llvm-project?rev=311003=rev Log: convert hard tabs to spaces in PlatformOpenBSD.cpp Another case of this was responsible for the whitespace conflict in D34776. Modified:

[Lldb-commits] [lldb] r311002 - Make i386-*-freebsd expression work on JIT path

Author: emaste Date: Wed Aug 16 05:55:02 2017 New Revision: 311002 URL: http://llvm.org/viewvc/llvm-project?rev=311002=rev Log: Make i386-*-freebsd expression work on JIT path * Enable i386 ABI creation for freebsd * Added an extra argument in ABISysV_i386::PrepareTrivialCall for mmap syscall

[Lldb-commits] [lldb] r310644 - remove FreeBSD xfail decorator from TestCppNsImport

Author: emaste Date: Thu Aug 10 11:26:52 2017 New Revision: 310644 URL: http://llvm.org/viewvc/llvm-project?rev=310644=rev Log: remove FreeBSD xfail decorator from TestCppNsImport The Linux xfail decorator was removed in r272326 with the claim that the test "runs reliably on the linux x86

[Lldb-commits] [lldb] r310626 - remove FreeBSD xfail decorator from TestCallStdStringFunction

Author: emaste Date: Thu Aug 10 10:01:51 2017 New Revision: 310626 URL: http://llvm.org/viewvc/llvm-project?rev=310626=rev Log: remove FreeBSD xfail decorator from TestCallStdStringFunction This test is consistently reporting unexpected pass for me on FreeBSD 10 and 12. It was failing on the old

[Lldb-commits] Details of radar rdar://problem/24599697

On 20 June 2016 at 19:01, Sean Callanan via lldb-commits wrote: > Author: spyffe > Date: Mon Jun 20 18:01:11 2016 > New Revision: 273211 > > URL: http://llvm.org/viewvc/llvm-project?rev=273211=rev > Log: > Test that lldb calls the right 'printf' even when a 'printf'

[Lldb-commits] [lldb] r310624 - remove FreeBSD xfail decorator from TestExitDuringBreak

Author: emaste Date: Thu Aug 10 09:48:36 2017 New Revision: 310624 URL: http://llvm.org/viewvc/llvm-project?rev=310624=rev Log: remove FreeBSD xfail decorator from TestExitDuringBreak This test passes for me on FreeBSD 10 and 12(-CURRENT). llvm.org/pr18190 Modified:

[Lldb-commits] [lldb] r310591 - Report inferior signals as signals, not exceptions, on FreeBSD

Author: emaste Date: Thu Aug 10 06:47:17 2017 New Revision: 310591 URL: http://llvm.org/viewvc/llvm-project?rev=310591=rev Log: Report inferior signals as signals, not exceptions, on FreeBSD This is the FreeBSD equivalent of r238549. This serves 2 purposes: * LLDB should handle inferior

[Lldb-commits] [lldb] r303965 - FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap

Author: emaste Date: Thu May 25 22:15:46 2017 New Revision: 303965 URL: http://llvm.org/viewvc/llvm-project?rev=303965=rev Log: FreeBSD ProcessMonitor: map TRAP_CAP to a trace trap In the absense of a more specific handler for TRAP_CAP (generated by ENOTCAPABLE or ECAPMODE while in capability

[Lldb-commits] [lldb] r301067 - ThreadSanitizer plugin: match for loop variable with expected type

Author: emaste Date: Fri Apr 21 20:38:54 2017 New Revision: 301067 URL: http://llvm.org/viewvc/llvm-project?rev=301067=rev Log: ThreadSanitizer plugin: match for loop variable with expected type Removes Clang warning ThreadSanitizerRuntime.cpp:591:21: warning: comparison of integers of different

[Lldb-commits] [lldb] r299781 - Correct environ parsing on FreeBSD

Author: emaste Date: Fri Apr 7 11:40:25 2017 New Revision: 299781 URL: http://llvm.org/viewvc/llvm-project?rev=299781=rev Log: Correct environ parsing on FreeBSD Sync Host:GetEnvironment with Linux and Kamil Rytarowski's forthcoming NetBSD change in review D31784. Modified:

[Lldb-commits] [lldb] r294340 - Synchronize PlatformFreeBSD with Linux

Author: emaste Date: Tue Feb 7 13:29:10 2017 New Revision: 294340 URL: http://llvm.org/viewvc/llvm-project?rev=294340=rev Log: Synchronize PlatformFreeBSD with Linux Inspired by r294145 for NetBSD, this reduces diffs between the FreeBSD and Linux/NetBSD Platform implementations. Further diff

[Lldb-commits] [lldb] r292937 - FreeBSD ARM support for software single step

Author: emaste Date: Tue Jan 24 08:34:49 2017 New Revision: 292937 URL: http://llvm.org/viewvc/llvm-project?rev=292937=rev Log: FreeBSD ARM support for software single step Implementation of software single step for FreeBSD on ARM. The code is largely based on the Linux implementation of the

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

emaste added a comment. The tests are not in great shape on FreeBSD/arm64 today, but look roughly equivalent with and without this patch. At https://reviews.llvm.org/rL287887: === Test Result Summary === Test Methods: 1148 Reruns:

[Lldb-commits] [lldb] r287609 - Turn on LLDB_EDITLINE_USE_WCHAR on FreeBSD

Author: emaste Date: Mon Nov 21 20:25:41 2016 New Revision: 287609 URL: http://llvm.org/viewvc/llvm-project?rev=287609=rev Log: Turn on LLDB_EDITLINE_USE_WCHAR on FreeBSD Modified: lldb/trunk/include/lldb/Host/Editline.h Modified: lldb/trunk/include/lldb/Host/Editline.h URL:

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

emaste added a comment. > Ed, what do you think about this one? Is there anyone with a FreeBSD arm64 > setup that could verify this? We have an arm64 reference machine in the FreeBSD cluster and I will test after I return from travel later this week, although perhaps @andrew can try it before

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

emaste added a comment. I applied this change on top of my WIP https://reviews.llvm.org/D26617 (which adds a FreeBSD core test). LLDB builds and my new test passes, so no objections from me. Once it's in I'll see about porting the new SSE test to FreeBSD too. https://reviews.llvm.org/D26300

[Lldb-commits] [lldb] r286035 - make-core.sh: add FreeBSD support

Author: emaste Date: Sat Nov 5 09:45:13 2016 New Revision: 286035 URL: http://llvm.org/viewvc/llvm-project?rev=286035=rev Log: make-core.sh: add FreeBSD support Differential Revision: https://reviews.llvm.org/D26315 Modified:

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

This revision was automatically updated to reflect the committed changes. Closed by commit rL286035: make-core.sh: add FreeBSD support (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D26315?vs=76951=76968#toc Repository: rL LLVM https://reviews.llvm.org/D26315

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

emaste added a comment. Good point. https://reviews.llvm.org/D26315 has the change to add FreeBSD support to make-core.sh -- just avoiding /bin/bash, and the core file handler check. I think we should be able to rename this directory to elf-core, and rename the individual cores to e.g.

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

emaste added a comment. Output on FreeBSD, with the patch: % sh make-core.sh main.c + file=main.c + [ -z main.c ] + [ FreeBSD '=' Linux ] + ulimit -c 1000 + ulimit -c + real_limit=1000 + [ 1000 -lt 100 ] + cc -nostdlib -static -g main.c -o a.out + cat Executable file is in

[Lldb-commits] [PATCH] D26315: make-core.sh: add FreeBSD support

emaste created this revision. emaste added a reviewer: labath. emaste added a subscriber: lldb-commits. https://reviews.llvm.org/D26315 Files: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/make-core.sh Index:

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

emaste added a comment. We need to make sure this does not regress FreeBSD core handling -- I will test as soon as I can, and add FXSAVE parsing for FreeBSD. I'll use fpr_sse.cpp to generate FreeBSD core files as well (although note that we get ~2.5MB cores with default configuration, so

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

emaste added a subscriber: krytarowski. emaste added a comment. On a quick look this seems OK. I'll try to test/review in detail. In https://reviews.llvm.org/D25756#576642, @dmikulin wrote: > Thanks Pavel! I'll start working on it. Do you know when lldb-server Linux > changes were committed? I

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

emaste added a comment. On a quick look this seems OK. I'll try to test/review in detail. Comment at: source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp:925 + + // eRegisterKindDWARF -> RegsiterValue + std::unordered_map m_register_values;

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

emaste added a comment. In https://reviews.llvm.org/D25756#574258, @labath wrote: > No, I'm saying someone *should*. :P > > Ed looked into that at some point but, I don't think get got too far with it. > Adding @emaste, who should probably review this. Yes, it needs to be done. Maybe now that

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This revision is now accepted and ready to land. Not tested, but looks reasonable to me. I think we should avoid `siginfo_t` altogether here in order to support cross-debugging, but that's for a different

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

On 6 October 2016 at 16:42, Zachary Turner wrote: > I'm not sure actually. I only noticed this because I was in IRC and I saw > the message go by about the failure. > > Ed (already CC'ed) maintains the FreeBSD builder, so he might have an answer > for you. I'm not sure why

[Lldb-commits] [lldb] r283472 - Match printf field width arg and type

Author: emaste Date: Thu Oct 6 12:55:22 2016 New Revision: 283472 URL: http://llvm.org/viewvc/llvm-project?rev=283472=rev Log: Match printf field width arg and type A '*' as a field width or precision specifies that the field width or precision is supplied by an int argument. Modified:

Re: [Lldb-commits] [PATCH] D12158: Fix typo in lldb --help

This revision was automatically updated to reflect the committed changes. Closed by commit rL282123: Fix typo in lldb --help (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D12158?vs=32567=72133#toc Repository: rL LLVM https://reviews.llvm.org/D12158 Files:

[Lldb-commits] [lldb] r282123 - Fix typo in lldb --help

Author: emaste Date: Wed Sep 21 18:30:36 2016 New Revision: 282123 URL: http://llvm.org/viewvc/llvm-project?rev=282123=rev Log: Fix typo in lldb --help Patch by Yacine Belkadi Differential Revision: https://reviews.llvm.org/D12158 Modified: lldb/trunk/tools/driver/Driver.cpp Modified:

Re: [Lldb-commits] [lldb] r282112 - Fix integer sign warning from r282105

On 21 September 2016 at 21:38, Adrian McCarthy wrote: > That fix doesn't look complete: Thanks, I've applied your fix in r282119, and sorry for being hasty with the original change. ___ lldb-commits mailing list

[Lldb-commits] [lldb] r282119 - Fix for loop sign fix in r282112 for column = 0

Author: emaste Date: Wed Sep 21 17:36:51 2016 New Revision: 282119 URL: http://llvm.org/viewvc/llvm-project?rev=282119=rev Log: Fix for loop sign fix in r282112 for column = 0 Modified: lldb/trunk/source/Core/SourceManager.cpp Modified: lldb/trunk/source/Core/SourceManager.cpp URL:

Re: [Lldb-commits] [lldb] r282111 - Fix -Wcovered-switch-default warning in StackFrame.cpp

On 21 September 2016 at 17:08, Ed Maste via lldb-commits <lldb-commits@lists.llvm.org> wrote: > Author: emaste > Date: Wed Sep 21 16:08:30 2016 > New Revision: 282111 > > URL: http://llvm.org/viewvc/llvm-project?rev=282111=rev > Log: > Fix -Wcovered-switch-defaul

[Lldb-commits] [lldb] r282112 - Fix integer sign warning from r282105

Author: emaste Date: Wed Sep 21 16:14:31 2016 New Revision: 282112 URL: http://llvm.org/viewvc/llvm-project?rev=282112=rev Log: Fix integer sign warning from r282105 Modified: lldb/trunk/source/Core/SourceManager.cpp Modified: lldb/trunk/source/Core/SourceManager.cpp URL:

[Lldb-commits] [lldb] r282111 - Fix -Wcovered-switch-default warning in StackFrame.cpp

Author: emaste Date: Wed Sep 21 16:08:30 2016 New Revision: 282111 URL: http://llvm.org/viewvc/llvm-project?rev=282111=rev Log: Fix -Wcovered-switch-default warning in StackFrame.cpp The switch coveres all possible values. If a new one is added in the future the compiler will start warning,

Re: [Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

emaste requested changes to this revision. emaste added a reviewer: emaste. emaste added a comment. This revision now requires changes to proceed. Two requested changes called out in comments above https://reviews.llvm.org/D23977 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D5867: Minimal API support for non-8-bit byte targets

emaste added a comment. This change will no longer apply. Is it still desired? If so, can you please rebase the patch. https://reviews.llvm.org/D5867 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r280933 - Fix -Wcovered-switch-default warning in AppleObjCRuntimeV2.cpp

Author: emaste Date: Thu Sep 8 08:17:42 2016 New Revision: 280933 URL: http://llvm.org/viewvc/llvm-project?rev=280933=rev Log: Fix -Wcovered-switch-default warning in AppleObjCRuntimeV2.cpp The switch coveres all possible values. If a new one is added in the future the compiler will start

[Lldb-commits] [lldb] r280931 - Fix unused variable and integer sign warnings from r280906

Author: emaste Date: Thu Sep 8 08:11:31 2016 New Revision: 280931 URL: http://llvm.org/viewvc/llvm-project?rev=280931=rev Log: Fix unused variable and integer sign warnings from r280906 Modified: lldb/trunk/source/Core/Disassembler.cpp Modified: lldb/trunk/source/Core/Disassembler.cpp URL:

Re: [Lldb-commits] [PATCH] D24293: Use llvm's demangler

emaste added a subscriber: emaste. emaste added a comment. Which library contains `llvm::itaniumDemangle`? https://reviews.llvm.org/D24293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

Author: emaste Date: Tue Sep 6 16:25:31 2016 New Revision: 280755 URL: http://llvm.org/viewvc/llvm-project?rev=280755=rev Log: Reorder FreeBSD Host.cpp #includes to fix build Modified: lldb/trunk/source/Host/freebsd/Host.cpp Modified: lldb/trunk/source/Host/freebsd/Host.cpp URL:

Re: [Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

emaste added a subscriber: emaste. emaste added a comment. - in the future can you please upload with context (e.g. git diff -U) - I think the OS names in utilsOsType.py are kept sorted and the actual enum values are not part of an ABI https://reviews.llvm.org/D23977

  1   2   >