[Lldb-commits] [PATCH] D156997: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGe383776ad0fb: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable (authored by jryans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D156997: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added a subscriber: ekilmer. Herald added a project: All. jryans added a project: LLDB. jryans published this revision for review. Herald added a subscriber: lldb-commits. The `LLDB_LINKER_SUPPORTS_GROUPS` CMake variable

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

jryans added a comment. In D149213#4491889 , @VladimirMakaev wrote: > I think there was an attempt in the past to build TypeSystemRust. Rust > Project had a fork of LLDB with this implemented by Tom Tromey and CodeLLDB > maintainer(vadimcn) has one.

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

jryans added a comment. Ah yes, it’s all done now, feel free to clean up your local state however you prefer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

jryans added a comment. No, once it has been committed, it can’t really be removed from a project of this size. Changes can be reverted, but the existence of the commits and messages remains. Don’t worry about it for this one, just something to think about next time. Repository: rG LLVM

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

jryans added a comment. Exciting, welcome to the LLVM community!  Overall your commit looks okay, but here are a few tips for the future... The "Summary:" prefix in the commit title is not needed. It's good to start the commit title with an active verb e.g. "Add foo to bar". You can

[Lldb-commits] [PATCH] D135577: Summary:

jryans added a comment. Please also give this patch a title that would make sense as the first line of a commit message. It currently just says "Summary:" at the moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/

[Lldb-commits] [PATCH] D65437: [lldb][docs] Update landing page for monorepo

jryans accepted this revision. jryans added a comment. Thanks for working on this!  Comment at: lldb/docs/index.rst:104 `__ mailing list , and this is also the preferred mailing list for patch submissions.

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. Current version looks great to me!  Comment at: lldb/docs/resources/build.rst:90 + + > git clone https://github.com/llvm/llvm-project.git This could be done in a separate patch, but I happened to

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602779 , @sgraenitz wrote: > Where did you find the //sub-project list of versioned docs//? On http://releases.llvm.org/, for some recent versions like 8.0.0, the "Documentation" column has separate versioned links

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. In D65330#1602737 , @sgraenitz wrote: > I added a few links to LLVM documentation here and wondered what to do with > them, if this gets cherry-picked to `release/9.x`, e.g. >

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602715 , @sgraenitz wrote: > Cool, patch `Diff 211951` has the change. Here's the difference in generated > output: > https://weliveindetail.github.io/blog/res/lldb-docs/resources/build.html > >

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In D65330#1602583 , @sgraenitz wrote: > Since //Visual Studio// is the only section in //Building LLDB with CMake and > Other Generators// now, I would like to: > > - move it merge it with another one, preferably //Common CMake

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. This revision is now accepted and ready to land. Great!  Thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans added a comment. In general, this looks great overall! I added few comments on things that would be good to clarify. Comment at: lldb/docs/resources/build.rst:108 +subprojects to build in addition to LLVM. Read more about additional options in +the CMake Options

[Lldb-commits] [PATCH] D62654: [Docs] Modernize references to macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL362113: [Docs] Modernize references to macOS (authored by jryans, committed by ). Changed prior to commit: https://reviews.llvm.org/D62654?vs=202161=202247#toc Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D62654: [Docs] Modernize references to macOS

jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, cfe-commits, arphaman, christof, mgorny. Herald added projects: clang, LLDB, libc++, LLVM. This updates all places in documentation that refer to "Mac OS X",

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

jryans marked 2 inline comments as done. jryans added a comment. Thanks for the review @JDevlieghere!  This should be ready for another look. I don't have commit access yet, so assuming it's approved, please commit when you have time. Comment at:

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

jryans updated this revision to Diff 13. jryans added a comment. Updated to remove the whole section Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62041/new/ https://reviews.llvm.org/D62041 Files: lldb/docs/resources/build.rst Index:

[Lldb-commits] [PATCH] D62041: [Docs] Remove SVN checkout from LLDB build steps

jryans created this revision. jryans added a reviewer: JDevlieghere. Herald added a project: LLDB. This removes several older paragraphs in the LLDB build steps for Unix systems which suggested checking out various components via SVN. Since there's a separate page about getting the LLDB source

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans added a comment. @sgraenitz Thanks for committing!  I guess the original author info is lost for this one, but consider adding a "Patch by" line for future commits from those without access. Repository: rL LLVM CHANGES

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans marked 3 inline comments as done. jryans added a comment. Thanks all for the review!  In D61877#1500981 , @sgraenitz wrote: > Thanks for adding this. Would it make sense to use > `LLVM_ENABLE_PROJECTS_USED`? >

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans updated this revision to Diff 199394. jryans added a comment. Updated to support old project layout as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61877/new/ https://reviews.llvm.org/D61877 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D61877: [CMake] Add error to clarify that lldb requires libcxx

jryans created this revision. jryans added reviewers: sgraenitz, JDevlieghere. Herald added a subscriber: mgorny. Herald added a reviewer: EricWF. Herald added a project: LLDB. This adds a specific error message to clarify that lldb requires libcxx when built together with clang on macOS. In