[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

JDevlieghere updated this revision to Diff 535136. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153834/new/ https://reviews.llvm.org/D153834 Files: lldb/include/lldb/Core/SourceManager.h lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

This revision was automatically updated to reflect the committed changes. Closed by commit rGca7914564e67: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D153913: [lldb][NFC] Prevent slicing when converting DataExtractors

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for addressing this. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153913/new/ https://reviews.llvm.org/D153913

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

JDevlieghere updated this revision to Diff 535085. JDevlieghere added a comment. Fix boolean algebra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153834/new/ https://reviews.llvm.org/D153834 Files: lldb/include/lldb/Core/SourceManager.h lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

JDevlieghere added inline comments. Comment at: lldb/source/Core/SourceManager.cpp:86 - // It the target source path map has been updated, get this file again so we - // can successfully remap the source file - if (target_sp && file_sp && -

[Lldb-commits] [PATCH] D153868: [lldb] Use LLVM's implementation of AppleTables for apple_objc

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153868/new/ https://reviews.llvm.org/D153868

[Lldb-commits] [PATCH] D153867: [lldb] Use LLVM's implementation of AppleTables for apple_debug_types

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:232 + + llvm::StringRef expected_name = context[0].name; + I assume

[Lldb-commits] [PATCH] D153844: Summary: [lldb] Fix libncurses, libpanel library link order

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. This isn't a problem on macOS because both are in the shared cache. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D153866: [lldb] Use LLVM's implementation of AppleTables for apple_{names, namespaces}

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, regardless of whether you decided the tackle the the DataExtractor issue. If you don't I would still encourage you to update/simplify/rephrase the comment.

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900

[Lldb-commits] [PATCH] D153827: [lldb][NFCI] Remove use of ConstString from ProcessElfCore

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153827/new/ https://reviews.llvm.org/D153827

[Lldb-commits] [PATCH] D153825: [lldb][NFCI] Change return type of GetProcessPluginName

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153825/new/ https://reviews.llvm.org/D153825

[Lldb-commits] [PATCH] D153818: [lldb][NFCI] Remove use of ConstString from PluginManager

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153818/new/ https://reviews.llvm.org/D153818

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, clayborg, jingham, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. We recently saw an uptick in internal reports complaining that LLDB is slow when source on NFS are

[Lldb-commits] [PATCH] D153824: [lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153824/new/ https://reviews.llvm.org/D153824

[Lldb-commits] [PATCH] D153822: FileSystem::EnumerateDirectory should keep iterating if one entry has an invalid Status

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo capitalization. Comment at: lldb/unittests/Host/FileSystemTest.cpp:54 return make_error_code(llvm::errc::no_such_file_or_directory); +//

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

JDevlieghere updated this revision to Diff 534667. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Remove unused `Resolver`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153726/new/ https://reviews.llvm.org/D153726 Files:

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

JDevlieghere updated this revision to Diff 534663. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153726/new/ https://reviews.llvm.org/D153726 Files: lldb/include/lldb/Core/SourceManager.h

[Lldb-commits] [PATCH] D153685: [lldb] Add `source cache dump` and `source cache clear` subcommand

This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rGd49caf4afc1b: [lldb] Add `source cache dump` and `source cache clear` subcommand (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D153685: [lldb] Add `source cache dump` and `source cache clear` subcommand

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectSource.cpp:1266 : CommandObjectMultiword(interpreter, "source", "Commands for examining "

[Lldb-commits] [PATCH] D153726: [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, clayborg, jingham, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Currently, source files are cached by their resolved path. This means that before we can query the cache, we

[Lldb-commits] [PATCH] D153710: [lldb][NFCI] UUID::Dump should take a reference instead of a pointer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153710/new/ https://reviews.llvm.org/D153710

[Lldb-commits] [PATCH] D153711: [lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153711/new/ https://reviews.llvm.org/D153711

[Lldb-commits] [PATCH] D153673: [lldb][NFCI] Remove unneeded ConstString constructions for OptionValueProperties::AppendProperty

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153673/new/ https://reviews.llvm.org/D153673

[Lldb-commits] [PATCH] D153685: [lldb] Add `source cache dump` and `source cache clear` subcommand

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, clayborg, jingham, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Add two new `source` subcommands: `source cache dump` and `source cache clear`. As the name implies the first

[Lldb-commits] [PATCH] D153657: Don't allow ValueObject::Cast from a smaller type to a larger

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153657/new/ https://reviews.llvm.org/D153657

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere added a comment. In D153644#891 , @jasonmolenda wrote: > It seems like this patch is really avoiding the sign extension of an int8_t > to int32_t in the process of being passed to printf. By casting it to > unsigned we've avoided the

[Lldb-commits] [PATCH] D153648: [lldb] Remove broken shared cache duplicate class handling

JDevlieghere added a comment. Both issues are not present in the code that does the equivalent parsing for Objective-C versions 12 through 15. Most likely I accidentally introduced these bugs when copy/pasting this for the changes in 16. I would prefer to use that rather than diverging our

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f40fc676df: [lldb] Print unprintable characters as unsigned (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D153644?vs=533985=534020#toc

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere added a comment. In D153644#679 , @bulbazord wrote: > Makes sense to me. Does it make sense to add a test case where we mix > "printable" characters with "non-printable" ones? I see you have a `\f` at > the end there, but that's a

[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D153626#096 , @DavidSpickett wrote: > This assumes that the usual use case is: > > - Make a small vector. > - Resize it to what

[Lldb-commits] [PATCH] D153644: [lldb] Print unprintable characters as unsigned

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, DavidSpickett, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. When specifying the C-string format for dumping memory, we treat unprintable characters as signed. Whether a

[Lldb-commits] [PATCH] D153597: [lldb] Adjust for changes in objc runtime

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. This has been previously reviewed internally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153597/new/

[Lldb-commits] [PATCH] D153482: [lldb][NFCI] Remove use of ConstString from StructuredDataPlugin

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153482/new/ https://reviews.llvm.org/D153482

[Lldb-commits] [PATCH] D153433: [lldb][MachO] Fix section type recognition for new DWARF 5 sections

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153433/new/ https://reviews.llvm.org/D153433

[Lldb-commits] [PATCH] D153091: [lldb][TerminalTest] Fix assertion failure

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153091/new/ https://reviews.llvm.org/D153091

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

This revision was automatically updated to reflect the committed changes. Closed by commit rG7371ec76299d: [lldb] Have crashlog warn when remapped paths are inaccessible. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

JDevlieghere updated this revision to Diff 531562. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Make the warning its own line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152886/new/ https://reviews.llvm.org/D152886 Files:

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Should we make this the default behavior in `FileSystem`? Either way I think this belongs there rather than in Host. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:344 +) +if os.path.exists(source_path): +self.resolved_source = True

[Lldb-commits] [PATCH] D152886: [lldb] Make it easier to spot if sources were resolved in crashlog output

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. It can be tricky to troubleshoot why the crashlog script can't show inline sources. The two most common causes are that we couldn't find

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG83a6a0a62047: [lldb] Print lldbassert to debugger diagnostics (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D152866?vs=531126=531161#toc

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 531126. JDevlieghere added a comment. Separate out message, backtrace and prompt. This works better for a custom (downstream) callback that prompts the user to automatically file a bug report. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152872: Add support for __debug_line_str in Mach-O

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152872/new/ https://reviews.llvm.org/D152872 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 53. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152866/new/ https://reviews.llvm.org/D152866 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Utility/LLDBAssert.h lldb/source/API/SystemInitializerFull.cpp

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere updated this revision to Diff 531110. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152866/new/ https://reviews.llvm.org/D152866 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Utility/LLDBAssert.h

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere added a comment. In D152866#4419406 , @bulbazord wrote: > I like this idea quite a bit! I assume that when somebody hits a bug, they > can give us their diagnostics file and we will hopefully see the assertion > somewhere (if there was

[Lldb-commits] [PATCH] D152866: [lldb] Print lldbassert to debugger diagnostics

JDevlieghere created this revision. JDevlieghere added reviewers: labath, rupprecht, bulbazord, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. When hitting an lldbassert in a non-assert build, we emit a blurb including the assertion, the triggering file and

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the other two functions updated as well. Comment at: lldb/include/lldb/Target/Platform.h:453 - void SetSDKRootDirectory(ConstString dir) {

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:52 - void SetSDKRootDirectory(ConstString sdk_root_directory) { -m_sdk_sysroot = sdk_root_directory; + void SetSDKRootDirectory(llvm::StringRef sdk_root_directory) { +

[Lldb-commits] [PATCH] D152331: [lldb][NFCI] Platforms should own their SDKBuild and SDKRootDirectory strings

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:52 - void SetSDKRootDirectory(ConstString sdk_root_directory) { -

[Lldb-commits] [PATCH] D152594: [lldb] Introduce DynamicRegisterInfo::CreateFromDict

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152594/new/ https://reviews.llvm.org/D152594

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/IOHandler.h:110 + virtual llvm::StringRef GetControlSequence(char ch) { +return llvm::StringRef(); + } I would `return {}` or `return ""`. Comment at:

[Lldb-commits] [PATCH] D152590: Streamline expression parser error messages

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152590/new/ https://reviews.llvm.org/D152590 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D152582: [lldb] Change return type of UnixSignals::GetShortName

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152582/new/ https://reviews.llvm.org/D152582

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

JDevlieghere added a comment. In D152364#4406704 , @saugustine wrote: > What other progress reporting needs rate limiting? > > To the best of my knowledge, we have only identified one location--this one. > So I'm not sure a fully general solution is in

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

JDevlieghere added a comment. Continuing some of the discussion from D150805 here as it mostly relates to this patch: In D150805#4402906 , @labath wrote: > I agree that we should have a rate limiting mechanism very

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

JDevlieghere accepted this revision. JDevlieghere added a comment. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152210/new/ https://reviews.llvm.org/D152210 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D152454: [lldb][test] LogTest: Fix stack overflow

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152454/new/ https://reviews.llvm.org/D152454

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp:129-134 llvm::SmallString<64> name; {

[Lldb-commits] [PATCH] D152319: [lldb] Run crashlog inside lldb when invoked in interactive mode from the command line

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b4792159cb7: [lldb] Reinvoke crashlog under lldb when run with -i from the command line (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D152319: [lldb] Run crashlog inside lldb when invoked in interactive mode from the command line

JDevlieghere created this revision. JDevlieghere added reviewers: mib, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Run crashlog inside lldb when invoked in interactive mode from the command line. Currently, when passing -i to crashlog from the command

[Lldb-commits] [PATCH] D152310: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152310/new/ https://reviews.llvm.org/D152310

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo inline question. Comment at: lldb/include/lldb/Utility/Broadcaster.h:358-360 +llvm::StringRef GetBroadcasterName() const { + return

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cd1d4231a7c: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151764: [lldb] Support file and function names in LLDB_LOGF macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG6099d519bb83: [lldb] Support file and function names in LLDB_LOGF macro (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. This is really cool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152011/new/ https://reviews.llvm.org/D152011 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D152220: [lldb][NFCI] Change type of Broadcaster's name

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Utility/Broadcaster.h:157 + /// A StringRef of the name that this broadcaster will have. +

[Lldb-commits] [PATCH] D152011: [lldb/Commands] Add support to auto-completion for user commands

JDevlieghere added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:1279 + // if you & in this bit the base code will not process the option. + eCustomCompletion = (1u << 24) +}; Should this be `<< 25`? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

JDevlieghere accepted this revision. JDevlieghere added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:434 ValueObjectSP root(GetSP()); - for (ConstString name : names) { + for (auto name : names) { root = root->GetChildMemberWithName(name, true);

[Lldb-commits] [PATCH] D151810: [lldb] Take StringRef name in GetIndexOfChildMemberWithName (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151810/new/ https://reviews.llvm.org/D151810

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

JDevlieghere updated this revision to Diff 526854. JDevlieghere added a comment. Use `LLDB_LOG` when `StringRef`s are involved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151762/new/ https://reviews.llvm.org/D151762 Files: lldb/source/Host/common/HostInfoBase.cpp

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

JDevlieghere added a comment. In D151762#4382679 , @mib wrote: > LGTM! Are you considering doing it for the rest of the codebase as well ? > That would be very nice :) Yup, that's the goal. I wanted to gather some initial feedback before I go through

[Lldb-commits] [PATCH] D151764: [lldb] Support file and function names in LLDB_LOGF macro

JDevlieghere updated this revision to Diff 526853. JDevlieghere added a comment. Add unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151764/new/ https://reviews.llvm.org/D151764 Files: lldb/include/lldb/Utility/Log.h lldb/source/Utility/Log.cpp

[Lldb-commits] [PATCH] D151764: [lldb] Support file and function names in LLDB_LOGF macro

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision. LLDB's logging machinery supports prepending log messages with the name of the file and function that generates the log. However, currently this

[Lldb-commits] [PATCH] D151762: [lldb] Remove __FUNCTION__ from log messages in lldbHost (NFC)

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision. LLDB's logging infrastructure supports prepending log messages with the name of the file and function that generates the log (see `help log

[Lldb-commits] [PATCH] D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp:1496-1500 LLDB_LOGF(log,

[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151603/new/ https://reviews.llvm.org/D151603 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151591: HostInfoMacOS: Add a utility function for finding an SDK-specific tool

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/unittests/Host/HostInfoTest.cpp:90 + EXPECT_FALSE(find_tool("MacOSX.sdk", "clang").empty()); + EXPECT_TRUE(find_tool("MacOSX.sdk",

[Lldb-commits] [PATCH] D151570: Fix Build error on Mac M1 : error: use of undeclared identifier 'getopt_long_only'; did you mean 'getopt_long'?

JDevlieghere added a comment. What host compiler are you using when you see this error? `getopt_long_only` is available on macOS. Does this compile for you? #include int main(int argc, char** argv) { struct option longopts[] = { { "foo", required_argument, 0, 'f' }, };

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

JDevlieghere added a comment. I think this test could benefit from switching to string literals (`'''`) and doing a single `self.assertIn` rather than scanning the whole output for every line. Also please use `black` (version 23) to format the test. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. I suspect you'll run into the same problem when you get the API tests working, but we can deal with that when the time comes. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

JDevlieghere added a comment. My suggestion was to add rate limiting support to the listener so that all events could benefit from this. The current patch seems unnecessary ad-hoc: it's limited to (1) progress events and (2) the default event handler. I expects that lldb-vscode plugin users

[Lldb-commits] [PATCH] D151516: [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151516/new/ https://reviews.llvm.org/D151516

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

This revision was automatically updated to reflect the committed changes. Closed by commit rGe31f99464216: [lldb] Improve error message when evaluating expression when not stopped (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D151524: [lldb][NFCI] Change type of SBDebugger::m_instance_name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151524/new/ https://reviews.llvm.org/D151524

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

JDevlieghere added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:127 + +bool Watchpoint::VariableWatchpointDisabler(void *baton, +StoppointCallbackContext *context, mib wrote: > JDevlieghere wrote:

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

JDevlieghere added inline comments. Comment at: lldb/source/Breakpoint/Watchpoint.cpp:127 + +bool Watchpoint::VariableWatchpointDisabler(void *baton, +StoppointCallbackContext *context, I think this should return an

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

JDevlieghere added inline comments. Comment at: lldb/source/Expression/UserExpression.cpp:211 +error.SetErrorStringWithFormatv( +"unable to evaluate expression while the process is {0}: the process " +"must be stopped because the expression might requires

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

JDevlieghere updated this revision to Diff 525861. JDevlieghere added a comment. Rephrase error message for `UserExpression::Evaluate` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151497/new/ https://reviews.llvm.org/D151497 Files: lldb/source/Expression/UserExpression.cpp

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

JDevlieghere added a comment. In D151497#4374080 , @bulbazord wrote: > I think it's good to improve the error messaging but I think we can probably > do better. "Function caller" is specific to the internals of LLDB and isn't > really meaningful for

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, aprantl, bulbazord, mib. Herald added a project: All. JDevlieghere requested review of this revision. When trying to run an expression after a process has existed, you currently are shown the following error message:

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG2238dcc39358: [NFC][Py Reformat] Reformat python files in lldb (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D151460?vs=525647=525759#toc

[Lldb-commits] [PATCH] D151451: [lldb][nfc] Refactor methods with out parameter

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151451/new/ https://reviews.llvm.org/D151451

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

JDevlieghere added a comment. In D151460#4372779 , @thieta wrote: > In D151460#4372763 , @mib wrote: > >> Can you add this commit hash to the `.git-blame-ignore-revs` file so it >> doesn't show up in the git

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

JDevlieghere added a comment. In D151460#4372711 , @thieta wrote: > Thanks for doing this! Going to assume you ran the tests and it worked :) Yup, no regressions. I'll keep an eye on the bots to make sure that holds true for other configurations too.

[Lldb-commits] [PATCH] D151460: [NFC][Py Reformat] Reformat python files in lldb

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, thieta. Herald added subscribers: pmatos, asb, ormris, mstorsjo, wenlei, arphaman, steven_wu, kbarton, hiraditya, fedor.sergeev, sbc100, nemanjai, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a

<    1   2   3   4   5   6   7   8   9   10   >