[Lldb-commits] [PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

kwk accepted this revision. kwk added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk abandoned this revision. kwk added a comment. There already is a Debuginfod implementation in LLVM by now. Abandoning revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a comment. Looks like it is already there: https://github.com/llvm/llvm-project/tree/main/llvm/include/llvm/Debuginfod Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a subscriber: phosek. kwk added a comment. @iridinite please see these: - https://discourse.llvm.org/t/http-library-in-llvm/56317/10 - https://discourse.llvm.org/t/rfc-building-llvm-debuginfod/59011 - https://discourse.llvm.org/t/rfc-building-llvm-debuginfod/58994 -

[Lldb-commits] [PATCH] D97721: [lldb] Support DWARF-5 DW_FORM_line_strp (used by GCC)

kwk added a comment. @jankratochvil out of curiosity. Can you give a pointer to what the C program looks like that produces the object code? I know GCC might change and no longer produce this code so it's better to have the obj code instead. But still I'm not nearly close to understanding

[Lldb-commits] [PATCH] D83180: Set generic error in SBError SetErrorToGenericError

kwk added a comment. LGTM but a test would indeed be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83180/new/ https://reviews.llvm.org/D83180 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa01e956a4: [lldb] on s390x fix override issue (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

kwk added a comment. In D83580#2144871 , @serge-sans-paille wrote: > Possible followup: shouldn't all the other `Get*` be flagged as `const` too? Thank you @serge-sans-paille . You're right but I'm unsure if all getters are actually const or not. And

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an override issue by marking a function as const so that the signature maps to the signature of the function in the base class. This is the original error: In file included from

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 273637. kwk added a comment. - Simplify logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:323 + // passing. + remove_it = false; + } jankratochvil wrote: > Now `if (filter_by_function) {}` always

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 273307. kwk added a comment. - bring back logic to keep a symbol context when a function passes and add a comment as Jan suggested - remove test from scripted resolver that calls SearchFilterByModulesAndSupportFiles::AddressPasses - before the test checked

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 273309. kwk added a comment. - Add newlines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py:124 -file_list.Append(lldb.SBFileSpec("noFileOfThisName.xxx")) -

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 271631. kwk added a comment. - Remove old logic that was no longer needed since my search filter now adaptively adds eSymbolContextCompUnit and not always returns it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked 6 inline comments as done. kwk added inline comments. Comment at: lldb/source/Core/SearchFilter.cpp:713 + if (!type) +return SearchFilterByModuleList::FunctionPasses(function); + jankratochvil wrote: > If we cannot determine which file the

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath @jingham @jankratochvil The test change suggested by @labath is now in place and it works. @jankratochvil, I've removed the logic that checks seomthing with the CU from `AddressPasses`. That logic now lives in `FunctionPasses` where it logically makes more sense to

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 271583. kwk added a comment. - Align tests with reviewer expectations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added inline comments. Comment at: lldb/source/Core/SearchFilter.cpp:732 +FileSpec cu_spec; +if (sym_ctx.comp_unit) { + cu_spec = sym_ctx.comp_unit->GetPrimaryFile(); jankratochvil wrote: > This condition is

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk planned changes to this revision. kwk added a comment. IMPORTANT: The behavior of `target.inline-breakpoint-strategy` when set to `headers` is still subject to change! I think the setting is not respected correctly... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath I've applied all the ideas we ping-ponged yesterday and I decided to go with alternating the `target.inline-breakpoint-strategy` from `always` (the default) to `headers`. This way you can exactly see in the test file how things are behaving. So before going into

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269787. kwk marked an inline comment as done. kwk added a comment. - remove debug output from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files:

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269784. kwk added a comment. - Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269782. kwk added a comment. - remove commented out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/include/lldb/Core/SearchFilter.h

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 269781. kwk marked an inline comment as done. kwk added a comment. - Outsource parts into SearchFilterByModulesAndSupportFiles::FunctionPasses - Tests with alternating setting target.inline-breakpoint-strategy between "always" and "headers" - Respecting

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added a comment. @labath please see my inline comment. Comment at: lldb/source/Breakpoint/BreakpointResolverName.cpp:315 + if (filter_by_cu && filter_by_function) { +// Keep this symbol context if it is a function call to

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266493. kwk marked an inline comment as done. kwk added a comment. - don't hard-code --color and --dump-input on FileCheck invocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266472. kwk added a comment. - make test CHECKs less strict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked 2 inline comments as done. kwk added inline comments. Comment at: lldb/test/Shell/Breakpoint/Inputs/search-support-files.h:1 +int inlined_42() { return 42; } labath wrote: > Calling this `inlined` is misleading. The function won't get inlined anywhere

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266465. kwk marked 3 inline comments as done. kwk added a comment. - use %t in files created in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files:

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 266463. kwk marked 3 inline comments as done. kwk added a comment. Herald added a subscriber: sstefan1. - rebase - Rename function in test from inlined_42 to function_in_header - Typo: compulation -> compilation Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D80543: [lldb] Manual remove of DISALLOW_COPY_AND_ASSIGN def and one expansion

kwk abandoned this revision. kwk added a comment. Sorry, wrong revisions uploaded Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80543/new/ https://reviews.llvm.org/D80543 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D72698: [lldb] Add method decls to a CXXRecordDecl only after all their properties are defined

kwk added a comment. > The only code that is currently after addDecl is changing whether the special > members are > defaulted/trivial. I'm not sure if this actually fixes anything but it's > more correct than what we > did before. But at least you return immediately after calling `addDecl`.

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

kwk added a comment. I've marked some mistakes that were not addressed yet but are marked as "Done". Comment at: lldb/docs/resources/test.rst:86 + +API tests are located under ``lldb/test/API``. Thy are run with the +``dotest.py``. Tests are written in Python and test binaries

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a subscriber: fche. kwk added a comment. In D75750#1988330 , @labath wrote: > lldb-dev is indeed a better place for the architectural discussion. However, > moving the discussion there does not automatically unblock this patch. "get >

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. All tests pass. I first thought that the `lldb/test/Shell/Reproducer/TestGDBRemoteRepro.test` test didn't work but it seems to be flaky. Comment at:

[Lldb-commits] [PATCH] D78337: [lldb/Host] Remove TaskPool and replace its uses with llvm::ThreadPool

kwk resigned from this revision. kwk added a comment. This revision now requires review to proceed. I resign because I think @labath made some good points that I cannot argue about. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78337/new/

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a comment. In D75750#1971446 , @labath wrote: > In D75750#1967019 , @fche2 wrote: > > > >> So it might be good to have the SymbolVendors use one or more > > >> SymbolServer plug-ins. > > > > > > I don't

[Lldb-commits] [PATCH] D78242: [lldb/Docs] Add some more info about the test suite layout

kwk added a comment. This looks good overall. I would add a section describing which test suite to use when you're interested in a particular DWARF feature for example. I heard from my GDB colleagues that the don't use a compiler, because that might change and produce a different DWARF.

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 258004. kwk added a comment. - Remove not needed include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257691. kwk added a comment. - Revert "Honor the module" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk marked an inline comment as done. kwk added a comment. In D74136#1889066 , @labath wrote: > Yes, I believe this matches the behavior we were talking about. > > I could make a bunch of comments on the implementation and the test, but I'm > not sure if

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257688. kwk added a comment. - Honor the module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257682. kwk added a comment. - Modify SearchFilterByModuleListAndCU - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files:

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 257313. kwk added a comment. Ran git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [PATCH] D78109: Ran git clang-format

kwk abandoned this revision. kwk added a comment. Sorry, wrong `arc diff` invocation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78109/new/ https://reviews.llvm.org/D78109 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D78109: Ran git clang-format

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D74136 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78109 Files: lldb/source/Core/SearchFilter.cpp Index:

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 255648. kwk added a comment. - Simplified test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 255339. kwk added a comment. - rebased onto master to get rid of NFC change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files:

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

This revision was automatically updated to reflect the committed changes. kwk marked an inline comment as done. Closed by commit rG9072df8ac143: [lldb][nfc] remove overriden funcs with default impl (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255300. kwk added a comment. - Simplify comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk marked 2 inline comments as done. kwk added a comment. @jankratochvil thanks for the tip. @labath, addressed your comments and will now push it. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + /// \note if not overriden, default implementation always \c

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk added a comment. @jankratochvil for now I've re-added the `AddressPasses` functions and the `FIXME` comment. Can you approve? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 ___ lldb-commits

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255026. kwk edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h lldb/source/Core/SearchFilter.cpp Index:

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk added a subscriber: lattner. kwk added a comment. Had some problem with my `arc diff` reporting that another git was running which it wasn't so I had to update the diff by hand with a bit of trouble. Comment at: lldb/include/lldb/Core/SearchFilter.h:102 + /// + ///

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255024. kwk marked 3 inline comments as done. kwk added a comment. Re-added `AddressPasses` with FIXME comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/source/Core/SearchFilter.cpp Index:

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk updated this revision to Diff 255022. kwk added a comment. - fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77376/new/ https://reviews.llvm.org/D77376 Files: lldb/include/lldb/Core/SearchFilter.h

[Lldb-commits] [PATCH] D77377: [lldb][nfc] early exit/continue

This revision was automatically updated to reflect the committed changes. Closed by commit rG107200ae0a03: [lldb][nfc] early exit/continue (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77377/new/ https://reviews.llvm.org/D77377

[Lldb-commits] [PATCH] D77377: [lldb][nfc] early exit/continue

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit just tries to invert some `if`'s logic to `return`/`continue` early. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77377 Files:

[Lldb-commits] [PATCH] D77376: [lldb][nfc] remove overriden funcs with default impl

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These three `SearchFilter` methods all return `true` by their default implementation: virtual bool ModulePasses(const FileSpec ); virtual bool ModulePasses(const lldb::ModuleSP _sp); virtual

[Lldb-commits] [PATCH] D77336: Findtypes -gmodules fix

kwk added a comment. Could you explain, why this was done please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77336/new/ https://reviews.llvm.org/D77336 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. No need to split this into multiples revisions. It is just a rewrite of some odd nesting. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2943 +//

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

kwk added a comment. Overall looks good to me except for one larger logic change. Maybe a your comment can clarify this. The code was in a very bad shape before, given the countless amounts of shortcuts you could take. Comment at:

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

kwk added a comment. In D77108#1952039 , @labath wrote: > In D77108#1951997 , @kwk wrote: > > > In D77108#1951879 , @labath wrote: > > > > > Most DW_OP cases check their

[Lldb-commits] [PATCH] D77108: [lldb/DWARF] Fix evaluator crash when accessing empty stack

kwk added a comment. In D77108#1951879 , @labath wrote: > In D77108#1951610 , @aprantl wrote: > > > This is obviously good! Do you think that a similar error handling bug > > might exist in other cases that depend

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk updated this revision to Diff 253531. kwk added a comment. - Use file:// and require debuginfod 0.179 - simplify FindDebuginfod.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files:

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

kwk added a comment. Let's summarize this. 1. In the old and the new version, the program is aborted with an `assert()` if the configuration is `LLDB_CONFIGURATION_DEBUG`. 2. In the old version, nothing happens, when the configuration is non-Debug. 3. In the new version, the assert in non-Debug

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk marked 3 inline comments as done. kwk added a comment. @labath I made a signficant simplification of starting and killing the server. I hope you like that better. Comment at: lldb/source/Core/SourceManager.cpp:408 + if ((!file_spec.GetDirectory() &&

[Lldb-commits] [PATCH] D74187: [lldb] Add method Language::IsMangledName

kwk requested changes to this revision. kwk added a comment. This revision now requires changes to proceed. I agree with @friss that there is a change in behavior. I'm not sure it is fixable with what I wrote but I think so. Comment at: lldb/include/lldb/Target/Language.h:191

[Lldb-commits] [PATCH] D76736: [LLDB] Fix parsing of IPv6 host:port inside brackets

kwk added a comment. LGTM but I haven't tested it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76736/new/ https://reviews.llvm.org/D76736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk updated this revision to Diff 252510. kwk marked 10 inline comments as done. kwk added a comment. - Add newline to end of FindDebuginfod.cmake - Describe empty string returned from debuginfod::findSource() - Don't treat build IDs of len <= 8 as an error but simply as not found - move

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk added a comment. @jankratochvil thanks for this thorough review. I have to think about one comment more precisely but the rest was fixed. Comment at: lldb/source/Host/common/DebugInfoD.cpp:50 + "invalid build ID: %s", +

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

kwk marked 10 inline comments as done. kwk added a comment. @labath @jankratochvil @fche2 I've addressed all your comments and hope the patch is good to go now. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43 + buildID.GetBytes().size() == +

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252353. kwk added a comment. - Add documentation for workaround on rejecting special build UUIDs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files:

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252059. kwk added a comment. - Adjust buildID verification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252054. kwk marked 2 inline comments as done. kwk added a comment. - Remove commented out code - Remove lldb/packages/Python/lldbsuite/test/httpserver.py in favor of lit test - Removed commented out left-over code Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath @fche2 @jankratochvil I've implemented the logic to ignore invalid UUIDs and the ones that are too short. Can you have another look please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 252026. kwk added a comment. - check for valid UUID - less verbose mkdir and rm output - More explicit test and documentation - fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251383. kwk added a comment. - Validate that the server received the request from debuginfod client Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files:

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251376. kwk marked 6 inline comments as done. kwk added a comment. - Removed not needed forward decl - Format comments for better readability in my test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath I've improved my test file for readability. Comment at: lldb/include/lldb/Host/DebugInfoD.h:26 + +llvm::Error findSource(UUID buildID, const std::string , + std::string _path); labath wrote: > Expected ?

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251297. kwk added a comment. - Fix NameError: name 'TRUE' is not defined Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk planned changes to this revision. kwk added a comment. In D75750#1929967 , @jankratochvil wrote: > On Fedora 31 x86_64 with LLDB using python3 I got: > > llvm-lit: .../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py:102: > fatal: unable to

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath I've updated my patch and would love to hear your opinion on it. So far I've only written the python `ServeDirectoryWithHTTP()` function with proper doctest and documentation but since you mentioned the `0` port thingy I've tried that on the command line when using

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251086. kwk added a comment. Herald added a reviewer: jdoerfert. - Added debuginfod2.py - after running: autopep8 --in-place --aggressive --aggressive debuginfod2.py - exponential backoff implemented - Added http.py with doctests - autopep8 --in-place

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 249096. kwk added a comment. - Fix include ordering based on clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files: lldb/cmake/modules/FindDebuginfod.cmake

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk marked an inline comment as done. kwk added a comment. @labath thank you for your early feedback. It was helpful even though this is still a work in progress. Comment at: lldb/source/Host/common/DebugInfoD.cpp:43-67 +UUID getBuildIDFromModule(const ModuleSP ) { + UUID

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 249047. kwk marked 3 inline comments as done. kwk added a comment. Changes suggested by elfutils maintainers: - Silently ignore error when no DEBUGINFOD_URLS was given as an environment variable (ENOSYS). - Silently ignore error when the build ID could not be

[Lldb-commits] [PATCH] D75753: Simplified return type of getBuildIDFromModule

kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75753/new/ https://reviews.llvm.org/D75753 ___ lldb-commits

[Lldb-commits] [PATCH] D75754: Fix typo

kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75754/new/ https://reviews.llvm.org/D75754 ___ lldb-commits

[Lldb-commits] [PATCH] D75754: Fix typo

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Depends on D75753 . Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 248746. kwk added a comment. - Simplified return type of getBuildIDFromModule - fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75750/new/ https://reviews.llvm.org/D75750 Files:

[Lldb-commits] [PATCH] D75753: Simplified return type of getBuildIDFromModule

kwk created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kwk added a child revision: D75754: Fix typo. kwk abandoned this revision. kwk added a comment. I didn't intend to create a new revision. Depends on D75750 .

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kwk planned changes to this revision. This first patch does the heavy lifting of bootstrapping debuginfod with CMake and integrating it to find a source file using debuginfod when using

[Lldb-commits] [PATCH] D74650: [lldb] WIP: idea for keeping filenames in raw form when coming from DWARF

kwk abandoned this revision. kwk added a comment. I abandon this revision because @labath mentioned that in the past we must have had something similar: two file specs where one was normalized and one doesn't and then the behavior was not very predictable. I hope this recaptures our

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. I figured it might be the easiest to re-use `SearchFilterByModuleListAndCU` but it needs to be renamed still. If you have a good suggestion, please let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk added a comment. @labath @jingham Can you please have a look at the `lldb/test/Shell/Breakpoint/search-support-files.test` to see if the test reflects the desired behavior? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 246162. kwk added a comment. - Clear formatting - Make list private again - Remove open from CommandObjectBreakpoint.cpp - Remove change in unrelated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Optionally follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 246160. kwk added a comment. Updated tests and code to remove the --search-source-files flag and make it the default behavior to also search source files. TODO: rename class SearchFilterByModuleListAndCU to something more meaningful when an agreement on the

[Lldb-commits] [PATCH] D74895: [lldb]: fix typo in lldb-gdb-remote.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b7f76ae6ae: [lldb]: fix typo in lldb-gdb-remote.txt (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74895/new/

  1   2   3   >