[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

2021-03-02 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In D96766#2596701 , @labath wrote: > Hm I'm very tempted to delete the linux mips implementation -- it uses > several techniques which are getting in the way of this patch (and also some > others in the past), for a lot

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set

2017-08-14 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL310855: [LLDB][MIPS] Set the Section's file address for (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D35784?vs=110924=111006#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is not set

2017-08-14 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 110924. nitesh.jain retitled this revision from "[LLDB][MIPS] The symbol with NOTYPE and having section type debug doesn't contain any valid address" to "[LLDB][MIPS] Set the Section's file address for ELF section to LLDB_INVALID_ADDRESS if SHF_ALLOC is

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE and having section type debug doesn't contain any valid address

2017-08-11 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. The $debug_rangesN symbols are added by linker. These symbols are not used anywhere We can skip these type of symbols (where symbol type is STT_NOTYPE and its section is Debug) https://reviews.llvm.org/D35784 ___

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE and having section type dwarf doesn't contain any valid address

2017-08-11 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 110698. nitesh.jain retitled this revision from "[LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid address" to "[LLDB][MIPS] The symbol with NOTYPE and having section type dwarf doesn't contain any valid address". Herald added a subscriber:

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid address

2017-08-09 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 110364. nitesh.jain retitled this revision from "[LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address" to "[LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid address".

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

2017-08-04 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D11465#826132, @tberghammer wrote: > Thanks for all of the data. Based on this I think you are using a preview > version of android O what reports SDK 25 but the linker works the way an SDK > 26 system linker would do. > > I think the

[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-08-04 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. ping https://reviews.llvm.org/D35784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

2017-07-31 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Hi Tamas, > Run "target modules list" (lldb) target modules list [ 0] E6A47987----

[Lldb-commits] [PATCH] D36046: Improve the posix core file triple detection

2017-07-31 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:733-735 + if (target_arch.IsMIPS()) { return target_arch; + } tberghammer wrote: > Hi Nitesh, > > I tried to remove this MIPS specific code as it shouldn't

[Lldb-commits] [PATCH] D11465: Fix "process load/unload" on android

2017-07-27 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added inline comments. Comment at: lldb/trunk/source/Plugins/Platform/Android/PlatformAndroid.cpp:389 + struct __lldb_dlopen_result { void *image_ptr; const char *error_str; } the_result; + the_result.image_ptr = __dl_dlopen

[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-07-26 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D35784#820237, @clayborg wrote: > Looking at an ELF file with DWARF, I see: > > (lldb) image dump sections > Dumping sections for 1 modules. > Sections for >

[Lldb-commits] [PATCH] D35784: [LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address

2017-07-24 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain created this revision. Herald added subscribers: arichardson, sdardis. The implementation of Address::GetAddressClass() is based on file address. Those it will give incorrect result if there are more than one section for a particular file address. For example (see attach log), there

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

2017-05-04 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL302139: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure. (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D32168?vs=97415=97811#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

2017-05-02 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 97415. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D32168 Files: include/lldb/API/SBAddress.h include/lldb/API/SBInstruction.h include/lldb/API/SBInstructionList.h include/lldb/Core/Disassembler.h

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

2017-04-27 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Hi Ki, The changes has been committed (https://reviews.llvm.org/rL301537). Thanks Repository: rL LLVM https://reviews.llvm.org/D32340 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

2017-04-27 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:329 +# We need to get past these instructions with a step to reach call to s_MyFunction. +self.runCmd("-exec-step --thread 1")

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

2017-04-27 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 96891. nitesh.jain added a comment. Update Diff as per suggestion https://reviews.llvm.org/D32168 Files: include/lldb/API/SBAddress.h include/lldb/API/SBInstruction.h include/lldb/API/SBInstructionList.h include/lldb/Core/Disassembler.h

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

2017-04-27 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL301530: [LLDB][MIPS] Fix TestMiExec.py failure. (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D32340?vs=96368=96890#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

2017-04-26 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 96722. nitesh.jain added a comment. Update diff as per suggestion https://reviews.llvm.org/D32168 Files: include/lldb/API/SBAddress.h include/lldb/API/SBInstructionList.h

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

2017-04-25 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D32125#736543, @sdardis wrote: > Hi Nitesh, > > this commit broke clang-cmake-mips. Can you investigate? > > http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/3189 > > Thanks, > Simon Hi Simon, The assertion has been fixed.

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

2017-04-24 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL301171: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM. (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D32125?vs=95573=96374#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

2017-04-24 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D32125#734500, @emaste wrote: > In https://reviews.llvm.org/D32125#728166, @krytarowski wrote: > > > Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms > > 20+ years ago. > > > > It's perhaps no-op, but it might be

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

2017-04-24 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain marked an inline comment as done. nitesh.jain added a comment. In https://reviews.llvm.org/D32340#733387, @ki.stfu wrote: > Thanks for catching this! Could you update this CL to let me commit it? Yes , Please commit it. https://reviews.llvm.org/D32340

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

2017-04-24 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 96368. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D32340 Files: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py Index: packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py

[Lldb-commits] [PATCH] D32340: [LLDB][MIPS] Fix TestMiExec.py failure

2017-04-21 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain created this revision. Herald added subscribers: arichardson, ki.stfu. Call to s_MyFunction may not follow immediately after g_MyFunction. There might be some instructions in between to restore caller-saved registers. We need to get past these instructions with a step to reach call

[Lldb-commits] [PATCH] D32168: [LLDB][MIPS] Fix TestStepOverBreakpoint.py failure

2017-04-18 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain created this revision. Herald added a subscriber: arichardson. In case of MIPS, we never add breakpoint in the delay slot. Hence while doing stepping, the delay slot instruction will be skipped. https://reviews.llvm.org/D32168 Files:

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

2017-04-18 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D32125#728166, @krytarowski wrote: > Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ > years ago. > > It's perhaps no-op, but it might be noted in the commit message what > platforms are supposed to be

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

2017-04-18 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 95573. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D32125 Files: cmake/modules/HandleLLVMOptions.cmake Index: cmake/modules/HandleLLVMOptions.cmake

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

2017-04-17 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain created this revision. Herald added subscribers: arichardson, mgorny. Fix is to define _LARGEFILE_SOURCE and _FILE_OFFSET_BITS=64. This fix will cause llvm::sys::fs::file_size() to return correct object size. Repository: rL LLVM https://reviews.llvm.org/D32125 Files:

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-03-31 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299200: [LLDB][MIPS] Core Dump Support. (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D30457?vs=92768=93616#toc Repository: rL LLVM https://reviews.llvm.org/D30457

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-31 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299199: [LLDB][MIPS] Fix Core file Architecture and OS information. (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D31280?vs=93130=93615#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module.

2017-03-31 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL299196: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding… (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D30454?vs=91855=93614#toc Repository: rL

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-27 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 93130. nitesh.jain added a comment. Update diff as per suggestion. Thanks https://reviews.llvm.org/D31280 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. The core architecture doesn't have any revision, os and ABI information. Hence we need to relied on target architecture. https://reviews.llvm.org/D31280 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:220 + // information. Hence we need to relied on target architecture for that. + if (arch.IsValid() && !arch.IsMIPS()) +GetTarget().SetArchitecture(arch);

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 92808. nitesh.jain added a comment. updated diff as per suggestion https://reviews.llvm.org/D31280 Files: packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:675 + llvm::Triple host_triple(llvm::sys::getDefaultTargetTriple()); + target_arch.GetTriple().setOS(host_triple.getOS()); +} labath wrote: >

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:675 + llvm::Triple host_triple(llvm::sys::getDefaultTargetTriple()); + target_arch.GetTriple().setOS(host_triple.getOS()); +} labath wrote: > I'm not

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. They are around ~28KB Repository: rL LLVM https://reviews.llvm.org/D31280 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Added test case for MIPS in https://reviews.llvm.org/D31280 https://reviews.llvm.org/D30457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31280: [LLDB][MIPS] Fix Core file Architecture and OS information

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain created this revision. Herald added a subscriber: sdardis. The MIPS core file doesn't contain any Architecture revision, OS and ABI information. Hence we need to relied on executable to get that information. This patch also add core file test cases for MIPS. Patch By:- Bhushan

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-03-23 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 92768. nitesh.jain added a comment. In case of MIPS, The ELFLinuxPrPsInfo.pr_uid and ELFLinuxPrPsInfo.pr_gid is always 32 bit irrespective of platforms https://reviews.llvm.org/D30457 Files: source/Core/ArchSpec.cpp

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-03-15 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D30457#694306, @labath wrote: > Thank you for updating that. Let me know what the make_core investigation > uncovers. In case of MIPS, the core file doesn't contain Arch and OS information. Hence we shared information from

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-03-15 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 91881. nitesh.jain added a comment. Update Diff as per suggestion https://reviews.llvm.org/D30457 Files: source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module.

2017-03-15 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 91855. nitesh.jain retitled this revision from "[LLDB][MIPS] Regain Module Name if memory_info.GetName() is empty" to "[LLDB][MIPS] Check if memory_info.GetName() is empty before finding corresponding module.". nitesh.jain edited the summary of this

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Regain Module Name if memory_info.GetName() is empty

2017-03-15 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 91833. nitesh.jain retitled this revision from "[LLDB][MIPS] Fix typo in MatchesModuleSpec()" to "[LLDB][MIPS] Regain Module Name if memory_info.GetName() is empty". nitesh.jain added a comment. In case of debugging normal process, the

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

2017-03-07 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D30454#693614, @clayborg wrote: > So a ModuleSpec allows you to specify a module by path, UUID and many other > things. This is falling down for a magic file that doesn't actually exist > right? Yes. > "vsdo" is just a made up

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-03-02 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain marked an inline comment as done. nitesh.jain added a comment. The .note.ABI-tag is missing in the ELF file, generated by test/testcases/functionalities/postmortem/elf-core/make-core.sh. Need to look into it. -Thanks https://reviews.llvm.org/D30457

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-03-02 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain marked an inline comment as done. nitesh.jain added inline comments. Comment at: source/Plugins/Process/Utility/RegisterInfoInterface.h:32 + virtual const lldb_private::RegisterSet * + GetRegisterSet(size_t set) const {return nullptr;} labath

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-03-02 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 90328. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D30457 Files: source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

2017-03-02 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Attach log file F3122646: module.log https://reviews.llvm.org/D30454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

2017-03-02 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. The issue was observed while parsing "vdso module" for the core file. When the DynamicLoader::LoadModuleAtAddress is called to load "vdso" module. Since "vdso" doesn't match with any of the module in the target.GetImages(), the check_alternative_file_name becomes

[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

2017-02-28 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain created this revision. This patch add support for core file. This patch includes - Separation of register context which was earlier share between Linux and FreeBSD. - Add support to analyse Linux core file for all three ABI (N32, N64 and O32) https://reviews.llvm.org/D30457

[Lldb-commits] [PATCH] D30454: [LLDB][MIPS] Fix typo in MatchesModuleSpec()

2017-02-28 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain created this revision. The MatchesModuleSpec() should return false if module_ref is not found. https://reviews.llvm.org/D30454 Files: source/Core/Module.cpp Index: source/Core/Module.cpp === ---

[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

2017-02-07 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294415: [LLDB][MIPS] Fix TestMiniDumpNew (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D29215?vs=86268=87598#toc Repository: rL LLVM https://reviews.llvm.org/D29215

[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

2017-01-30 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 86268. nitesh.jain added a comment. Added setUp/tearDown code, which saves and restores the original platform after each run. Thanks https://reviews.llvm.org/D29215 Files:

[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

2017-01-27 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. ERROR: test_two_cores_same_pid (TestMiniDumpNew.MiniDumpNewTestCase) Test that we handle the situation if we have two core files with the same PID -- Traceback (most recent call last): File

[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

2017-01-27 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain created this revision. In case of a core file, if the core file architecture(like x86_64) is incompatible with that of Host architecture(like Mips64) then platform is set to remote-platform. If the remote-platform is not connected then SBPlatform::GetTriple() will return none.

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-10 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291549: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D27088?vs=83520=83781#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-06 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 83520. nitesh.jain added a comment. Update diff as per suggestion https://reviews.llvm.org/D27088 Files: packages/Python/lldbsuite/test/lldbdwarf.py packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py Index:

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-03 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Instead of creating header SBDwarf.h, is it possible that python can reuse llvm Dwarf.h ? Thanks https://reviews.llvm.org/D27088 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2017-01-03 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 83012. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D27088 Files: include/lldb/API/SBDwarf.h packages/Python/lldbsuite/test/lldbtest.py packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2016-12-09 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Hi Greg, The patch https://reviews.llvm.org/D20357 evaluated the DwarfExpression and update the floating point register size. So should we implement SBRegisterContext and SBArchSpec to evaluate dwarf expression and update the floating point register size

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-12-09 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289211: [LLDB][MIPS] Fix TestWatchpointIter failure (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D27124?vs=80414=80895#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D27085: [LLDB][MIPS] Fix TestMultipleHits for MIPS

2016-12-09 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289210: [LLDB][MIPS] Fix TestMultipleHits for MIPS (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D27085?vs=79038=80893#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D26542: [LLDB][MIPS] Fix some test case failures due to "elf_abi" field of qprocessInfo packet

2016-12-09 Thread Nitesh Jain via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL289209: [LLDB][MIPS] Fix some test case failures due to elf_abi field of qprocessInfo… (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D26542?vs=77603=80892#toc

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2016-12-06 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. Hi Greg, I am not sure whether this approach will work in Multithreaded application. Since if any thread modify the SR.FR bit then the change will get reflect in all copy of SR.FR of all other threads. So if we stop at thread A and thread B (running) try to modify

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-12-06 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 80414. nitesh.jain added a comment. Update diff as per suggestion https://reviews.llvm.org/D27124 Files: source/Target/StopInfo.cpp Index: source/Target/StopInfo.cpp === ---

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2016-12-01 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 79890. nitesh.jain added a comment. Update diff as per suggestion. Thanks https://reviews.llvm.org/D27088 Files: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py Index:

[Lldb-commits] [PATCH] D27088: [LLDB][MIPS] Fix TestLldbGdbServer failure for MIPS

2016-12-01 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 79881. nitesh.jain added a comment. Update diff as per suggestion. https://reviews.llvm.org/D27088 Files: packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py Index:

[Lldb-commits] [PATCH] D27124: [LLDB][MIPS] Fix TestWatchpointIter failure

2016-11-30 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated the summary for this revision. nitesh.jain updated this revision to Diff 79864. nitesh.jain added a comment. Updated diff as per suggestion. https://reviews.llvm.org/D27124 Files: source/Target/StopInfo.cpp Index: source/Target/StopInfo.cpp