[Lldb-commits] [lldb] r340460 - Add include directory for libxml on macOS

Author: sas Date: Wed Aug 22 15:25:45 2018 New Revision: 340460 URL: http://llvm.org/viewvc/llvm-project?rev=340460=rev Log: Add include directory for libxml on macOS Summary: Builds fail because libxml/xmlreader.h isn't found. Adding the include directory to the include list fixes the issue.

[Lldb-commits] [lldb] r339974 - Add a relocation for R_AARCH64_ABS32 in ObjectFileELF

Author: sas Date: Thu Aug 16 17:35:47 2018 New Revision: 339974 URL: http://llvm.org/viewvc/llvm-project?rev=339974=rev Log: Add a relocation for R_AARCH64_ABS32 in ObjectFileELF Summary: .rela.debug_info relocations are being done via ObjectFileELF::ApplyRelocations for aarch64. Currently, the

[Lldb-commits] [lldb] r339071 - Revert "Add a relocation for R_AARCH64_ABS32 in ObjectFileELF"

Author: sas Date: Mon Aug 6 15:21:28 2018 New Revision: 339071 URL: http://llvm.org/viewvc/llvm-project?rev=339071=rev Log: Revert "Add a relocation for R_AARCH64_ABS32 in ObjectFileELF" This reverts commit f055ce7eb893cd0d17ebcfd4125018f46f983aff. Modified:

[Lldb-commits] [lldb] r339068 - Add a relocation for R_AARCH64_ABS32 in ObjectFileELF

Author: sas Date: Mon Aug 6 15:04:08 2018 New Revision: 339068 URL: http://llvm.org/viewvc/llvm-project?rev=339068=rev Log: Add a relocation for R_AARCH64_ABS32 in ObjectFileELF Summary: .rela.debug_info relocations are being done via ObjectFileELF::ApplyRelocations for aarch64. Currently, the

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

Yeah, just a quick note about ds2, this is the current status of supported platforms: * Linux (x86/x86_64/arm/aarch64), used for debugging processes on "classic" linux (Ubuntu, centOS, etc), Android, as well as Tizen. * Windows (x86/x86_64/arm), used to debug processes on Windows Desktop, Windows

[Lldb-commits] [lldb] r319191 - Simplify UUID constructors

Author: sas Date: Tue Nov 28 09:50:31 2017 New Revision: 319191 URL: http://llvm.org/viewvc/llvm-project?rev=319191=rev Log: Simplify UUID constructors Summary: This remove a small amount of duplicated code. Reviewers: clayborg, zturner, davide Subscribers: lldb-commits Differential Revision:

[Lldb-commits] [lldb] r319132 - Remove some duplicated code in UUID.cpp

Author: sas Date: Mon Nov 27 17:26:07 2017 New Revision: 319132 URL: http://llvm.org/viewvc/llvm-project?rev=319132=rev Log: Remove some duplicated code in UUID.cpp Summary: Formatting needs to be done only once. Ran check-lldb and nothing changes. Reviewers: clayborg, davide Reviewed By:

[Lldb-commits] [lldb] r319095 - Mark UUID::GetByteSize() const

Author: sas Date: Mon Nov 27 13:16:37 2017 New Revision: 319095 URL: http://llvm.org/viewvc/llvm-project?rev=319095=rev Log: Mark UUID::GetByteSize() const Summary: This method doesn't modify anything in the object it's called on so we can mark it const to make it usable in a const context.

[Lldb-commits] [lldb] r318886 - Run clang-format on source/Host/common/Symbols.cpp

Author: sas Date: Wed Nov 22 15:56:32 2017 New Revision: 318886 URL: http://llvm.org/viewvc/llvm-project?rev=318886=rev Log: Run clang-format on source/Host/common/Symbols.cpp I saw a bunch of style errors so this fixes them. Modified: lldb/trunk/source/Host/common/Symbols.cpp Modified:

[Lldb-commits] [lldb] r318079 - Reformat a comment. NFC.

Author: sas Date: Mon Nov 13 12:13:25 2017 New Revision: 318079 URL: http://llvm.org/viewvc/llvm-project?rev=318079=rev Log: Reformat a comment. NFC. Modified: lldb/trunk/include/lldb/lldb-private-defines.h Modified: lldb/trunk/include/lldb/lldb-private-defines.h URL:

[Lldb-commits] [lldb] r317529 - Disable tests in lang/c/shared_lib on Windows

Author: sas Date: Mon Nov 6 16:14:40 2017 New Revision: 317529 URL: http://llvm.org/viewvc/llvm-project?rev=317529=rev Log: Disable tests in lang/c/shared_lib on Windows Summary: These fail because `-fPIC` is not supported on Windows. Reviewers: zturner, jingham, clayborg Reviewed By:

Re: [Lldb-commits] [PATCH] D39692: Disable tests in lang/c/shared_lib on Windows

I think @zturner is correct. Shared libraries do work with lldb on Windows, just just that these tests are not buildable for Windows. On Mon, Nov 6, 2017 at 1:56 PM Zachary Turner wrote: > It’s been a long time since I looked at this but I remember it just being > a problem

[Lldb-commits] [lldb] r317501 - Add a dependency from check-lldb on lld

Author: sas Date: Mon Nov 6 11:25:33 2017 New Revision: 317501 URL: http://llvm.org/viewvc/llvm-project?rev=317501=rev Log: Add a dependency from check-lldb on lld Summary: This is required when using the in-tree clang for building tests, because -fuse-ld=lld is used by default. Subscribers:

Re: [Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld

Makes sense. I'll update the diff. On Mon, Nov 6, 2017 at 9:28 AM Zachary Turner wrote: > This is definitely required, but only on windows. I’d put it behind a > check for Windows, and I’d also add a check to print a warning/error if > (TARGET lld) returns false on windows >

[Lldb-commits] [lldb] r317219 - Run clang-format on lldb.cpp

Author: sas Date: Thu Nov 2 09:56:52 2017 New Revision: 317219 URL: http://llvm.org/viewvc/llvm-project?rev=317219=rev Log: Run clang-format on lldb.cpp Modified: lldb/trunk/source/lldb.cpp Modified: lldb/trunk/source/lldb.cpp URL:

[Lldb-commits] [lldb] r317218 - Use LLVM version string

Author: sas Date: Thu Nov 2 09:56:19 2017 New Revision: 317218 URL: http://llvm.org/viewvc/llvm-project?rev=317218=rev Log: Use LLVM version string Summary: macOS builds of LLDB use the bundle version from `tools/driver/lldb-Info.plist`. That file hasn't been updated since the 4.0 release so

Re: [Lldb-commits] [lldb] r316673 - Allow SysV-i386 ABI on everything other than Apple targets

at 10:04 AM, Stephane Sezer via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > Author: sas > > Date: Thu Oct 26 10:04:20 2017 > > New Revision: 316673 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=316673=rev > > Log: > >

[Lldb-commits] [lldb] r316673 - Allow SysV-i386 ABI on everything other than Apple targets

Author: sas Date: Thu Oct 26 10:04:20 2017 New Revision: 316673 URL: http://llvm.org/viewvc/llvm-project?rev=316673=rev Log: Allow SysV-i386 ABI on everything other than Apple targets Summary: This matches other SysV ABIs that are different on Apple and non-Apple targets, like `ABISysV_arm.cpp`

[Lldb-commits] [lldb] r316532 - Allow ObjectFilePECOFF to initialize with ARM binaries.

Author: sas Date: Tue Oct 24 16:40:59 2017 New Revision: 316532 URL: http://llvm.org/viewvc/llvm-project?rev=316532=rev Log: Allow ObjectFilePECOFF to initialize with ARM binaries. Summary: This is required to start debugging WinPhone ARM targets. Reviewers: compnerd, zturner, omjavaid

[Lldb-commits] [lldb] r316527 - Remove some unused function calls from ClangUserExpression.cpp

Author: sas Date: Tue Oct 24 16:01:33 2017 New Revision: 316527 URL: http://llvm.org/viewvc/llvm-project?rev=316527=rev Log: Remove some unused function calls from ClangUserExpression.cpp Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified:

[Lldb-commits] [lldb] r315221 - Update ABISysV_arm64::RegisterIsVolatile to accept registers prefixed with r

Author: sas Date: Mon Oct 9 10:49:32 2017 New Revision: 315221 URL: http://llvm.org/viewvc/llvm-project?rev=315221=rev Log: Update ABISysV_arm64::RegisterIsVolatile to accept registers prefixed with r Summary: While the specification says that the 64bit registers are prefixed with `x`, it seems

Re: [Lldb-commits] [PATCH] D12245: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.

I do. We still use this but always in a remote debugging scenario so I never had issues with this diff and I haven't gotten around to looking at windows unit tests at all. On Mon, Oct 2, 2017 at 9:43 AM Zachary Turner via Phabricator < revi...@reviews.llvm.org> wrote: > zturner added a comment.

[Lldb-commits] [lldb] r314455 - Add a few missing newlines in lldb-server messages

Author: sas Date: Thu Sep 28 12:49:00 2017 New Revision: 314455 URL: http://llvm.org/viewvc/llvm-project?rev=314455=rev Log: Add a few missing newlines in lldb-server messages Reviewers: fjricci, clayborg Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D38373

[Lldb-commits] [lldb] r314045 - Implement trampoline step-through for Windows-x86.

Author: sas Date: Fri Sep 22 16:41:41 2017 New Revision: 314045 URL: http://llvm.org/viewvc/llvm-project?rev=314045=rev Log: Implement trampoline step-through for Windows-x86. Summary: This is required to be able to step through calls to external functions that are not properly marked with

Re: [Lldb-commits] [lldb] r313437 - Check availability of accept4 in C++ instad of C code.

What difference does this make? On Fri, Sep 15, 2017 at 8:00 PM Eugene Zemtsov via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: eugene > Date: Fri Sep 15 19:58:49 2017 > New Revision: 313437 > > URL: http://llvm.org/viewvc/llvm-project?rev=313437=rev > Log: > Check availability

[Lldb-commits] [lldb] r304725 - Avoid invalid string access in ObjCLanguage::MethodName::SetName

Author: sas Date: Mon Jun 5 12:44:04 2017 New Revision: 304725 URL: http://llvm.org/viewvc/llvm-project?rev=304725=rev Log: Avoid invalid string access in ObjCLanguage::MethodName::SetName Summary: Don't access `name[1] if the string is only of length 1. Avoids a crash/assertion failure when

[Lldb-commits] [lldb] r303677 - Fix bad change in RenderScriptx86ABIFixups.cpp, forgot to change everything necessary

Author: sas Date: Tue May 23 14:22:31 2017 New Revision: 303677 URL: http://llvm.org/viewvc/llvm-project?rev=303677=rev Log: Fix bad change in RenderScriptx86ABIFixups.cpp, forgot to change everything necessary Summary: I didn't change all instances of i to I in this loop. I am a bad person

[Lldb-commits] [lldb] r303674 - hange RenderScriptx86ABIFixups.cpp to use llvm::AttributeList iterator

Author: sas Date: Tue May 23 13:54:03 2017 New Revision: 303674 URL: http://llvm.org/viewvc/llvm-project?rev=303674=rev Log: hange RenderScriptx86ABIFixups.cpp to use llvm::AttributeList iterator LLVM::AttributeList recently had getNumSlots() removed, which broke the build. This fixes the build

[Lldb-commits] [lldb] r299239 - Verify memory address range validity in GDBRemoteCommunicationClient

Author: sas Date: Fri Mar 31 13:00:48 2017 New Revision: 299239 URL: http://llvm.org/viewvc/llvm-project?rev=299239=rev Log: Verify memory address range validity in GDBRemoteCommunicationClient Summary: This aims to verify the validity of the response from the debugging server in

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

I'm currently busy with other stuff but I'll get back to this soon. I think we have a different version of this internally which seems to work properly, so I'll make sure everything is clean and re-upload a better version. On Tue, Dec 20, 2016 at 11:34 AM, Greg Clayton via Phabricator

[Lldb-commits] [PATCH] D26676: Patch for lldb bug 26322 “core load hangs”

sas added a comment. Just a couple nits inline. Also, did you run `clang-format` on your change? I see some issues with `if`s and the associated parentheses. Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:215 + } + if (siginfo_signal_found == false) { +

[Lldb-commits] [PATCH] D25947: Merge Linux and FreeBSD arm64 register contexts

sas accepted this revision. sas added a reviewer: sas. sas added a comment. Cool stuff. Are you planning on doing a similar change for other architectures? https://reviews.llvm.org/D25947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r285658 - Remove executable bit on a source file

Author: sas Date: Mon Oct 31 19:21:57 2016 New Revision: 285658 URL: http://llvm.org/viewvc/llvm-project?rev=285658=rev Log: Remove executable bit on a source file Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp (contents, props changed) Modified:

Re: [Lldb-commits] [PATCH] D22891: Remove a duplicated block in cmake.

This revision was automatically updated to reflect the committed changes. Closed by commit rL277060: Remove a duplicated block in cmake. (authored by sas). Changed prior to commit: https://reviews.llvm.org/D22891?vs=65839=66038#toc Repository: rL LLVM https://reviews.llvm.org/D22891

[Lldb-commits] [lldb] r277060 - Remove a duplicated block in cmake.

Author: sas Date: Thu Jul 28 17:11:54 2016 New Revision: 277060 URL: http://llvm.org/viewvc/llvm-project?rev=277060=rev Log: Remove a duplicated block in cmake. Summary: This is supposed to find the python lib dir and seems like it's just been copied twice by mistake. Reviewers: tfiala

[Lldb-commits] [PATCH] D22891: Remove a duplicated block in cmake.

sas created this revision. sas added a reviewer: tfiala. sas added a subscriber: lldb-commits. This is supposed to find the python lib dir and seems like it's just been copied twice by mistake. https://reviews.llvm.org/D22891 Files: source/Host/CMakeLists.txt Index:

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

Yeah I can do this today. > On Jul 19, 2016, at 1:58 AM, Zachary Turner wrote: > > I can't test this on Windows until Friday because I'm traveling and my laptop > isn't set up to build lldb. Could Stephane maybe help? > > > On Tue, Jul 19, 2016 at 1:51 AM Saleem

Re: [Lldb-commits] [PATCH] D22294: Add functionality for rewriting symbols

sas added a comment. In http://reviews.llvm.org/D22294#483264, @clayborg wrote: > Note that during function lookup, we can find **both** "putchar" and > "__my_putchar" in the debug info, so you will be able to call both. Correct, unless as you pointed out both symbols are in libraries, and

Re: [Lldb-commits] [PATCH] D22294: Add functionality for rewriting symbols

sas added a comment. In http://reviews.llvm.org/D22294#483250, @clayborg wrote: > In http://reviews.llvm.org/D22294#483213, @sas wrote: > > > @jingham, @clayborg, this is indeed a bit fragile as having to specify your > > rewrite maps manually when debugging is very error-prone. I have a patch

Re: [Lldb-commits] [PATCH] D22294: Add functionality for rewriting symbols

sas added a comment. @jingham, @clayborg, this is indeed a bit fragile as having to specify your rewrite maps manually when debugging is very error-prone. I have a patch that fetches the path to the rewrite map from the debug info, I'm waiting for this one to go in to upload that other diff

[Lldb-commits] [lldb] r275287 - Fix a check in the objc trampoline handler

Author: sas Date: Wed Jul 13 12:34:26 2016 New Revision: 275287 URL: http://llvm.org/viewvc/llvm-project?rev=275287=rev Log: Fix a check in the objc trampoline handler Summary: The function FunctionCaller::WriteFunctionArguments returns false on errors, so they should check for the false return

[Lldb-commits] [PATCH] D22278: Fix a check in the objc trampoline handler

sas created this revision. sas added reviewers: jingham, clayborg. sas added a subscriber: lldb-commits. The function FunctionCaller::WriteFunctionArguments returns false on errors, so they should check for the false return value. Change by Walter Erquinigo

Re: [Lldb-commits] [PATCH] D22235: Build clang Debug if we build lldb debug.

sas abandoned this revision. sas added a comment. Ah, makes sense, I had missed the `DebugClang` build configuration. Thanks for pointing this out. http://reviews.llvm.org/D22235 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r275140 - Add LLVM build config for BuildAndIntegration.

Author: sas Date: Mon Jul 11 20:44:58 2016 New Revision: 275140 URL: http://llvm.org/viewvc/llvm-project?rev=275140=rev Log: Add LLVM build config for BuildAndIntegration. Reviewers: tfiala, clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D22234 Modified:

Re: [Lldb-commits] [PATCH] D22234: Add LLVM build config for BuildAndIntegration.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275140: Add LLVM build config for BuildAndIntegration. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D22234?vs=63548=63628#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275139: Make ThreadPlanStepInstruction's constructor public. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D22230?vs=63625=63627#toc Repository: rL LLVM

[Lldb-commits] [lldb] r275139 - Make ThreadPlanStepInstruction's constructor public.

Author: sas Date: Mon Jul 11 20:43:46 2016 New Revision: 275139 URL: http://llvm.org/viewvc/llvm-project?rev=275139=rev Log: Make ThreadPlanStepInstruction's constructor public. Summary: Some thread plans have public contructors, some others have protected constructors with friend classes. Not

Re: [Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

sas updated this revision to Diff 63625. sas added a comment. Rebase. http://reviews.llvm.org/D22230 Files: include/lldb/Target/ThreadPlanStepInstruction.h Index: include/lldb/Target/ThreadPlanStepInstruction.h === ---

[Lldb-commits] [lldb] r275134 - Apply local patches when building llvm on Mac.

Author: sas Date: Mon Jul 11 20:28:59 2016 New Revision: 275134 URL: http://llvm.org/viewvc/llvm-project?rev=275134=rev Log: Apply local patches when building llvm on Mac. Summary: This is already done when building for linux with the CMake build system. This functionality disappeared recently

Re: [Lldb-commits] [PATCH] D22233: Apply local patches when building llvm on Mac.

This revision was automatically updated to reflect the committed changes. Closed by commit rL275134: Apply local patches when building llvm on Mac. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D22233?vs=63547=63619#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

Sounds good. I can make a separate patch to make all the constructors public if you think that's better. See http://reviews.llvm.org/D22230 for a patch that makes one of the constructors public. Is this patch good to go in its current form then? On Mon, Jul 11, 2016 at 12:21 PM, Jim Ingham

Re: [Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

sas added a subscriber: sas. sas added a comment. Sounds good. I can make a separate patch to make all the constructors public if you think that's better. See http://reviews.llvm.org/D22230 for a patch that makes one of the constructors public. Is this patch good to go in its current form then?

Re: [Lldb-commits] [PATCH] D22235: Build clang Debug if we build lldb debug.

sas updated this revision to Diff 63550. sas added a comment. Remove leftover comment. http://reviews.llvm.org/D22235 Files: lldb.xcodeproj/project.pbxproj scripts/Xcode/build-llvm.py Index: scripts/Xcode/build-llvm.py ===

[Lldb-commits] [PATCH] D22235: Build clang Debug if we build lldb debug.

sas created this revision. sas added reviewers: tfiala, clayborg. sas added a subscriber: lldb-commits. When we build Debug, we might be tracking down bugs in clang/llvm as well, so building it Debug with assertions helps debug the debugger. http://reviews.llvm.org/D22235 Files:

[Lldb-commits] [PATCH] D22234: Add LLVM build config for BuildAndIntegration.

sas created this revision. sas added reviewers: tfiala, clayborg. sas added a subscriber: lldb-commits. http://reviews.llvm.org/D22234 Files: scripts/Xcode/build-llvm.py Index: scripts/Xcode/build-llvm.py === ---

[Lldb-commits] [PATCH] D22233: Apply local patches when building llvm on Mac.

sas created this revision. sas added reviewers: tfiala, clayborg. sas added a subscriber: lldb-commits. This is already done when building for linux with the CMake build system. This functionality disappeared recently when some of the build scripts used by the xcode build system changed.

Re: [Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

sas requested a review of this revision. sas added a comment. @jingham, it looks like the `GetStepThroughTrampolinePlan` functions do not queue the thread plan themselves. See `DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan` for instance that just does `new ThreadPlanRunToAddress(...)`.

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

sas updated this revision to Diff 63542. sas added a comment. Use arm-pc-windows intead of armv7-pc-windows. http://reviews.llvm.org/D19604 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp

[Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

sas created this revision. sas added reviewers: clayborg, zturner. sas added a subscriber: lldb-commits. This is required to be able to step through calls to external functions that are not properly marked with __declspec(dllimport). When a call like this is emitted, the linker will inject a

[Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

sas created this revision. sas added reviewers: clayborg, zturner. sas added a subscriber: lldb-commits. Some thread plans have public contructors, some others have protected constructors with friend classes. Not sure how these were determined, but this thread plan is going to be required to

Re: [Lldb-commits] [PATCH] D20312: Fix function name lookup in IRExecutionEngine.cpp.

This revision was automatically updated to reflect the committed changes. Closed by commit rL271863: Fix function name lookup in IRExecutionEngine.cpp. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D20312?vs=57854=59685#toc Repository: rL LLVM

[Lldb-commits] [lldb] r271863 - Fix function name lookup in IRExecutionEngine.cpp.

Author: sas Date: Sun Jun 5 21:50:46 2016 New Revision: 271863 URL: http://llvm.org/viewvc/llvm-project?rev=271863=rev Log: Fix function name lookup in IRExecutionEngine.cpp. Summary: Without this commit, when `log enable lldb expr` is enabled, the disassembly of JIT'ed code is never displayed.

Re: [Lldb-commits] [PATCH] D20990: Don't remove PIE executables when using svr4 packets

sas added a comment. Nit: Adding a comment explaining why we special-case the main executable (i.e.: because it is never included in `libraries-svr4` packets) might be useful here. http://reviews.llvm.org/D20990 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D20623: [cmake] Add ability to customize (and skip) debugserver codesign

sas accepted this revision. sas added a comment. This is really useful. http://reviews.llvm.org/D20623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19608: Checkout release_38 branches of llvm and clang when building lldb 3.8

sas accepted this revision. sas added a reviewer: sas. sas added a comment. This revision is now accepted and ready to land. I did the same thing back when 3.7 was the current release branch and I think @clayborg reviewed it at that point. Without this, we simply can't build the release branch.

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

sas added a comment. @compnerd: - We don't use thumb-* triples in lldb as far as I can see. Thumb is handled just fine regardless of the triple. - `pc` vs `unknown` doesn't seem to matter either, and other code in this file uses `pc` (see a few lines above). - `msvc` vs `itanium` is also

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

sas added a comment. @zturner, you might be right, I might have to change the code I have to load the initial executable's `Module` and use an offset different than 0 there. I'll wait to see what @clayborg says. http://reviews.llvm.org/D19603 ___

Re: [Lldb-commits] [PATCH] D18779: Fix dotest.py '-p' option for multi-process mode

sas closed this revision. sas added a comment. Committed as r265422. http://reviews.llvm.org/D18779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265422 - Fix dotest.py '-p' option for multi-process mode

Author: sas Date: Tue Apr 5 12:34:38 2016 New Revision: 265422 URL: http://llvm.org/viewvc/llvm-project?rev=265422=rev Log: Fix dotest.py '-p' option for multi-process mode Summary: The '-p' option for dotest.py was ignored in multiprocess mode, as the -p argument to the inferior would

Re: [Lldb-commits] [PATCH] D18660: Update watchpoint help to use new -s flag

sas closed this revision. sas added a comment. Committed as r265421. http://reviews.llvm.org/D18660 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265421 - Update watchpoint help to use new -s flag

Author: sas Date: Tue Apr 5 12:30:31 2016 New Revision: 265421 URL: http://llvm.org/viewvc/llvm-project?rev=265421=rev Log: Update watchpoint help to use new -s flag Summary: Flag updated in D233237 Reviewers: spyffe, jingham, Eugene.Zelenko Subscribers: lldb-commits, sas Differential

Re: [Lldb-commits] [PATCH] D18631: Make sure to update Target arch if environment changed

sas closed this revision. sas added a comment. Committed as r265419. http://reviews.llvm.org/D18631 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265420 - Print environment when dumping arch triple

Author: sas Date: Tue Apr 5 12:29:19 2016 New Revision: 265420 URL: http://llvm.org/viewvc/llvm-project?rev=265420=rev Log: Print environment when dumping arch triple Summary: Print environment from triple if it exists. Reviewers: tfiala, clayborg Subscribers: lldb-commits, sas Differential

[Lldb-commits] [lldb] r265419 - Make sure to update Target arch if environment changed

Author: sas Date: Tue Apr 5 12:27:52 2016 New Revision: 265419 URL: http://llvm.org/viewvc/llvm-project?rev=265419=rev Log: Make sure to update Target arch if environment changed Summary: Fixes "target list" for non-android linux platforms (ie gnu, gnueabi) Reviewers: jasonmolenda, tfiala,

Re: [Lldb-commits] [PATCH] D18531: Allow gdbremote process to read modules from memory

sas closed this revision. sas added a comment. Committed as r265418. http://reviews.llvm.org/D18531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r265418 - Allow gdbremote process to read modules from memory

Author: sas Date: Tue Apr 5 12:25:32 2016 New Revision: 265418 URL: http://llvm.org/viewvc/llvm-project?rev=265418=rev Log: Allow gdbremote process to read modules from memory Summary: The logic to read modules from memory was added to LoadModuleAtAddress in the dynamic loader, but not in

Re: [Lldb-commits] [PATCH] D18459: Fix FILE * leak in Python API

sas added a comment. Committed as r264476. http://reviews.llvm.org/D18459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r264476 - Fix FILE * leak in Python API

Author: sas Date: Fri Mar 25 18:40:32 2016 New Revision: 264476 URL: http://llvm.org/viewvc/llvm-project?rev=264476=rev Log: Fix FILE * leak in Python API Summary: This fixes a leak introduced by some of these changes: r257644 r250530 r250525 The changes made in these patches result in leaking

Re: [Lldb-commits] [PATCH] D18228: Make File option flags consistent for Python API

sas closed this revision. sas added a comment. Committed as r264351. http://reviews.llvm.org/D18228 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r264351 - Make File option flags consistent for Python API

Author: sas Date: Thu Mar 24 17:22:20 2016 New Revision: 264351 URL: http://llvm.org/viewvc/llvm-project?rev=264351=rev Log: Make File option flags consistent for Python API Summary: Fixes SBCommandReturnObject::SetImmediateOutputFile() and SBCommandReturnObject::SetImmediateOutputFile() for

Re: [Lldb-commits] [PATCH] D17970: Implement ObjectFilePECOFF::GetEntryPointAddress.

This revision was automatically updated to reflect the committed changes. Closed by commit rL264173: Implement ObjectFilePECOFF::GetEntryPointAddress. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D17970?vs=50978=51449#toc Repository: rL LLVM

[Lldb-commits] [lldb] r264173 - Implement ObjectFilePECOFF::GetEntryPointAddress.

Author: sas Date: Wed Mar 23 13:00:13 2016 New Revision: 264173 URL: http://llvm.org/viewvc/llvm-project?rev=264173=rev Log: Implement ObjectFilePECOFF::GetEntryPointAddress. Reviewers: zturner, clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D17970 Modified:

[Lldb-commits] [lldb] r263735 - Fix deadlock due to thread list locking in 'bt all' with obj-c

Author: sas Date: Thu Mar 17 13:52:41 2016 New Revision: 263735 URL: http://llvm.org/viewvc/llvm-project?rev=263735=rev Log: Fix deadlock due to thread list locking in 'bt all' with obj-c Summary: The gdb-remote async thread cannot modify thread state while the main thread holds a lock on the

Re: [Lldb-commits] [PATCH] D17970: Implement ObjectFilePECOFF::GetEntryPointAddress.

sas updated this revision to Diff 50978. sas added a comment. Change implementation according to @clayborg's comments. http://reviews.llvm.org/D17970 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index:

Re: [Lldb-commits] [PATCH] D17970: Implement ObjectFilePECOFF::GetEntryPointAddress.

sas added a comment. Yep, @jingham is right, I need this for expression evaluation. I'll do the change @clayborg requested. http://reviews.llvm.org/D17970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D17970: Implement ObjectFilePECOFF::GetEntryPointAddress.

sas added a comment. FWIW, I didn't cache this value because in the current form it is just returning some data that is already cached by `ParseHeader()`. If I split it in section/offset address, it might be required. http://reviews.llvm.org/D17970

Re: [Lldb-commits] [PATCH] D18075: Fix deadlock due to thread list locking in 'bt all' with obj-c

sas closed this revision. sas added a comment. Committed as r263735. http://reviews.llvm.org/D18075 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D17970: Implement ObjectFilePECOFF::GetEntryPointAddress.

sas created this revision. sas added reviewers: zturner, clayborg. sas added a subscriber: lldb-commits. http://reviews.llvm.org/D17970 Files: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h Index:

Re: [Lldb-commits] [PATCH] D17425: Use shallow clones in build-llvm.py.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262513: Use shallow clones in build-llvm.py. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D17425?vs=48427=49663#toc Repository: rL LLVM http://reviews.llvm.org/D17425 Files:

[Lldb-commits] [lldb] r262513 - Use shallow clones in build-llvm.py.

Author: sas Date: Wed Mar 2 14:53:19 2016 New Revision: 262513 URL: http://llvm.org/viewvc/llvm-project?rev=262513=rev Log: Use shallow clones in build-llvm.py. Summary: This makes cloning (and therefore the whole build) faster. The checkout step goes from ~4m to ~30s on my host. Reviewers:

[Lldb-commits] [PATCH] D17425: Use shallow clones in build-llvm.py.

sas created this revision. sas added a reviewer: tfiala. sas added a subscriber: lldb-commits. This makes cloning (and therefore the whole build) faster. The checkout step goes from ~4m to ~30s on my host. http://reviews.llvm.org/D17425 Files: scripts/Xcode/lldbbuild.py Index:

[Lldb-commits] [lldb] r259433 - Fix getCompiler in unit testing framework on compiler symlinks

Author: sas Date: Mon Feb 1 17:21:27 2016 New Revision: 259433 URL: http://llvm.org/viewvc/llvm-project?rev=259433=rev Log: Fix getCompiler in unit testing framework on compiler symlinks Summary: Checks using the result of getCompiler() will fail to identify the compiler correctly if CC is a

Re: [Lldb-commits] [lldb] r257502 - Increase use of svr4 packets to improve performance on POSIX remotes

Looking at it now. On Tue, Jan 12, 2016 at 11:25 AM, Siva Chandra <sivachan...@google.com> wrote: > This breaks the build: > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/4487 > > On Tue, Jan 12, 2016 at 11:02 AM, Stephane Sezer via lldb-commi

[Lldb-commits] [lldb] r257502 - Increase use of svr4 packets to improve performance on POSIX remotes

Author: sas Date: Tue Jan 12 13:02:41 2016 New Revision: 257502 URL: http://llvm.org/viewvc/llvm-project?rev=257502=rev Log: Increase use of svr4 packets to improve performance on POSIX remotes Summary: Allows the remote to enumerate the link map when adding and removing shared libraries, so

[Lldb-commits] [lldb] r257510 - Fix build breakage of r257502.

Author: sas Date: Tue Jan 12 14:22:58 2016 New Revision: 257510 URL: http://llvm.org/viewvc/llvm-project?rev=257510=rev Log: Fix build breakage of r257502. Modified: lldb/trunk/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp Modified:

Re: [Lldb-commits] [PATCH] D16099: Get rid of ARM_ELF_SYM_IS_THUMB flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257429: Get rid of ARM_ELF_SYM_IS_THUMB flag. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D16099?vs=44583=44588#toc Repository: rL LLVM http://reviews.llvm.org/D16099

[Lldb-commits] [lldb] r257429 - Get rid of ARM_ELF_SYM_IS_THUMB flag.

Author: sas Date: Mon Jan 11 19:12:10 2016 New Revision: 257429 URL: http://llvm.org/viewvc/llvm-project?rev=257429=rev Log: Get rid of ARM_ELF_SYM_IS_THUMB flag. Summary: This was used with the old ARM vs. Thumb detection code but is not required anymore. Reviewers: tberghammer, clayborg

Re: [Lldb-commits] [PATCH] D14507: Make sure we use symbol flags to detect thumbness.

sas abandoned this revision. sas added a comment. Not required anymore. http://reviews.llvm.org/D14507 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D16099: Get rid of ARM_ELF_SYM_IS_THUMB flag.

sas created this revision. sas added reviewers: tberghammer, clayborg. sas added subscribers: lldb-commits, fjricci. Herald added subscribers: rengolin, aemerson. This was used with the old ARM vs. Thumb detection code but is not required anymore. http://reviews.llvm.org/D16099 Files:

[Lldb-commits] [lldb] r257204 - Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

Author: sas Date: Fri Jan 8 14:32:35 2016 New Revision: 257204 URL: http://llvm.org/viewvc/llvm-project?rev=257204=rev Log: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor Summary: When we construct AppleObjCTrampolineHandler, if m_impl_fn_addr is invalid, we call

  1   2   >