Author: tberghammer
Date: Wed Feb 10 06:10:58 2016
New Revision: 260377
URL: http://llvm.org/viewvc/llvm-project?rev=260377=rev
Log:
Revert "Improve the handling of missing elf symtab and missing symbol sizes"
This reverts commit 252dda67782f2cbf838e375bce21ed4191f6d9ce.
The commit caused
Author: tberghammer
Date: Tue Feb 9 04:10:42 2016
New Revision: 260216
URL: http://llvm.org/viewvc/llvm-project?rev=260216=rev
Log:
Fix a typo in an xfail decorator in TestExprsChar
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
Modified:
tberghammer added a comment.
My main concern is that we have a lot of named argument for
skipIf/expectFailure and I expect it to increase even further as we support
more and more configuration. In my opinion we can have some functional style
solution as readable as the current solution with
tberghammer updated this revision to Diff 47314.
http://reviews.llvm.org/D16996
Files:
include/lldb/Core/RangeMap.h
include/lldb/Symbol/DWARFCallFrameInfo.h
include/lldb/Symbol/ObjectFile.h
include/lldb/Symbol/Symtab.h
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
tberghammer added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2939
@@ +2938,3 @@
+symbol_id, // Symbol table index.
+symbol_name, // Symbol name.
+false,
tberghammer added a comment.
In http://reviews.llvm.org/D16853#347120, @omjavaid wrote:
> GDB doesnt use bkpt instruction for user debugging for the reason that it
> interferes with jtag debug probes. I am not sure if LLDB will be ever used
> with a jtag probe in near future but still a jtag
tberghammer abandoned this revision.
tberghammer added a comment.
The change was submitted with a different CL
http://reviews.llvm.org/D16680
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tberghammer added a comment.
Jason: Can you take at the change in the unwinding logic?
Comment at: source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp:13653
@@ -13656,2 +13652,3 @@
const uint32_t cond = CurrentCond (m_opcode.GetOpcode32());
-return cond != 0xe &&
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Add new option to lldb-server to display its version
http://reviews.llvm.org/D17030
Files:
tools/lldb-server/lldb-server.cpp
Index: tools/lldb-server/lldb-server.cpp
tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:592
@@ +591,3 @@
+{
+if (!is_complex)
+{
Please check that "float_count == 1" as well (we don't want to use this
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
In http://reviews.llvm.org/D16936#346182, @labath wrote:
> I agree with the idea in general, but I wanted to ask what is your plan with
> the android decorators: For them we use the additional `api_levels` flag,
> which
tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:597
@@ +596,3 @@
+{
+if (base_type.IsFloatingPointType(float_count, is_complex))
+{
omjavaid wrote:
> tberghammer
tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:581-591
@@ -580,10 +580,13 @@
{
size_t byte_size = compiler_type.GetByteSize();
if (byte_size <= 4)
{
RegisterValue r0_reg_value;
tberghammer added a comment.
In http://reviews.llvm.org/D16936#346536, @tfiala wrote:
> > I agree but I also might consider going further where the only thing you
> > can specify is a function and we remove all arguments. Then we implement
> > functions like architectureMatches,
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Improve the handling of missing elf symtab and missing symbol sizes
* Generate artificial symbol names from eh_fame during symbol parsing
so these symbols are already
tberghammer added inline comments.
Comment at: include/lldb/Core/EmulateInstruction.h:390
@@ +389,3 @@
+typedef uint32_t InstructionCondition;
+static const InstructionCondition UnconditionalCondition = UINT32_MAX;
+
clayborg wrote:
> It is nice to tell
tberghammer updated this revision to Diff 46899.
tberghammer added a comment.
Update breakpoint opcodes based on review
http://reviews.llvm.org/D16853
Files:
source/Plugins/Platform/Linux/PlatformLinux.cpp
source/Plugins/Process/Linux/NativeProcessLinux.cpp
Index:
tberghammer accepted this revision.
tberghammer added a comment.
Looks reasonable
Comment at: packages/Python/lldbsuite/test/lldbtest.py:672-682
@@ -768,1 +671,13 @@
+
+def skipUnlessListedRemote(remote_list=None):
+def is_remote_unlisted(self):
+if remote_list and
tberghammer updated this revision to Diff 46764.
tberghammer added a comment.
Create a typedef for the condition type and a static const value for the
unconditional condition.
http://reviews.llvm.org/D16814
Files:
include/lldb/Core/EmulateInstruction.h
include/lldb/Symbol/UnwindPlan.h
tberghammer created this revision.
tberghammer added reviewers: clayborg, omjavaid.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Use BKPT instead of UDF for arm/thumb breakpoints
The UDF instruction is deprecated in armv7 and in case of thumb2
tberghammer accepted this revision.
tberghammer added a comment.
Looks reasonable and I agree with Pavel in the idea of moving the android
related utility functions into their own file for better separation
Comment at: packages/Python/lldbsuite/test/lldbplatformutil.py:73-81
Author: tberghammer
Date: Tue Feb 2 12:18:13 2016
New Revision: 259538
URL: http://llvm.org/viewvc/llvm-project?rev=259538=rev
Log:
[NFC] Cleanup RangeMap.h
The file contained very similar 4 implementation of the same data
structure with a lot of duplicated code and some minor API differences.
tberghammer created this revision.
tberghammer added reviewers: omjavaid, jasonmolenda, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, rengolin, aemerson.
Fix handling of the arm IT instruction in the unwinder
The IT instruction can
tberghammer added a comment.
UINT32_MAX is a kind of a random value what is most likely won't be used on any
architecture as a condition code (I can't imagine having so much different
condition flags) and my current intention is to map the unconditional value to
into it as it is already done
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259538: [NFC] Cleanup RangeMap.h (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16769?vs=46531=46673#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16769
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259509: Fix single stepping over the IT instruction
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16772?vs=46542=46647#toc
Repository:
rL LLVM
tberghammer added a comment.
In http://reviews.llvm.org/D16769#340936, @clayborg wrote:
> Looks fine. A few things I don't like, but I can live with:
>
> - Making constructors appear all on one line does save space, but it means
> you can't debug very well as stepping into these constructors
tberghammer added a comment.
In http://reviews.llvm.org/D16772#340950, @clayborg wrote:
> Looks good.
>
> A related comment about IT instructions. You need to be careful when software
> single stepping through instructions that are in the middle of an ITSTATE
> block. You can NOT use a 16 bit
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks reasonable but should we merge TestSingleStepOntoBreakpoint.py and
TestConsecutiveBreakpoints.py? I think they have quite a bit of code in common.
tberghammer created this revision.
tberghammer added reviewers: clayborg, labath.
tberghammer added a subscriber: lldb-commits.
[NFC] Cleanup RangeMap.h
The file contained very similar 4 implementation of the same data
structure with a lot of duplicated code and some minor API differences.
This
tberghammer added a comment.
I don't think using unicode strings everywhere is a good idea because when we
compare a string coming from the SB API with a string literal we don't want to
do a lot of conversion. Also I think enforcing all string literals to be
unicode is something what will
tberghammer created this revision.
tberghammer added reviewers: zturner, tfiala.
tberghammer added a subscriber: lldb-commits.
Re-submit rL258759: Write the session log file in UTF-8.
Previously we were writing in the default encoding, which depends
on the operating system and is not guaranteed
tberghammer added a comment.
I know that this version is not the cleanest implementation but I think this is
a very robust because we don't depend on the system encoding anywhere. Please
gave it a try and feel free to commit it if if works.
http://reviews.llvm.org/D16680
tberghammer added a comment.
The traceback calculation is done inside unittest2 so I think we shouldn't
change it and we don't have access to the session variable either.
http://reviews.llvm.org/D16680
___
lldb-commits mailing list
tberghammer added a comment.
I converted the strings it was complaining about but I haven't managed to get
the traceback printing working without converting the data to utf-8 manually.
We are using traceback.format_exception to collect the stack trace what returns
a string, then we store it in
Hi Omair,
Can you send me some logs about the failure you see for this test both on
arm and aarch64 Linux? The test is passing reliably on android both for arm
and aarch64 so I would like to understand what is the difference.
Thanks,
Tamas
On Wed, Jan 27, 2016 at 2:01 PM Omair Javaid via
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with a few nits inline
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:418
@@ +417,3 @@
+bool
+ABISysV_arm::IsArmHardFloat (Thread *thread) const
tberghammer added a comment.
In http://reviews.llvm.org/D16334#331428, @zturner wrote:
> In http://reviews.llvm.org/D16334#331420, @tberghammer wrote:
>
> > In http://reviews.llvm.org/D16334#331368, @zturner wrote:
> >
> > > I don't know, I still disagree. If something in step-over breaks, I
>
tberghammer added a comment.
Looks good to me and if Apple using this code then I am pretty sure my CL break
them as well. Having 0 size symbols around will cause a lot of issue around
LLDB.
http://reviews.llvm.org/D16415
___
lldb-commits mailing
I think to get a very good coverage for the basic functionalities we need
some sort of stress testing or fuzzing infrastructure because the most
issues I hit come from compilers generating something a bit different then
we are expecting. For stack unwinding I added a stress test
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
In http://reviews.llvm.org/D16334#331318, @zturner wrote:
> FWIW, I think Adrian's original point is that testing the behavior of signed
> types shouldn't depend on step over functionality. It's good practice in
>
tberghammer added a comment.
In http://reviews.llvm.org/D16334#331368, @zturner wrote:
> I don't know, I still disagree. If something in step-over breaks, I dont'
> want to dig through a list of 30 other tests that have nothing to do with the
> problem, only to find out 2 days later that the
Author: tberghammer
Date: Tue Jan 19 04:24:51 2016
New Revision: 258113
URL: http://llvm.org/viewvc/llvm-project?rev=258113=rev
Log:
Unconditionally accept symbol sizes from elf
The ELF symbol table always contain the size of the symbols so we
don't have to try to guess them based on the address
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D16107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: tberghammer
Date: Mon Jan 18 04:38:34 2016
New Revision: 258040
URL: http://llvm.org/viewvc/llvm-project?rev=258040=rev
Log:
Unconditionally accept symbol sizes from elf
The ELF symbol table always contain the size of the symbols so we
don't have to try to guess them based on the address
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258040: Unconditionally accept symbol sizes from elf
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D16186?vs=44981=45160#toc
Repository:
rL LLVM
Author: tberghammer
Date: Mon Jan 18 05:49:18 2016
New Revision: 258043
URL: http://llvm.org/viewvc/llvm-project?rev=258043=rev
Log:
Revert "Unconditionally accept symbol sizes from elf"
It causes issues for i386 when compiling with gcc-4.9.2
This reverts commit
tberghammer added inline comments.
Comment at: source/Symbol/Symtab.cpp:974-978
@@ -973,5 +973,7 @@
Symbol = m_symbols[entry.data];
-
-symbol.SetByteSize(end_section_file_addr -
symbol_file_addr);
-
tberghammer added a comment.
Yes it will prevent the artificial size calculation for symbols with 0 size in
.dynsym. I think all function and data symbols should have a valid size so I am
not sure why we have this symbol size calculation in the first place but I
assume it is to work around
I XFAIL-ed the test for Linux to get the build bot green again and filed a
bug at https://llvm.org/bugs/show_bug.cgi?id=26139
On Thu, Jan 14, 2016 at 2:18 AM Ying Chen via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Please see attached log file.
>
> Thanks,
> Ying
>
> On Wed, Jan 13,
Author: tberghammer
Date: Thu Jan 14 04:56:56 2016
New Revision: 257755
URL: http://llvm.org/viewvc/llvm-project?rev=257755=rev
Log:
XFAIL TestCommandScriptImmediateOutput on Linux
Modified:
Author: tberghammer
Date: Thu Jan 14 06:49:48 2016
New Revision: 257761
URL: http://llvm.org/viewvc/llvm-project?rev=257761=rev
Log:
Update some XFAILs after the 3.8->3.9 version change
Modified:
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Unconditionally accept symbol sizes from .dynsym
If an elf object file have no .symtab section then we create our symtab
representation based on the .dynsym section. The
Author: tberghammer
Date: Wed Jan 13 08:58:48 2016
New Revision: 257603
URL: http://llvm.org/viewvc/llvm-project?rev=257603=rev
Log:
Silence an incorrect dwarf parsing warning
We have a check what warns if the offset of a class member is greater
then or equal to the size of the class. The
tberghammer added a comment.
Based on your description the vdso file itself looks like a valid elf file to
me. If the ObjectFileELF plugin is buggy (it is certainly is as it can't handle
the vdso) then I think we should fix that instead of building up a new approach
just to work around one of
tberghammer added a comment.
Can we calculate the size of the object file based on elf headers and the
section headers instead of using the /proc file system?
I think a good algorithm would be to take the maximum of the following 2
expression:
Start of section header + Number of section
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257322: Make the aarch64 lldb-server capable of debugging
arm32 applications (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15533?vs=42987=44454#toc
Repository:
rL LLVM
Author: tberghammer
Date: Mon Jan 11 04:39:09 2016
New Revision: 257322
URL: http://llvm.org/viewvc/llvm-project?rev=257322=rev
Log:
Make the aarch64 lldb-server capable of debugging arm32 applications
Differential revision: http://reviews.llvm.org/D15533
Modified:
Author: tberghammer
Date: Mon Jan 11 08:56:05 2016
New Revision: 257335
URL: http://llvm.org/viewvc/llvm-project?rev=257335=rev
Log:
Don't try to parse the line table when it isn't specified
Previously we tried to parse the line table even if a compile unit
had no DW_AT_stmt_list atribute. The
tberghammer added a comment.
@omjavaid: What is your opinion about submitting this patch in its current form
with knowing that setting watchpoints from a 64bit lldb-server into 32bit
inferior will fail?
I think this patch is a step in the good direction to make a 64bit lldb-server
capable of
tberghammer accepted this revision.
tberghammer added a comment.
Looks good but please fix the indentation to match with the LLDB style (4 space)
http://reviews.llvm.org/D15877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1391
@@ -1390,3 +1390,3 @@
if
tberghammer added a comment.
LGTM
I can't accept it on the UI because of some bug, but you can commit it without
waiting for Greg.
Repository:
rL LLVM
http://reviews.llvm.org/D15738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tberghammer added a subscriber: tberghammer.
tberghammer requested changes to this revision.
tberghammer added a reviewer: tberghammer.
This revision now requires changes to proceed.
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2549-2550
@@ -2548,6 +2548,4 @@
Author: tberghammer
Date: Tue Dec 22 09:23:33 2015
New Revision: 256244
URL: http://llvm.org/viewvc/llvm-project?rev=256244=rev
Log:
Don't pack the structs of the jit debug interface
None of the documentation mentions that the entries are packed structs
and also none of the other implementation
tberghammer added a comment.
I hit the problem when debugging an arm32 target from an x86_64 host and this
CL fixes that issue. It will break if a 32bit target use the same "pragma pack"
attribute I just removed.
The change have no effect for 64bit targets because symfile_size will be 8 byte
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256244: Don't pack the structs of the jit debug interface
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15715?vs=43444=43445#toc
Repository:
rL LLVM
tberghammer created this revision.
tberghammer added reviewers: tfiala, endlessroad, loladiro.
tberghammer added a subscriber: lldb-commits.
Don't pack the structs of the jit debug interface
None of the documentation mentions that the entries are packed structs and also
none of the other
tberghammer added a comment.
I don't fully understand how the ptrace API works in the aarch64 Linux kernel
but based on my experiments the arm specific ptrace calls aren't working
(returning -EIO for a reason unknown to me at the moment). Because of this, the
current watchpoint implementation
Author: tberghammer
Date: Fri Dec 18 09:35:08 2015
New Revision: 256000
URL: http://llvm.org/viewvc/llvm-project?rev=256000=rev
Log:
Fix the emulation of arm strd instruction
The incorrect instruction emulation caused issues in the stack unwinding
code when strd was used to push 2 register to
tberghammer accepted this revision.
tberghammer added a comment.
LGTM (next time please upload the diff with full context)
Repository:
rL LLVM
http://reviews.llvm.org/D15576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tberghammer updated this revision to Diff 42987.
tberghammer added a comment.
Fix type
http://reviews.llvm.org/D15533
Files:
source/Host/common/HostInfoBase.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.h
tberghammer marked an inline comment as done.
tberghammer added a comment.
http://reviews.llvm.org/D15533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer added a comment.
Note: This change is blocked by http://reviews.llvm.org/D15529. If that one
will get rejected then we have to move some of the 32 <-> 64 architecture
matching code into LLDB.
Comment at:
tberghammer created this revision.
tberghammer added reviewers: omjavaid, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Make the aarch64 lldb-server capable of debugging arm32 applications
After this change
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255641: Merge ENABLE_THREADS and ENABLE_STD_THREADS markers
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15498?vs=42725=42832#toc
Repository:
rL LLVM
tberghammer added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:518
@@ +517,3 @@
+if hasattr(func, "categories"):
+cat.extend(func.categories)
+func.categories = cat
tfiala wrote:
> This code could potentially
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugMacro.cpp:38-41
@@ +37,6 @@
+
+if (flags & OPCODE_OPERANDS_TABLE_MASK)
+{
+OperandTable::ReadOperandTable(debug_macro_data, offset,
_operand_table);
+}
+
tberghammer created this revision.
tberghammer added reviewers: labath, zturner.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Merge ENABLE_THREADS and ENABLE_STD_THREADS markers
Both of these markers are used in the test suit for annotating when
tberghammer added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:518
@@ +517,3 @@
+if hasattr(func, "categories"):
+cat.extend(func.categories)
+func.categories = cat
labath wrote:
> tberghammer wrote:
> >
Hi Zachary,
This change broke TestLimitDebugInfo with the following error
message(copied from the Linux buildbot):
==
ERROR: test_limit_debug_info_dwarf
(TestWithLimitDebugInfo.TestWithLimitDebugInfo)
tberghammer added a comment.
I don't know what correction you are referring to as I haven't made any change
in JSON.{h,cpp} since you created this patch but I am happy with the current
situation (no warning on clang)
http://reviews.llvm.org/D15355
tberghammer added a comment.
The high level architecture looks reasonable but there are a few think I would
like you to clean up a bit:
- Several of your function uses a raw "new ...()" and then returns a pointer.
Please put the data into a smart pointer (usually std::unique_ptr) and return
Author: tberghammer
Date: Fri Dec 11 10:24:14 2015
New Revision: 255342
URL: http://llvm.org/viewvc/llvm-project?rev=255342=rev
Log:
Create test for llvm.org/pr25806
LLDB don't detect the loading of a shared object file linked against the
main executable before the static initializers are
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: packages/Python/lldbsuite/test/lldbtest.py:512
@@ -510,3 +511,3 @@
def add_test_categories(cat):
-"""Decorate an item with test categories"""
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255260: Add modules downloaded by ModuleCache to the global
ModuleList (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15415?vs=42422=42433#toc
Repository:
rL LLVM
Author: tberghammer
Date: Thu Dec 10 11:08:23 2015
New Revision: 255260
URL: http://llvm.org/viewvc/llvm-project?rev=255260=rev
Log:
Add modules downloaded by ModuleCache to the global ModuleList
Adding the modules to the global module list eleminate issues in the
case when a module is unloaded
tberghammer added inline comments.
Comment at: cmake/platforms/Android.cmake:124
@@ -123,1 +123,3 @@
+# Use gold linker and enable safe ICF in case of x86, x86_64 and arm
+if ( ANDROID_ABI STREQUAL "x86"OR
ovyalov wrote:
> Just out of curiosity - you
Author: tberghammer
Date: Thu Dec 10 05:02:51 2015
New Revision: 255240
URL: http://llvm.org/viewvc/llvm-project?rev=255240=rev
Log:
Switch to gold linker on android x86, x86_64, arm
These architectures already using the gold linker for the android
framework and switching to gold gives us the
Hi Aidan,
Next time please add a commit message describing the change itself (next to
the review link). In general I think copying the review title and the
summary into the commit message is a good baseline. It will help us
understand your change when somebody looking at git logs as we don't have
tberghammer requested changes to this revision.
tberghammer added a comment.
This revision now requires changes to proceed.
These GetAs{...} functions should never fail in their current implementation as
we have only 3 different data type and all of them are handled. The new
function signatures
tberghammer requested changes to this revision.
tberghammer added a comment.
This revision now requires changes to proceed.
We discussed the same change recently (http://reviews.llvm.org/D13866) and the
general opinion was that the original code have the right semantics and we
don't want to
tberghammer created this revision.
tberghammer added reviewers: labath, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Switch to gold linker on android x86, x86_64, arm
These architectures already using the
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Paul is not working on LLDB anymore so I added Siva who took over most of his
work.
Repository:
rL LLVM
http://reviews.llvm.org/D15312
___
lldb-commits mailing list
Author: tberghammer
Date: Tue Dec 8 07:43:59 2015
New Revision: 255014
URL: http://llvm.org/viewvc/llvm-project?rev=255014=rev
Log:
Add a new option to Platform::LoadImage to install the image
This change introduce 3 different working mode for Platform::LoadImage
depending on the file specs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255014: Add a new option to Platform::LoadImage to install
the image (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15152?vs=42055=42166#toc
Repository:
rL LLVM
Author: tberghammer
Date: Tue Dec 8 08:08:19 2015
New Revision: 255016
URL: http://llvm.org/viewvc/llvm-project?rev=255016=rev
Log:
Modify "platform connect" to connect to processes as well
The standard remote debugging workflow with gdb is to start the
application on the remote host under
Author: tberghammer
Date: Tue Dec 8 08:27:40 2015
New Revision: 255017
URL: http://llvm.org/viewvc/llvm-project?rev=255017=rev
Log:
Fix MSVC build after rL255016
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255016: Modify "platform connect" to connect to processes as
well (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D14952?vs=42063=42170#toc
Repository:
rL LLVM
201 - 300 of 552 matches
Mail list logo
