[Lldb-commits] [PATCH] D159542: Lazy deference underlying object for shared/weak/unique_ptr synthetic provider

yinghuitan abandoned this revision. yinghuitan added a comment. Abandon to use the github workflow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159542/new/ https://reviews.llvm.org/D159542 ___

[Lldb-commits] [PATCH] D159542: Lazy deference underlying object for shared/weak/unique_ptr synthetic provider

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. We

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

yinghuitan added a comment. Can you add a testcase for this? Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:768 +// hex string. +frame_name.clear(); +llvm::raw_string_ostream os(frame_name); I do not think this is needed?

[Lldb-commits] [PATCH] D156375: Fix lldb-vscode frame id integer overflow

This revision was automatically updated to reflect the committed changes. Closed by commit rGca849352936d: Fix lldb-vscode frame id integer overflow (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156375/new/

[Lldb-commits] [PATCH] D156375: Fix lldb-vscode frame id integer overflow

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49b3c3355f9c: [lldb][x86_64] Support fs_base/gs_base register in Linux (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

yinghuitan updated this revision to Diff 542292. yinghuitan added a comment. Use coredump fs_base/gs_base values from thread_crash test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/ https://reviews.llvm.org/D155256 Files:

[Lldb-commits] [PATCH] D155256: Add fs_base/gs_base support for Linux

yinghuitan updated this revision to Diff 541597. yinghuitan added a comment. Address review comments: - clang-format - Add coredump tests - Add test against gs_base register Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/

[Lldb-commits] [PATCH] D155256: Add fs_base/gs_base support for Linux

yinghuitan updated this revision to Diff 541272. yinghuitan edited the summary of this revision. yinghuitan added a comment. Revert x86_64 changes to reduce amount of changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

yinghuitan accepted this revision. yinghuitan added a comment. Can we wrap this as a helper function and shared to avoid duplication? Otherwise looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D150313: Fix libstdc++ data formatter for reference/pointer to std::string

This revision was automatically updated to reflect the committed changes. Closed by commit rG25159ee3af5c: Fix libstdc++ data formatter for reference/pointer to std::string (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150313: Fix libstdc++ data formatter for reference/pointer to std::string

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. LGTM. I have patched and verified this diff indeed fixed the performance issue in our internal service with 3000~4000 threads. Thanks for fixing it! Repository: rG LLVM Github

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

yinghuitan added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:376-386 +bool handled = llvm::any_of(m_processes, [&](NativeProcessLinux *process) { + return process->TryHandleWaitStatus(pid, status); +}); +if (!handled) {

[Lldb-commits] [PATCH] D145955: Refactor ObjectFilePlaceholder for sharing

This revision was automatically updated to reflect the committed changes. Closed by commit rG46c2e4c4f347: Refactor ObjectFilePlaceholder for sharing (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145955/new/

[Lldb-commits] [PATCH] D145955: Refactor ObjectFilePlaceholder for sharing

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

This revision was automatically updated to reflect the committed changes. Closed by commit rGb461398f1ce3: Add a new SBDebugger::SetDestroyCallback() API (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan updated this revision to Diff 502897. yinghuitan added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/ https://reviews.llvm.org/D143520 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D145203: Add HitCount into Breakpoint statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rG83263aeceb8e: Add HitCount into Breakpoint statistics (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145203/new/

[Lldb-commits] [PATCH] D145203: Add HitCount into Breakpoint statistics

yinghuitan created this revision. yinghuitan added reviewers: clayborg, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Turns out breakpoint statistics is missing hitCount.

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan updated this revision to Diff 497133. yinghuitan added a comment. Address review comments by using the same type for internal and public callbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adding a new

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

yinghuitan abandoned this revision. yinghuitan added a comment. Discussed offline. We can't rely on initialized event because it has to happen before all breakpoints are set. Will create a new design for htis. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D138589: Add runToBinaryEntry option for lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan added a comment. The test failure is fixed in https://reviews.llvm.org/D138536 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 ___ lldb-commits

[Lldb-commits] [PATCH] D138536: Fix TestVSCode_launch.py test failure

yinghuitan created this revision. yinghuitan added reviewers: clayborg, GeorgeHuyubo, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We changed the output to telemetry category but the test

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c16f89124f: Add runToBinaryEntry option for lldb-vscode (authored by yinghuitan). Changed prior to commit:

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

yinghuitan added a comment. Also, do you have any plan to record this happening in statistics dump so that our telemetry can report it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138259/new/ https://reviews.llvm.org/D138259

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

yinghuitan added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:600 + // no member variables or member functions will be available. + if (GetCompilerType().IsForcefullyCompleted()) { + destination = ""; Is this shown in lldb-vscode? If so,

[Lldb-commits] [PATCH] D137284: Override CalculateFrameVariableError in SymbolFileOnDemand

yinghuitan requested changes to this revision. yinghuitan added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Symbol/SymbolFileOnDemand.h:121 + lldb_private::Status + CalculateFrameVariableError(lldb_private::StackFrame )

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8995649afa: Add formatting support for VSCode logpoints message (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471676. yinghuitan added a comment. Add failure case testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files:

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471318. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files:

[Lldb-commits] [PATCH] D136890: [lldb-vscode] Don't call SBValue.GetError after generating a summary.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:143 +llvm::StringRef value = v.GetValue(); +llvm::StringRef summary = v.GetSummary(); +llvm::StringRef type_name = v.GetType().GetDisplayTypeName(); Sorry for the late

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 471314. yinghuitan added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files:

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:306 } + output.push_back('\n'); // Ensure log message has line break. g_vsc.SendOutput(OutputType::Console, output.c_str()); clayborg wrote: > I would still only push

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:29 +lldb::SBError BreakpointBase::AppendLogMessagePart(llvm::StringRef part, + bool is_expr) { + if (is_expr) {

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan updated this revision to Diff 470837. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https://reviews.llvm.org/D136697 Files:

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:52 logMessage_prefix = "This is log message for { -- " -# Trailing newline is needed for splitlines() -logMessage = logMessage_prefix + "{i

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG51effa57818b: Fix exception description in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan updated this revision to Diff 469376. yinghuitan added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.llvm.org/D136295 Files:

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan updated this revision to Diff 469374. yinghuitan added a comment. Directly raise signal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136295/new/ https://reviews.llvm.org/D136295 Files:

[Lldb-commits] [PATCH] D136295: Fix exception description in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There is a

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468593. yinghuitan added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files:

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468592. yinghuitan added a comment. Update message per feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files:

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan updated this revision to Diff 468591. yinghuitan added a comment. Use async model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135798/new/ https://reviews.llvm.org/D135798 Files:

[Lldb-commits] [PATCH] D135798: Add runToBinaryEntry option for lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

This revision was automatically updated to reflect the committed changes. Closed by commit rGef25a217266a: Prevent lldb-vscode tests from source lldbinit file (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135620/new/

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

yinghuitan updated this revision to Diff 466909. yinghuitan added a comment. Add comment per feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135620/new/ https://reviews.llvm.org/D135620 Files:

[Lldb-commits] [PATCH] D135620: Prevent lldb-vscode tests from source lldbinit file

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour, fixathon. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. I think @labath or anyone owns the ELF coredump debugging should take a look. I am surprised other major companies did not hit this issue. Otherwise, LGTM Repository: rG LLVM

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. LGTM pending Pavel's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5073ed5f929: Add auto source map deduce count statistics (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134483/new/

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

yinghuitan updated this revision to Diff 462298. yinghuitan added a comment. rebase and trigger linter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134483/new/ https://reviews.llvm.org/D134483 Files: lldb/include/lldb/Target/PathMappingList.h

[Lldb-commits] [PATCH] D134483: Add auto source map deduce count statistics

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds auto

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. Technical wise this patch looks good. One concern is that these error messages are user facing but we are making it favoring debugging, like skeleton DIE, showing the DIE offset

[Lldb-commits] [PATCH] D134252: Track .dwo/.dwp loading errors and notify user when viewing variables.

yinghuitan added a comment. Do you plan to detect missing dwp file from `SymbolFileDWARF::GetDwpSymbolFile()` as well? Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1755-1756 cu_die.GetAttributeValueAsString(dwarf_cu, DW_AT_comp_dir, nullptr);

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc9e6c52f3d8: Add auto deduce source map setting (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460973. yinghuitan added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files: lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460578. yinghuitan added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files:

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan added a comment. @clayborg, now I see you want to make this option true by default while full paths one to be optional. Then sure, it makes sense. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:225 + const bool case_sensitive =

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460270. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files:

[Lldb-commits] [PATCH] D133908: Add auto deduce source map setting

yinghuitan created this revision. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new "target.auto-deduce-source-map" setting. If enabled, this setting may auto deduce a

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan added a comment. @clayborg , it is my intention to make `target.auto-deduce-source-map` boolean flag ultimately working for both relative paths and two full paths (two full paths are really important for off build host debugging, e.g. dump or production debugging). In this patch, I

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValue.h:86-87 + // TODO: make this function pure virtual after implementing it in all + // child classes. + virtual llvm::json::Value ToJSON(const ExecutionContext *exe_ctx) {

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5f54751048b: Add SBDebugger::GetSetting() public APIs (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan updated this revision to Diff 459208. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan updated this revision to Diff 459120. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValueChar.h:34-37 +if (m_current_value != '\0') + return m_current_value; +else + return "(null)"; clayborg wrote: > Since this is actually a character, it should

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan marked an inline comment as done. yinghuitan added a comment. @jingham , @clayborg, thanks for the feedback. Seems like the major concern is creating a general GetSettings() API instead of API for each setting. I like and agree with this idea. Per the reading,

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting()/GetSettings() public APIs

yinghuitan updated this revision to Diff 458932. yinghuitan marked 11 inline comments as done. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files:

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan updated this revision to Diff 458809. yinghuitan added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan updated this revision to Diff 457046. yinghuitan added a comment. Herald added a subscriber: JDevlieghere. Re-diff with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files:

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new SBTarget::GetSourceMap() API

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan added a comment. > From Jim, First off, I am supportive of your project, this is a pain point > for some folks for sure. I am in favor of trying to automate "I built my > binaries with sources in one location but locally they are in another" > scenario. Great to hear that! Seems

[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

yinghuitan added a comment. Change looks good to me. I will let @jingham take a second look before accepting. I do wonder if there will be more unexpected signals (like SIGCHILD, SIGPIPE etc...) causing expression evaluation to pause? Should we maybe default to not stop on signals?

[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1939-1950 + uint32_t addr_size = frame.GetThread().GetProcess().GetAddressByteSize(); + const uint32_t num_reg_sets = g_vsc.variables.registers.GetSize(); + for (uint32_t reg_set_idx=0;

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan added a comment. @jingham, thanks for sharing the thoughts. > Setting the breakpoint search to only check base names will of course make > all your file and line breakpoints work, but they will also pick up extra > hits. In command line lldb that doesn't look nearly as weird as

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan updated this revision to Diff 442973. yinghuitan added a comment. Remove unnecessary format changes caused by IDE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129307/new/ https://reviews.llvm.org/D129307 Files:

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some build system

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. @cmtice, are you sure the failure is caused by/related with this patch? This is a pure lldb-vscode change which is not used by normal lldb. Also, no mention of code in this patch in the error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128234: Fix build break introduced by https://reviews.llvm.org/D127702

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5109de2da2e2: Fix build break introduced by https://reviews.llvm.org/D127702 (authored by yinghuitan). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. Fixed in https://reviews.llvm.org/D128234 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128234: Fix build break introduced by https://reviews.llvm.org/D127702

yinghuitan created this revision. yinghuitan added reviewers: clayborg, thakis, kazu. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix build break introduced by https://reviews.llvm.org/D127702

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. Sorry, I was fooled by the buildbot which says everything is green. Working on a fix for the build break now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c6e138aa893: Support logpoints in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan updated this revision to Diff 438448. yinghuitan added a comment. Using a single structured LogMessagePart per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 Files:

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:60 +[loop_line, after_loop_line], +[{'logMessage': logMessage}, {}] +)

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch

[Lldb-commits] [PATCH] D126225: Fix lldb-vscode frame test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1d490319a9e: Fix lldb-vscode frame test failure (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126225/new/

[Lldb-commits] [PATCH] D126225: Fix lldb-vscode frame test failure

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, kusmour, aadsm. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previous patch

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fe220a33179: Show error message for optimized variables (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG46c1f77e160a: Add [opt] suffix to optimized stack frame in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126013/new/

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan updated this revision to Diff 431008. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126013/new/ https://reviews.llvm.org/D126013 Files:

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:762 + } else { +EmplaceSafeString(object, "name", frame.GetFunctionName()); + } clayborg wrote: > We should probably get the function name with "const char *func_name = >

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, aadsm. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an issue

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To help user identify optimized code

[Lldb-commits] [PATCH] D124499: Rename conflict testcase

yinghuitan abandoned this revision. yinghuitan added a comment. Seems that this is a duplication to Pavel Labath's commit f513b5fc47df5c040a257ab6f4643942828fa610 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

  1   2   >