[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh added a comment. In D106355#2913605 , @jankratochvil wrote: > You can also consider coding `lldb-add-index` for better performance as that > is too much for my available time. I don't think that I'll get to it either. But we'll also evaluate

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. You can also consider coding `lldb-add-index` for better performance as that is too much for my available time. In D106355#2909462 , @kimanh wrote: > Otherwise, could you help me to land this change (since I do not have

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e9853e0e9ff: [DWARF5] Only fallback to manual index if no entry was found (authored by kimanh, committed by jankratochvil). Repository: rG LLVM

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh marked an inline comment as not done. kimanh added a comment. Thanks once more for reviewing! If I should rename the variable (or anything else), let me know! Otherwise, could you help me to land this change (since I do not have committer rights)? Comment at:

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh updated this revision to Diff 362287. kimanh marked an inline comment as done. kimanh added a comment. Remove braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106355/new/ https://reviews.llvm.org/D106355 Files:

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. Approved after removing the curly brackets. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:136 continue; if

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. In D106355#2903655 , @kimanh wrote: > Ah, to make sure that I understand it correctly: using `gdb-add-index` would > help `ManualDWARFIndex` to generate a `.debug_names`? No. One could write hypothetical `lldb-add-index`

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh added a comment. > If you do not want to debug those libraries cannot you just strip debug info > from them (`llvm-strip -g`)? Oh, stripping debug info may work. We're on the Chrome DevTools team and we're working on a DWARF-based debugging extension for C/C++. Ideally we'd like to

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. In D106355#2896117 , @kimanh wrote: > In our case we have some third-party libraries that were not built by us, and > therefore they don't have any name index. Our main focus, is however, not to > debug those third party

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh added a comment. Thanks for having a look at the CL! In D106355#2893959 , @jankratochvil wrote: > Is it really just a microoptimization or can you measure any improvement? > That `ManualDWARFIndex::Index` will be called is expected. But there

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. Is it really just a microoptimization or can you measure any improvement? That `ManualDWARFIndex::Index` will be called is expected. But there should be `m_units_to_avoid` covering all the units so it will quickly return without indexing anything: if

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh created this revision. Herald added a subscriber: arphaman. kimanh updated this revision to Diff 360084. kimanh added a comment. kimanh retitled this revision from "[Index] Only fallback to manual index if no entry was found" to "[DWARF5] Only fallback to manual index if no entry was