[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGeee887e03551: [lldb/test] Print build commands in trace mode (authored by labath). Changed prior to

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/test/API/test_utils/TestBaseTest.py:1 +""" +Test TestBase test functions. teemperor wrote: > Could we move this file into `test_utils/build` or some other subdir? Then I >

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks everyone. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112212/new/ https://reviews.llvm.org/D112212

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath added a comment. In D112212#3083194 , @teemperor wrote: > Given that `shlex.join` is only used for making the diagnostics copy-pastable > into the terminal, we could probably get away by just making it use the > normal string conversion of list

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

teemperor added a comment. Given that `shlex.join` is only used for making the diagnostics copy-pastable into the terminal, we could probably get away by just making it use the normal string conversion of list or something like `" ".join(...)`. I don't think we have anyone that really debugs

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

dblaikie added a comment. In D112212#3082352 , @JDevlieghere wrote: > In D112212#3081935 , @dblaikie > wrote: > >> In D112212#3081828 , @JDevlieghere >> wrote: >> >>>

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

JDevlieghere added a comment. In D112212#3081935 , @dblaikie wrote: > In D112212#3081828 , @JDevlieghere > wrote: > >> In D112212#3080491 , @teemperor >> wrote: >> >>>

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

dblaikie added a comment. In D112212#3081828 , @JDevlieghere wrote: > In D112212#3080491 , @teemperor > wrote: > >> This LGTM, but `shlex.join` is actually Py3 exclusive and I don't think >> there is a good

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

JDevlieghere added a comment. In D112212#3080491 , @teemperor wrote: > This LGTM, but `shlex.join` is actually Py3 exclusive and I don't think there > is a good Py2 replacement. I think we're just in time for the Py2->3 > migration according to the

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

teemperor added a comment. This LGTM, but `shlex.join` is actually Py3 exclusive and I don't think there is a good Py2 replacement. I think we're just in time for the Py2->3 migration according to the timeline Jonas posted last year

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath added a comment. I agree with what Raphael said. Here's my attempt at a test case. Let me know what you think. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1422 +def runBuildCommands(self, commands): +for cmd in commands: +

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath updated this revision to Diff 381500. labath added a comment. - support single command only - add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112212/new/ https://reviews.llvm.org/D112212 Files:

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

teemperor added a comment. In D112212#3078681 , @dblaikie wrote: > Does this sort of thing itself get tested? (like this one had a test: > https://reviews.llvm.org/D111978 but not sure how much that > generalizes/whether there are different parts of

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

dblaikie added a comment. Does this sort of thing itself get tested? (like this one had a test: https://reviews.llvm.org/D111978 but not sure how much that generalizes/whether there are different parts of the infrastructure are more or less testable) Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1422 +def runBuildCommands(self, commands): +for cmd in commands: +self.trace(shlex.join(cmd)) Is this ever going to have more than one

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1284 compiler = self.getCompilerBinary() -version_output = system([[compiler, "--version"]]) -for line in version_output.split(os.linesep): -m =

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath updated this revision to Diff 381223. labath added a comment. Respond to reviewer comments (thanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112212/new/ https://reviews.llvm.org/D112212 Files:

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1284 compiler = self.getCompilerBinary() -version_output = system([[compiler, "--version"]]) -for line in

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1425 +try: +proc = run(cmd, stdin=DEVNULL, stdout=PIPE, stderr=STDOUT, +check=True) PSA: this function is available from

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

labath created this revision. labath added reviewers: teemperor, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. Running tests with -t prints all lldb commands being run. It makes sense to print all the build commands as well. Repository: rG LLVM Github