[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc22c7a61b6d9: [lldb] Fix platform selection on Apple Silicon (again) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 415211. JDevlieghere added a comment. Fix typo(s) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 415204. JDevlieghere added a comment. Herald added a subscriber: mgorny. Add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

labath added a comment. I don't suppose we could have a (gdb-client?) test for some of this stuff? Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:158 +// tell them apart and mark the host platform as compatible or not. +if (host_arch.IsValid()) { +

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 414722. JDevlieghere added a comment. Check the host architecture in PlatformMacOSX CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere added a comment. In D121444#3375701 , @labath wrote: > In D121444#3375445 , @JDevlieghere > wrote: > >> In D121444#3374854 , @labath wrote: >> I wish I

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

labath added a comment. In D121444#3375445 , @JDevlieghere wrote: > In D121444#3374854 , @labath wrote: > >>> I wish I could make this distinction in the platform, but you need a >>> connected process to do

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere added a comment. In D121444#3374854 , @labath wrote: >> I wish I could make this distinction in the platform, but you need a >> connected process to do this. > > Basically, what you're saying is that the ArchSpec alone is not sufficient to

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

labath added a comment. > I wish I could make this distinction in the platform, but you need a > connected process to do this. Basically, what you're saying is that the ArchSpec alone is not sufficient to select the right platform. Instead of punching right through the layers, could we just

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 414590. JDevlieghere added a comment. Include TargetConditionals.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, friss, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch is another attempt to fix platform selection on Apple Silicon. It partially undoes D117340