[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. Thanks for reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45975cbf96a: [LLDB][NativePDB] Create inline function decls (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good thanks. I didn't really check the pdb code, but it looks like @rnk already reviewed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/inline_sites_live.cpp:7 +// RUN: %p/Inputs/inline_sites_live.lldbinit 2>&1 | FileCheck %s + +inline int bar(int bar_param) { labath wrote: > ``` > void __attribute__((optnone))

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 419521. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update live debugging test to build with no optimization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

labath added a comment. In D121967#3403886 , @zequanwu wrote: >> Can you say (in english) what are the properties that you are trying to >> check there? Maybe we can find a better way to do that... > > I'm trying to check for local variables values in

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 418094. zequanwu added a comment. - change live debugging test to cpp file. - mirror fix on previous change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files:

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. > Can you say (in english) what are the properties that you are trying to check > there? Maybe we can find a better way to do that... I'm trying to check for local variables values in inline functions by printing them (see inline comment on

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

labath added a comment. In D121967#3400827 , @zequanwu wrote: >> I'd consider writing the live test case in c++ (with judicious use of >> always_inline, noinline, etc. attributes) > > I think it's better to just add live test case on compiled

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1124 + // Inlinee is the id index to the function id record that is inlined. + PdbTypeSymId func_id(inline_site.Inlinee, true); + // Look up the function decl by the id

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417701. zequanwu marked an inline comment as done. zequanwu added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files:

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1124 + // Inlinee is the id index to the function id record that is inlined. + PdbTypeSymId func_id(inline_site.Inlinee, true); + // Look up the function decl by the id index to

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1155 + TypeDeserializer::deserializeAs(parent_cvt, sir)); + parent = GetOrCreateNamespaceDecl(sir.String.data(), *parent); +} rnk wrote: >

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417432. zequanwu marked 5 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files:

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1123 + + PdbTypeSymId func_id(inline_site.Inlinee, true); + if (clang::Decl *decl = TryGetDecl(func_id)) Please add a comment about what the inlinee is, and what

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417419. zequanwu added a comment. Fix test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. > I'd consider writing the live test case in c++ (with judicious use of > always_inline, noinline, etc. attributes) I think it's better to just add live test case on compiled `inline_sites.s` so the test result is not influenced by optimization change.

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417414. zequanwu added a comment. Use `cast` instead of `dyn_cast`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files:

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417413. zequanwu marked an inline comment as done. zequanwu added a comment. - Split the inline_sites.s test into two. One for live testing on windows, another one for all platforms. - Fix wrong variable address range when there are gaps. Repository: rG

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

labath added a comment. I don't know much about PDBs, but overall, the patch seems fine to me. In D121967#3393556 , @zequanwu wrote: > I think adding a live debugging test case is necessary. I found several bugs > when working on this via live

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. I think adding a live debugging test case is necessary. I found several bugs when working on this via live debugging the compiled `inline_sites.s` and printing variables, and those bugs were not revealed by `image lookup`. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 416621. zequanwu added a comment. Fixing bugs and refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files:

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This creates inline functions decls in the TUs where the funcitons are inlined. Repository: rG LLVM Github Monorepo