[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGae016e4f7c85: [lldb] Dont swallow crashlog exceptions (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

mib accepted this revision. mib added inline comments. This revision is now accepted and ready to land. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return mib wrote: > What

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1025-1027 -except Exception as e: -result.PutCString("error: python exception: %s" % e) -return What about printing the exception backtrace and exiting cleaning instead

[Lldb-commits] [PATCH] D125589: [lldb] Don't swallow crashlog exceptions

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. crashlog.py catches every exception in order to format them. This results in both the exception name as well as the backtrace getting swallowed.