[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. In D128612#4349291 , @asb wrote: > In D128612#4349259 , @djtodoro > wrote: > >> In D128612#4345912 , @asb wrote: >> >>> In D128612#4337037

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. In D128612#4349259 , @djtodoro wrote: > In D128612#4345912 , @asb wrote: > >> In D128612#4337037 , @djtodoro >> wrote: >> >>> Hi! I am wondering if

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. In D128612#4345912 , @asb wrote: > In D128612#4337037 , @djtodoro > wrote: > >> Hi! I am wondering if someone knows what is the status of this. > > I've not seen any further progress. I

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM),

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. Herald added a subscriber: luke. Hi! I wondering if someone knows what is the status of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM),

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei updated this revision to Diff 441410. gbenyei added a comment. Removed LLD and JIT related parts - JIT is out of my scope, and LLD will be in an additional patch. Fixed additional remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei marked 3 inline comments as done. gbenyei added inline comments. Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:554 .buildGraph(); - } else { -assert((*ELFObj)->getArch() == Triple::riscv32 && - "Invalid triple for RISCV ELF object

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:144 + +StringRef LayoutEndianness = Triple.isLittleEndian() ? "e" : "E"; + gbenyei wrote: > MaskRay wrote: > > You may use a `char` and possibly fold this into the expression below. >

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei marked 3 inline comments as done. gbenyei added a comment. In D128612#3620911 , @MaskRay wrote: > In D128612#3618167 , @gbenyei wrote: > >> In D128612#3617955 ,

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

MaskRay added a comment. In D128612#3618167 , @gbenyei wrote: > In D128612#3617955 , @MaskRay wrote: > >> lld/ELF change should be dropped from this change. Don't use >> `config->endianness`. >> I feel sad that

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei added a comment. In D128612#3617906 , @jhenderson wrote: > Objcopy aspects look good, thanks. Thanks Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:554 .buildGraph(); - } else { -

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei added a comment. In D128612#3617955 , @MaskRay wrote: > lld/ELF change should be dropped from this change. Don't use > `config->endianness`. > I feel sad that for little-endian users who don't use big-endian, every write > now is slightly

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

jhenderson added a comment. Objcopy aspects look good, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

MaskRay added a comment. lld/ELF change should be dropped from this change. Don't use `config->endianness`. I feel sad that for little-endian users who don't use big-endian, every write now is slightly slower due to a check ;-) Comment at:

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei updated this revision to Diff 440579. gbenyei marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 Files: clang/include/clang/Basic/Attr.td

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

jrtc27 added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:113 +if (Triple.isLittleEndian()) + resetDataLayout("e-m:e-p:32:32-i64:64-n32-S128"); +else And please avoid repeating the whole data layout, just make the e/E a variable

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

jhenderson added inline comments. Comment at: llvm/include/llvm/ADT/Triple.h:864 /// Tests whether the target is RISC-V (32- and 64-bit). bool isRISCV() const { Perhaps worth updating to mention big and little endian here, like `isPPC64` above?

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:111 SizeType = UnsignedInt; -resetDataLayout("e-m:e-p:32:32-i64:64-n32-S128"); } Instead of creating new classes, could we have a branch on the Arch or isLittleEndian

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei updated this revision to Diff 440196. gbenyei added a comment. Thanks, Craig. Updated the patch with your remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 Files:

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei created this revision. gbenyei added a reviewer: asb. gbenyei added projects: clang, LLVM, lld. Herald added subscribers: Enna1, sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, ormris, jocewei, PkmX, the_o, brucehoult,