[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

mstorsjo added a comment. FYI, this change caused a strange regression for reading PDB files in i386 mode, when LLDB is built in mingw mode (not when it is built in MSVC mode), see https://github.com/llvm/llvm-project/issues/57799 for details. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rG71d778f33e86: [LLDB][NativePDB] Switch to use DWARFLocationList. (authored by zequanwu). Changed prior to commit:

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

rnk accepted this revision. rnk added a comment. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130796/new/ https://reviews.llvm.org/D130796 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu updated this revision to Diff 452031. zequanwu added a comment. - Add missing test case for simple type because subfield_register_simple_type.s is deleted, forgot to add it before. - Address rnk's comment by only accepting subfield locations that are on register, because we don't have

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if (!FindMembersSize::GetMemberSizesForUdt(result.type, index.tpi(), 0, +

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp:843-846 +std::map offset_to_size; +// Get the size of each fields if it's udt. +if (!FindMembersSize::GetMemberSizesForUdt(result.type, index.tpi(), 0, +

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Utility/RangeMap.h:54 +base += s; +size -= size > s ? s : size; + } `std::min(s, size)`? Repository: rG LLVM

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu updated this revision to Diff 450408. zequanwu added a comment. - Recurse into parent classes when filling the offset to size map. - Previously the range parsed earlier is preferred, now it's the range parsed later is preferred, since it makes the code cleaner and it doesn't really

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. In D130796#3696351 , @labath wrote: > In D130796#3692243 , @zequanwu > wrote: > >> In D130796#3691227 , @zequanwu >> wrote: >> If you

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

labath added a comment. In D130796#3692243 , @zequanwu wrote: > In D130796#3691227 , @zequanwu > wrote: > >>> If you find yourself needing to do extra work to work its limitations, we >>> should fix that

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. In D130796#3691227 , @zequanwu wrote: >> If you find yourself needing to do extra work to work its limitations, we >> should fix that algorithm instead. > > That makes sense. I'll work on fixing `RangeVectorData`. After

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. > If you find yourself needing to do extra work to work its limitations, we > should fix that algorithm instead. That makes sense. I'll work on fixing `RangeVectorData`. Comment at: lldb/source/Expression/DWARFExpressionList.cpp:37-39 + if

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

labath added a comment. The general idea makes sense to me, although I haven't tried to understand the pdb parsing code. > (otherwise internal binary search may fail) The current search algorithm is buggy, but I think the `RangeDataVector` class has always intended to support overlapping

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before, NativePDB uses scoped range as a workaround for value range, that causes problems (e.g. a variable's value can