This revision was automatically updated to reflect the committed changes.
Closed by commit rGbb4ccc668889: [lldb] Add ScriptedPlatform python
implementation (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139250/new/
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the
mib updated this revision to Diff 488485.
mib marked an inline comment as done.
mib added a comment.
Address @labath comments:
- Rephrase documentation to remove any `Scripted Process` occurrence
- Add `attach_to_process` affordance to python `Scripted Platform` class
CHANGES SINCE LAST ACTION
mib marked 5 inline comments as done.
mib added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
labath wrote:
> mib
labath added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:64
+def launch_process(self, launch_info):
+""" Launch a scripted process.
+
Does this really have to be a scripted process? Ideally, one could also
mib updated this revision to Diff 488004.
mib edited the summary of this revision.
mib added a comment.
Address @JDevlieghere comment:
- refactor SWIG scripted object create methods into a single one
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139250/new/
mib added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
labath wrote:
> mib wrote:
> > labath wrote:
> > > mib
labath added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
mib wrote:
> labath wrote:
> > mib wrote:
> > > labath
JDevlieghere added a comment.
I'm happy with the launching/attaching discussion resolved. Similar to the
deduplication I think it makes more sense to tackle that first instead of
landing this "as is" and then fixing it after the fact.
Comment at:
mib added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
labath wrote:
> mib wrote:
> > labath wrote:
> > > mib
labath added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
mib wrote:
> labath wrote:
> > mib wrote:
> > > mib
mib added a comment.
ping @JDevlieghere
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139250/new/
https://reviews.llvm.org/D139250
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
mib updated this revision to Diff 483509.
mib added a comment.
Update comments for `scripted_platform.list_processes`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139250/new/
https://reviews.llvm.org/D139250
Files:
lldb/bindings/python/CMakeLists.txt
mib added inline comments.
Comment at: lldb/bindings/python/python-wrapper.swig:317
+PythonObject lldb_private::LLDBSwigPythonCreateScriptedPlatform(
+const char *python_class_name, const char *session_dictionary_name,
JDevlieghere wrote:
> This looks
mib marked 3 inline comments as done.
mib added a subscriber: jingham.
mib added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
labath added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
mib wrote:
> mib wrote:
> > mib wrote:
> > > labath
mib marked 2 inline comments as done.
mib added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:33
+
+processes = {
+420: {
bulbazord wrote:
> JDevlieghere wrote:
> > Why is this method implemented and
bulbazord added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:33
+
+processes = {
+420: {
JDevlieghere wrote:
> Why is this method implemented and not a `pass` like the others?
This method is not
JDevlieghere added inline comments.
Comment at: lldb/bindings/python/python-wrapper.swig:317
+PythonObject lldb_private::LLDBSwigPythonCreateScriptedPlatform(
+const char *python_class_name, const char *session_dictionary_name,
This looks pretty similar to
mib added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
mib wrote:
> mib wrote:
> > labath wrote:
> > > I am
mib added a comment.
ping @JDevlieghere
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
mib wrote:
> labath wrote:
> > I am
mib added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
labath wrote:
> I am surprised that you want to go down
labath added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31
+def list_processes(self):
+""" Get a list of processes that can be ran on the platform.
+
I am surprised that you want to go down the "run" path
mib updated this revision to Diff 481844.
mib marked 3 inline comments as done.
mib added a comment.
Address @bulbazord comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139250/new/
https://reviews.llvm.org/D139250
Files:
lldb/bindings/python/CMakeLists.txt
mib added inline comments.
Comment at: lldb/examples/python/scripted_process/scripted_platform.py:43-46
+Dict: The processes represented as a dictionary, with at least the
+process ID, name, architecture. Optionally, the user can also
+
bulbazord added inline comments.
Comment at: lldb/bindings/python/python-wrapper.swig:353-354
+ } else {
+error_string.assign("wrong number of arguments in __init__, should be 2 "
+"(not including self)");
+ }
I think the error
mib updated this revision to Diff 479809.
mib added a comment.
Fix typo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139250/new/
https://reviews.llvm.org/D139250
Files:
lldb/bindings/python/CMakeLists.txt
lldb/bindings/python/python-wrapper.swig
mib created this revision.
mib added reviewers: JDevlieghere, bulbazord.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch introduces both the Scripted Platform python base
implementation and an
28 matches
Mail list logo
