[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-27 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. Thanks, regarding sve from Linux headers, LLVM currently supports building with GCC 7.1 or clang 5.0 and both were released in 2017. SVE support in Linux kernel believe was added in Linux kernel 4.19 timeframe iso maybe late 2018. If SVE needs to be built from

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-27 Thread Manoj Gupta via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5f35e24f4c: lldb: Fix usage of sve functions on arm64 (authored by manojgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148752/new/

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-26 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. In D148752#4283899 , @manojgupta wrote: > I am building on ChromeOS. We only have headers from linux kernel 4.14 > available in our build system (The actual running kernel could be a higher > version). > But given these

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-24 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett edited reviewers, added: omjavaid; removed: DavidSpickett. DavidSpickett added a comment. I don't know enough to approve, Omair is the expert here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148752/new/

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-21 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. Are there any objecttions? This patch is only making a consistent use of pre-existing and already in-use APIs/struct defintions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148752/new/

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-20 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta added a comment. I am building on ChromeOS. We only have headers from linux kernel 4.14 available in our build system (The actual running kernel could be a higher version). But given these functions/struct definitions (sve::) are already available and used, why are they not used

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-19 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. HI Manoj Which linux distro are you using for your cross build? I am wondering which version of gcc (aarch64-linux-gnu) are you using for your cross compilation build. I believe sve headers are not defined in older versions of gcc or its packaged sysroot causing cross

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

2023-04-19 Thread Manoj Gupta via Phabricator via lldb-commits
manojgupta created this revision. Herald added subscribers: ctetreau, omjavaid, kristof.beyls, tschuett. Herald added a project: All. manojgupta requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Use correct internal sve functions for arm64.