This revision was automatically updated to reflect the committed changes.
Closed by commit rGbfb7c99f3aea: [LLDB] Add a hook to notify REPLs that an
expression was evaluated (authored by wallace).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
wallace added inline comments.
Comment at: lldb/include/lldb/Expression/REPL.h:124
+const lldb::ValueObjectSP _valobj_sp,
+const Status ) {
+return llvm::Error::success();
bulbazord wrote:
> Do you still need
bulbazord added inline comments.
Comment at: lldb/include/lldb/Expression/REPL.h:124
+const lldb::ValueObjectSP _valobj_sp,
+const Status ) {
+return llvm::Error::success();
Do you still need the `Status`
wallace updated this revision to Diff 519163.
wallace added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149719/new/
https://reviews.llvm.org/D149719
Files:
lldb/include/lldb/Expression/REPL.h
wallace added inline comments.
Comment at: lldb/include/lldb/Expression/REPL.h:115-120
+ virtual void
+ OnExpressionEvaluated(const ExecutionContext _ctx, llvm::StringRef code,
+const EvaluateExpressionOptions _options,
+
bulbazord added inline comments.
Comment at: lldb/include/lldb/Expression/REPL.h:115-120
+ virtual void
+ OnExpressionEvaluated(const ExecutionContext _ctx, llvm::StringRef code,
+const EvaluateExpressionOptions _options,
+
wallace created this revision.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
REPL implementations don't have an easy way to know that an expression has been
evaluated, so I'm adding a simple function
