JDevlieghere reopened this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157137/new/
https://reviews.llvm.org/D157137
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rG706e875da3a2: [lldb/crashlog] Skip images with empty path
and 0 UUID from loading (authored by mib).
Changed prior to commit:
https://reviews.llvm.org/D157137?vs=549560&id=549580#toc
Repository:
rG L
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157137/new/
https://reviews.llvm.org/D157137
___
lldb-commits mailing list
lldb-c
mib updated this revision to Diff 549560.
mib added a comment.
Address @bulbazord comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157137/new/
https://reviews.llvm.org/D157137
Files:
lldb/examples/python/symbolication.py
Index: lldb/examples/python/symbolication.py
=
bulbazord added inline comments.
Comment at: lldb/examples/python/symbolication.py:413-418
name = os.path.basename(self.path)
+if not name:
+if self.uuid == uuid.UUID(int=0):
+return None
+
mib created this revision.
mib added reviewers: JDevlieghere, bulbazord.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch skips images with an empty path or a 0 UUID from loading as a
SymbolFileJSON.
