[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77374d3b53ce: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC) (authored by mib). Changed prior to commit:

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158833/new/ https://reviews.llvm.org/D158833 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

mib updated this revision to Diff 554991. mib marked an inline comment as done. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158833/new/ https://reviews.llvm.org/D158833 Files:

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

bulbazord added a comment. In D158833#4626023 , @mib wrote: > In D158833#4625775 , @bulbazord > wrote: > >> Re-organizing the paths seems okay to me, especially since this is going to >> grow further. I think

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

mib added a comment. In D158833#4625775 , @bulbazord wrote: > Re-organizing the paths seems okay to me, especially since this is going to > grow further. I think the header guards are going to need some adjustment > though. TBH, I didn't even know

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

bulbazord added a comment. Re-organizing the paths seems okay to me, especially since this is going to grow further. I think the header guards are going to need some adjustment though. Comment at: lldb/include/lldb/Interpreter/Interfaces/ScriptedProcessInterface.h:9

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

mib created this revision. mib added reviewers: JDevlieghere, jingham, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. As we're consolidating and streamlining the various scripting affordances of