This revision was automatically updated to reflect the committed changes.
Closed by commit rL316532: Allow ObjectFilePECOFF to initialize with ARM
binaries. (authored by sas).
Repository:
rL LLVM
https://reviews.llvm.org/D19604
Files:
lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePE
sas updated this revision to Diff 120146.
sas added a comment.
Herald added a subscriber: kristof.beyls.
Rebase.
https://reviews.llvm.org/D19604
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
sas updated this revision to Diff 63542.
sas added a comment.
Use arm-pc-windows intead of armv7-pc-windows.
http://reviews.llvm.org/D19604
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
==
rengolin added a comment.
In http://reviews.llvm.org/D19604#421086, @omjavaid wrote:
> Right now we can distingusih between hard and soft float based on ABI
> information in elf. But cant really tell if hard float is legacy VFP or neon.
If the object has build attributes, it could help. But yo
omjavaid added a comment.
In case of ELF .arm attributes contains tags providing information on
underlying CPU specification used. Thats only for the inferior being debugged
but actually knowing which target we are running on, like for example if we
want to figure out if we are running on a arm
rengolin added a comment.
In http://reviews.llvm.org/D19604#420681, @jasonmolenda wrote:
> fwiw, there are ARM cores that only support thumb - the Cortex M series.
And they're still "armv7". :)
Remember, "armv7" is *not* the same as ARMv7A+NEON. If the only thing you have
is "armv7" or even "
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
fwiw, there are ARM cores that only support thumb - the Cortex M series. I
doubt a windows phone is running one of those low-power chips though. The
importance of the triple used will come in to play when you try to e
rengolin added a comment.
In http://reviews.llvm.org/D19604#419284, @sas wrote:
> - We don't use thumb-* triples in lldb as far as I can see. Thumb is handled
> just fine regardless of the triple.
This is a good strategy. Thumb is an instruction set, the "arm-" in the triple
means the Archite
omjavaid added a comment.
@sas
Ideally it should be thumb-* if an environment is thumb only but lldb right now
has some areas where we need to handle this case.
Either you put arm-* and leave it for someone else to correct the problems or
put thumb-* and fix the issues that come up after that.
compnerd added a comment.
The few lines above are for the x86, x86_64 targets, which traditionally use
the pc vendor as a legacy label.
http://reviews.llvm.org/D19604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/c
sas added a comment.
@compnerd:
- We don't use thumb-* triples in lldb as far as I can see. Thumb is handled
just fine regardless of the triple.
- `pc` vs `unknown` doesn't seem to matter either, and other code in this file
uses `pc` (see a few lines above).
- `msvc` vs `itanium` is also handle
omjavaid requested changes to this revision.
omjavaid added a comment.
This revision now requires changes to proceed.
Please see inline comments.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:149
@@ +148,3 @@
+{
+spec.SetTr
compnerd accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:149
@@ +148,3 @@
+{
+spec.SetTriple("armv7-pc-windows");
+specs.Append(Module
rengolin added reviewers: omjavaid, compnerd.
rengolin added a comment.
Nice! LLDB on ARM Windows! :)
Adding Omair and Saleem to approve, as hard-coding the triple may bring
unwanted consequences.
http://reviews.llvm.org/D19604
___
lldb-commits ma
sas created this revision.
sas added a reviewer: zturner.
sas added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This is required to start debugging WinPhone ARM targets.
http://reviews.llvm.org/D19604
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
I
15 matches
Mail list logo
