[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-12 Thread Chris Bieneman via lldb-commits
beanz added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:676-677 # If not found, disable the lldb-mi tests -lldbMiExec = None -if lldbtest_config.lldbExec and is_exe(lldbtest_config.lldbExec + "-mi"): -lldbMiExec =

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284041: Fix lookup path for lldb-mi (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25486?vs=74292=74429#toc Repository: rL LLVM https://reviews.llvm.org/D25486 Files:

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-12 Thread Ilia K via lldb-commits
ki.stfu added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:676-677 # If not found, disable the lldb-mi tests -lldbMiExec = None -if lldbtest_config.lldbExec and is_exe(lldbtest_config.lldbExec + "-mi"): -lldbMiExec =

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-11 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Heh. It just occurred to me that this is probably the reason why all of the `lldb-mi` tests fail on Windows. Because `.exe` is not appended. I'm not ready to turn that on and deal with

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. The test suite calls realpath on the lldb executable then append "-mi" to it to find the path of the lldb-mi executable. This does not work when using CMake builds on *nix platforms. On