This revision was automatically updated to reflect the committed changes.
Closed by commit rL294736: Convert Log class to llvm streams (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D29615?vs=87349&id=87978#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29615
Fi
labath added a comment.
Thank you for the review. I'll submit this tomorrow.
In https://reviews.llvm.org/D29615#670879, @clayborg wrote:
> Looks good as long as if we type two log enable commands like:
>
> (lldb) log enable -f /tmp/a.txt lldb process
> (lldb) log enable -f /tmp/a.txt lldb ap
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as if we type two log enable commands like:
(lldb) log enable -f /tmp/a.txt lldb process
(lldb) log enable -f /tmp/a.txt lldb api
share the same log stream (we don't
Aside from the thread stuff, nothing seems particularly risky about this
change. Did the thread-local stuff you removed have anything to do with
the -t option to the log command?
On Wed, Feb 8, 2017 at 9:15 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comme
labath added a comment.
Ping. Any thoughts on this?
https://reviews.llvm.org/D29615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> On Feb 6, 2017, at 7:19 PM, Pavel Labath via Phabricator via lldb-commits
> wrote:
>
> labath added a comment.
>
> The log callback gets passed down from the SB API (in the SBDebugger
> constructor, no less). My best guess is that it is (was?) used to display the
> debugger log in some IDE
labath added a comment.
The log callback gets passed down from the SB API (in the SBDebugger
constructor, no less). My best guess is that it is (was?) used to display the
debugger log in some IDE window.
Comment at: source/Core/StreamCallback.cpp:22
StreamCallback::StreamCal
zturner added a comment.
Where is the logging callback used? It seems rather odd that we would need to
notify someone every time a log message was generated.
Comment at: source/Core/StreamCallback.cpp:22
StreamCallback::StreamCallback(lldb::LogOutputCallback callback, void *
labath created this revision.
Herald added subscribers: mgorny, emaste.
This converts LLDB's logging to use llvm streams instead of
lldb_private::Stream and friends. The changes are mostly
straight-forward and amount to s/lldb_private::Stream/llvm::raw_ostream.
The part worth calling out is the r