clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Please add Xcode changes I sent you offline and this will be good to go.
https://reviews.llvm.org/D29964
___
lldb-commits mailing l
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks.
Really splitting hairs now, but could you also update the test to check for the
return value. :)
https://reviews.llvm.org/D29964
___
ll
zturner updated this revision to Diff 88626.
https://reviews.llvm.org/D29964
Files:
lldb/include/lldb/Host/PseudoTerminal.h
lldb/include/lldb/Utility/PseudoTerminal.h
lldb/include/lldb/Utility/VASPrintf.h
lldb/source/Host/CMakeLists.txt
lldb/source/Host/common/PseudoTerminal.cpp
lldb/
On Wed, Feb 15, 2017 at 5:54 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added inline comments.
>
>
>
> Comment at: lldb/source/Utility/VASprintf.cpp:18
> + va_list args) {
> + llvm::SmallString<16> error("");
> +
>
labath added inline comments.
Comment at: lldb/source/Utility/VASprintf.cpp:18
+ va_list args) {
+ llvm::SmallString<16> error("");
+
It doesn't look like you should need to allocate a stack object with the string
every time. Can't y
zturner created this revision.
Herald added subscribers: mgorny, srhines, danalbert.
This patch finally gets `lldbUtility` to be dependency-free. This was done
through the following changes:
1. `PseudoTerminal.cpp` : `Utility` -> `Host`
2. Introduce a `vasprintf` / `vsnprintf` wrapper into util
