stella.stamenova added a comment.
Since Visual Studio as a Generator supports multiple build configurations, each
of the CMakeLists.txt that correspond to lit tests also need to include
handling of the build mode unless you can guarantee that all the properties are
set correctly before
ted added a comment.
@JDevlieghere I'm seeing the same issue as @alberto_magni . The Visual Studio
cmake generator gives errors. We're reverting it internally, but it needs to be
fixed or reverted ASAP.
The issue could be this set of code from test/CMakeLists.txt:
configure_file(
alberto_magni added a comment.
Hi Jonas,
This change is causing a cmake generation-time error on Windows when using
Visual Studio as generator:
-G "Visual Studio 15 2017 Win64" -Thost=x64
The error is:
CMake Error in tools/lldb/test/CMakeLists.txt:
Evaluation file to be written multiple
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330275: [LIT] Have lit run the lldb test suite (authored by
JDevlieghere, committed by ).
Herald added a subscriber: jkorous.
Changed prior to commit:
JDevlieghere added a comment.
In https://reviews.llvm.org/D45333#1065332, @labath wrote:
> This looks good.
>
> Do you have any plans on how will this work with the XCode build (which is
> kind of a prerequisite to start removing stuff from dotest)?
I haven't spend too much time worrying
labath accepted this revision.
labath added a comment.
This looks good.
Do you have any plans on how will this work with the XCode build (which is
kind of a prerequisite to start removing stuff from dotest)?
https://reviews.llvm.org/D45333
___
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Sorry for getting in here late. This seems to be a great improvement on the
state of the art, and given it's only enabled for the CMake build, I see little
harm not going forward with it.
In
JDevlieghere added inline comments.
Comment at: lit/Suite/lldbtest.py:46
+cmd = self.dotest_cmd + [testPath, '-p', testName]
+print ' '.join(cmd)
+
labath wrote:
> It looks like `executeCommand` accepts a list of args for a command as well,
> so
JDevlieghere added a comment.
The only outstanding issue is calling `llvm-lit` with the path to the test
suite. Does anybody with more lit experience know how we can solve this?
https://reviews.llvm.org/D45333
___
lldb-commits mailing list
JDevlieghere updated this revision to Diff 142028.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
- Feedback Pavel
- Makes `check-lldb` invoke *only* lit.
https://reviews.llvm.org/D45333
Files:
lit/Suite/lit.cfg
lit/Suite/lit.site.cfg.in
labath added a comment.
In https://reviews.llvm.org/D45333#1058916, @JDevlieghere wrote:
> This isn't meant to be checked-in as is, however I'm looking for feedback as
> early as possible.
>
> There are currently two problems with the current diff:
>
> - `./bin/llvm-lit
JDevlieghere added a comment.
This isn't meant to be checked-in as is, however I'm looking for feedback as
early as possible.
There are currently two problems with the current diff:
- `./bin/llvm-lit ../llvm/tools/lldb/lit/Suite/` doesn't work, and I haven't
figured out why yet.
- We'd run
JDevlieghere created this revision.
JDevlieghere added reviewers: zturner, labath, davide, aprantl.
Herald added subscribers: llvm-commits, mgorny.
This is the initial attempt (v1) to run the lldb test suite with lit, using the
custom LLDB test format. Here every`Test*.py` is seen as a single
13 matches
Mail list logo
