[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

teemperor accepted this revision. teemperor added a comment. Closed by 365698 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64194/new/ https://reviews.llvm.org/D64194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64194/new/ https://reviews.llvm.org/D64194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:223 +// Returns true if this is the last token we get from the lexer. +exit = lex.LexFromRawLexer(token); +

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:223 +// Returns true if this is the last token we get from the lexer. +exit = lex.LexFromRawLexer(token); + Can we write this as

[Lldb-commits] [PATCH] D64194: [lldb] Fix crash due to unicode characters and dollars in variable names.

teemperor updated this revision to Diff 208569. teemperor retitled this revision from "[lldb] Fix crash due to dollar character in variable names." to "[lldb] Fix crash due to unicode characters and dollars in variable names.". teemperor edited the summary of this revision. teemperor added a