This revision was automatically updated to reflect the committed changes.
Closed by commit rG4bddca306a45: [MachO] Fix symbol merging during symtab
parsing. (authored by JDevlieghere).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68536/new/
JDevlieghere updated this revision to Diff 223688.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
Code review feedback Adrian.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68536/new/
https://reviews.llvm.org/D68536
Files:
aprantl added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3736
if (is_debug) {
switch (nlist.n_type) {
aprantl wrote:
> because of the early exit above — isn't this either always true or always
>
aprantl added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3736
if (is_debug) {
switch (nlist.n_type) {
because of the early exit above — isn't this either always true or always false?
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:3695
+ bool debug_only) {
+ const bool is_debug = ((nlist.n_type & N_STAB) != 0);
+ if (is_debug != debug_only)
JDevlieghere updated this revision to Diff 223641.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
Address code review feedback.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68536/new/
https://reviews.llvm.org/D68536
Files:
labath added subscribers: jankratochvil, kwk.
labath added a comment.
I don't know much about this stuff, but it seems relatively reasonable to me.
Tagging @kwk and @jankratochvil because they were involved in some elf symbol
merging discussions recently, and so they may find this interesting.
JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, jasonmolenda, labath, aprantl, friss.
Herald added a subscriber: abidh.
Herald added a project: LLDB.
The symtab parser in ObjectFileMachO has logic to coalesce debug (STAB) and
non-debug symbols, based on the address
