[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

labath added a comment. In D70886#1767654 , @aadsm wrote: > > Maybe you could do something similar to LocalLLDBInit.test ? > > That test uses the `lldb` `-S` (and others) flags that `lldb-vscode` doesn't > support :(. These flags should really be added to

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

clayborg added a comment. We could just add a new flag to lldb-vscode like "--no-lldb-init" and always pass that when we run our test suite? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70886/new/ https://reviews.llvm.org/D70886 __

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

aadsm added a comment. > Maybe you could do something similar to LocalLLDBInit.test ? That test uses the `lldb` `-S` (and others) flags that `lldb-vscode` doesn't support :(. These flags should really be added to the initialize packet but they're very specific to lldb and the DAP doesn't suppor

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

labath added a comment. In D70886#1765629 , @aadsm wrote: > The way phabricator shows the diff is tricky, this change has nothing to do > with D70882 and stands by itself. The > important part here is making the `g_vsc.d

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

aadsm added a comment. The way phabricator shows the diff is tricky, this change has nothing to do with D70882 and stands by itself. The important part here is making the `g_vsc.debugger.SetOutputFileHandle(out, true); g_vsc.debugger.SetErrorFileHandle(out, fal

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

clayborg added a comment. Abandon this one and modify https://reviews.llvm.org/D70882? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70886/new/ https://reviews.llvm.org/D70886 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1207-1210 + auto arguments = request.getObject("arguments"); + const auto skipInitFiles = GetBoolean(arguments, "skipInitFiles", false); + g_vsc.debugger = + lldb::SBDebugger::Create(!skipI

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Would be good to write a test for this where the init file does "script print('hello')" which would hose up the connection Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

aadsm created this revision. aadsm added reviewers: clayborg, lanza, wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We need to do this before we create the debugger because the commands run in the lldbinit might do output to these handlers as well. Repository: