[Lldb-commits] [PATCH] D77000: [lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs

2020-03-30 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D77000#1949247 , @aleksandr.urakov wrote: > Hello! But does the format of an exception directory for aarch64 differ > completely from x86-64 one? Can we somehow adopt the existing parser to > support it? If we can, I think

[Lldb-commits] [PATCH] D77000: [lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs

2020-03-30 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov added a comment. Hello! But does the format of an exception directory for aarch64 differ completely from x86-64 one? Can we somehow adopt the existing parser to support it? If we can, I think that this check looks good (we encapsulate the difference inside `PECallFrameInfo`).

[Lldb-commits] [PATCH] D77000: [lldb] [PECOFF] Check that PECallFrameInfo operates on the expected architecture before interpreting RuntimeFunction structs

2020-03-28 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo created this revision. mstorsjo added reviewers: labath, rnk, aleksandr.urakov. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: LLDB. Not sure how easy it is to make a sensible test for this; it makes a difference when the aarch64 RuntimeFunction struct,