[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fbac4e1a2f2: [nfc] [lldb] Unindent code (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2951 +type_sp = resolved_type->shared_from_this(); +break; } aprantl wrote: > I think

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255813. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255801. jankratochvil marked 4 inline comments as done. jankratochvil added a comment. Implemented all the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 10 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2016 +for (size_t i = 0; i < num_matches; ++i) { + const DIERef _ref = method_die_offsets[i];

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp:70 const dw_tag_t die_tag = die_info_array[i].tag; -if (die_tag != 0 && die_tag != DW_TAG_class_type && -die_tag != DW_TAG_structure_type) +if (!(die_tag == 0

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2016 +for (size_t i = 0; i < num_matches; ++i) { + const DIERef _ref = method_die_offsets[i]; DWARFDebugInfo _info

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

labath added a comment. Looks good to me, but let's wait for @shafik and @aprantl to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 ___

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255012. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files:

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 4 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp:70-71 const dw_tag_t die_tag = die_info_array[i].tag; -if (die_tag == 0 || die_tag == DW_TAG_class_type || -

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

clayborg added a comment. Does anyone know why harbormaster is useless? Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2014 -if (!method_die_offsets.empty()) { - DWARFDebugInfo _info = dwarf->DebugInfo(); kwk wrote:

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 254898. jankratochvil marked an inline comment as done. jankratochvil added a comment. I have checked in the really obvious parts as rG80237523193d . The remainder is left here -

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp:524 DIEInfoArray die_info_array; - if (FindByName(name, die_info_array)) -

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land. No need to split this into multiples revisions. It is just a rewrite of some odd nesting. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2943 +//

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

aprantl added a comment. In D77326#1958082 , @shafik wrote: > I feel like this should have been split in two. It feels like there are > straight forward obviously correct changes and a several others that require > some thinking about but look correct.

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

shafik added a comment. I feel like this should have been split in two. It feels like there are straight forward obviously correct changes and a several others that require some thinking about but look correct. Comment at:

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 254616. jankratochvil marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files:

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 6 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2014 -if (!method_die_offsets.empty()) { - DWARFDebugInfo _info = dwarf->DebugInfo();

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

aprantl added a comment. I am generally very okay with this change, though some changes look suspicious, as @kwk noted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

kwk added a comment. Overall looks good to me except for one larger logic change. Maybe a your comment can clarify this. The code was in a very bad shape before, given the countless amounts of shortcuts you could take. Comment at: