This revision was automatically updated to reflect the committed changes.
Closed by commit rG968cba8e89f7: lldbutil: add a retry mechanism for the ios
simulator (authored by aprantl).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D85542?vs=283995=284020#toc
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM with the comments addressed. Thanks for fixing this!
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:822
+# Unfortunate workaround for the
aprantl updated this revision to Diff 283995.
aprantl added a comment.
Address review feedback
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85542/new/
https://reviews.llvm.org/D85542
Files:
lldb/packages/Python/lldbsuite/test/lldbutil.py
Index:
aprantl added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:824
+while (retry and error.Fail() and
+ isinstance(error.GetCString(), six.string_types) and
+ "Unable to boot the Simulator" in error.GetCString()):
JDevlieghere added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:824
+while (retry and error.Fail() and
+ isinstance(error.GetCString(), six.string_types) and
+ "Unable to boot the Simulator" in error.GetCString()):
aprantl created this revision.
aprantl added reviewers: JDevlieghere, jingham, jasonmolenda, friss.
aprantl requested review of this revision.
We've been seeing this failure on green dragon when the system is under high
load. Unfortunately this is outside of LLDB's control.