[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9bfe8a75306: [lldb] [debugserver] Add stN aliases for stmmN for compatibility (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny added a comment. I suppose this has waited long enough to deserve another test run. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

labath added a comment. In D91847#2410723 , @krytarowski wrote: > I would mark stmmX as an alias to stX and keep stX as the default for all > platforms. stmmX could be an alias for everybody for legacy reasons. Possibly. Though we could also do that late

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is fine -- sorry this dropped off my radar. @jasonmolenda, do you have any thoughts about this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny updated this revision to Diff 307021. mgorny added a comment. Added `system-debugserver` feature to skip tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847 Files: lldb/test/API/commands/register/register/register_command/TestRegiste

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

krytarowski added a comment. I would mark stmmX as an alias to stX and keep stX as the default for all platforms. stmmX could be an alias for everybody for legacy reasons. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny added a comment. In D91847#2410564 , @labath wrote: > Still looks good to me. :) Jason, do you have any concerns? > > Unfortunately, we still need a `@skipIfOutOfTreeDebugserver` equivalent Long term, probably yes. Short term, the tests are bro

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny updated this revision to Diff 306986. mgorny added a comment. Rebase and fix TestRegisters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847 Files: lldb/test/API/commands/register/register/register_command/TestRegisters.py lldb/test/Sh

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

labath added a comment. Still looks good to me. :) Jason, do you have any concerns? Unfortunately, we still need a `@skipIfOutOfTreeDebugserver` equivalent CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91847/new/ https://reviews.llvm.org/D91847

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny updated this revision to Diff 306751. mgorny edited the summary of this revision. mgorny added a comment. Added aliases to all regsets, not just the first ones. Updated test status. amd64 tests still fail due to missing `fip`/`fdp`. I wonder how hard would it be to port it to Darwin. CH

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

labath added a reviewer: jasonmolenda. labath added a comment. Thanks for doing this. The changes look pretty straight-forward. The main thing I think is missing here is the shelltest equivalent of `@skipIfOutOfTreeDebugserver` -- most people build/test lldb with the system debug server (becaus

[Lldb-commits] [PATCH] D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, JDevlieghere. Herald added a subscriber: pengfei. mgorny requested review of this revision. Add stN aliases for the FPU (stmmN) registers on MacOSX. This should improve compatibility between MacOSX and other platfo