[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Revert the whitespace only changes to the .py file and good to go as long as all vscode tests are passing. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vs

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko updated this revision to Diff 390182. serhiy.redko edited the summary of this revision. serhiy.redko added a comment. As requested DAP now reports an error in case debug configuration contains unused target related keys ("program", "coreFile" etc) along with "launchCommands" or "a

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko updated this revision to Diff 380298. serhiy.redko added a comment. - return error in case debug configuration contains incompatible fields with 'launchCommands'/'attachCommands' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94997/new/ https://reviews.llvm.org/D94997 File

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:627-628 + "incompatible with 'attachCommands'.\n", arg.str().c_str()); + } +} +// Run any pre run LLDB commands the user specified in the launch.json clay

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I am fine overall with this change because of goofy things that can happen when we always create a target. We might think about returning an error if the user specifies "launchCo

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko updated this revision to Diff 378575. serhiy.redko added a comment. - added printing of unused target related fields from launch.json in case launchCommands/attachCommands fields are provided. - updated help info in for launch/attach fields according to review request. CHANGES SINC

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg added a comment. In D94997#2509175 , @tatyana-krasnukha wrote: > D92164 was intended for fixing the > "settings set" issue, however, it revealed some deadlocks and data races, and > had to be reverted temporari

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg added a comment. In D94997#2510144 , @serhiy.redko wrote: > Thanks for review and your input, @clayborg > >> So I agree we need to fix the "settings set" issue as it surfaces a quirk in >> the order and number of targets we create. The main ques

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

aadsm added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1558 + if (!launchCommands.empty()) { +// if "launchCommands" are provided, then they are expected to make the +// launch happen for launch requests and they replace the normal logic that ---

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko planned changes to this revision. serhiy.redko added a comment. Thanks for review and your input, @clayborg > So I agree we need to fix the "settings set" issue as it surfaces a quirk in > the order and number of targets we create. The main questions is if we care > that we don't a

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

tatyana-krasnukha added a comment. D92164 was intended for fixing the "settings set" issue, however, it revealed some deadlocks and data races, and had to be reverted temporarily. Currently, I'm working on those multithreading issues and will submit a patch as

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg added a comment. Another solution would be to not auto create a target if the "program" argument is missing from the launch config and document this in the "attachCommands" or "launchCommands"? Or is "program" a required launch config argument? Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We have iterated on this patch and talked about the ramifications prior to posting this public patch. I will start with a little history: I added "launchCommands" a long time ago

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

serhiy.redko created this revision. serhiy.redko requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. launch.json's fields have ambiguity with how final target is created:  1. There are dedicated fields to specify target like "program", "pid",