Re: [Lldb-commits] [lldb] r320240 - Update PlatformDarwin::GetDeveloperDir to handle the two

2017-12-21 Thread Davide Italiano via lldb-commits
No worries! Do you want me to assign a PR/radar to you? Thanks! -- Davide On Thu, Dec 21, 2017 at 5:41 PM, Jason Molenda wrote: > Yeah I need to see if I can write a unit test instantiating the platform and > changing the values that HostInfo::GetLLDBPath returns to

Re: [Lldb-commits] [lldb] r320240 - Update PlatformDarwin::GetDeveloperDir to handle the two

2017-12-21 Thread Jason Molenda via lldb-commits
Yeah I need to see if I can write a unit test instantiating the platform and changing the values that HostInfo::GetLLDBPath returns to synthetic values, but I haven’t had time to look at that yet. > On Dec 21, 2017, at 7:01 AM, Davide Italiano via lldb-commits >

Re: [Lldb-commits] [lldb] r320240 - Update PlatformDarwin::GetDeveloperDir to handle the two

2017-12-21 Thread Davide Italiano via lldb-commits
Jason, any chance we can write a test case for this? -- Davide On Mon, Dec 11, 2017 at 12:52 AM, Davide Italiano wrote: > Testcase? > > On Fri, Dec 8, 2017 at 7:06 PM, Jason Molenda via lldb-commits > wrote: >> Author: jmolenda >> Date: Fri

Re: [Lldb-commits] [lldb] r320240 - Update PlatformDarwin::GetDeveloperDir to handle the two

2017-12-10 Thread Davide Italiano via lldb-commits
Testcase? On Fri, Dec 8, 2017 at 7:06 PM, Jason Molenda via lldb-commits wrote: > Author: jmolenda > Date: Fri Dec 8 19:06:19 2017 > New Revision: 320240 > > URL: http://llvm.org/viewvc/llvm-project?rev=320240=rev > Log: > Update PlatformDarwin::GetDeveloperDir to