tberghammer added a comment.
In http://reviews.llvm.org/D11465#300606, @labath wrote:
> In http://reviews.llvm.org/D11465#300581, @jingham wrote:
>
> > It seems like an awful lot of logic is duplicated between the POSIX &
> > Android versions of LoadImage when all that really changes is the name
labath added a subscriber: labath.
labath added a comment.
In http://reviews.llvm.org/D11465#300581, @jingham wrote:
> It seems like an awful lot of logic is duplicated between the POSIX & Android
> versions of LoadImage when all that really changes is the name of the
> function you are calling
jingham added a subscriber: jingham.
jingham added a comment.
It seems like an awful lot of logic is duplicated between the POSIX & Android
versions of LoadImage when all that really changes is the name of the function
you are calling. Is it possible to centralize this some more?
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254504: Fix "process load/unload" on android (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D11465?vs=41491&id=41608#toc
Repository:
rL LLVM
http://reviews.llvm.org/D114
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D11465
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
tberghammer added inline comments.
Comment at: test/functionalities/load_unload/TestLoadUnload.py:201-204
@@ -205,7 +200,6 @@
-if lldb.remote_platform:
-dylibName = os.path.join(shlib_dir, 'libloadunload_a.so')
-elif self.platformIsDarwin():
+
tberghammer updated this revision to Diff 41491.
http://reviews.llvm.org/D11465
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py
source/API/SBProcess.cpp
source/Commands/CommandObjectProcess.
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41490.
tberghammer added a comment.
Herald added a subscriber: emaste.
Address review comments
http://reviews.llvm.org/D11465
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
pa
