Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-24 Thread Greg Clayton via lldb-commits
clayborg added a comment. Each shared library is an object that can be shared between multiple targets. We do not want to injecting types from another shared library into the static notion of what a type is within a shared library. Why? What if one target in lldb loads liba.so which has a

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-24 Thread Zachary Turner via lldb-commits
Also,when you say the next iteration, is this something that is going to happen at an unknown time in the future whenever you happen to touch it again, or are you working on another iteration now? On Thu, Sep 24, 2015 at 4:25 PM Zachary Turner wrote: > To be clear, I would

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-24 Thread Zachary Turner via lldb-commits
zturner added a comment. To be clear, I would like this Makefile to turn into the following: LEVEL = ../../../make CXX_SOURCES = main.cpp length.cpp DEBUG_INFO_FULL = True DEBUG_INFO_LIMITED = True And that's it. You shouldn't need anything else. Whatever needs to happen in Makefile.rules

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-24 Thread Zachary Turner via lldb-commits
To be clear, I would like this Makefile to turn into the following: LEVEL = ../../../make CXX_SOURCES = main.cpp length.cpp DEBUG_INFO_FULL = True DEBUG_INFO_LIMITED = True And that's it. You shouldn't need anything else. Whatever needs to happen in Makefile.rules to make this work should be

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-24 Thread Zachary Turner via lldb-commits
zturner added a comment. I know, I've seen them in a few places myself. But I think we should move away from that, because it's a large source of portability problems http://reviews.llvm.org/D13066 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-23 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as the test suite if happy. http://reviews.llvm.org/D13066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-23 Thread Siva Chandra via lldb-commits
sivachandra added inline comments. Comment at: test/lang/cpp/incomplete-types/Makefile:8 @@ +7,3 @@ + +ifneq (,$(findstring clang,$(CC))) + CFLAGS_LIMIT += -flimit-debug-info dblaikie wrote: > In case it's interesting, you can get similarly problematic DWARF by

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-23 Thread David Blaikie via lldb-commits
dblaikie added a subscriber: dblaikie. Comment at: test/lang/cpp/incomplete-types/Makefile:8 @@ +7,3 @@ + +ifneq (,$(findstring clang,$(CC))) + CFLAGS_LIMIT += -flimit-debug-info In case it's interesting, you can get similarly problematic DWARF by using a

Re: [Lldb-commits] [PATCH] D13066: DWARFASTParserClang::CompleteTypeFromDWARF: Handle incomplete baseclass or child

2015-09-22 Thread Siva Chandra via lldb-commits
sivachandra added a comment. I am not sure how portable my Makefile is. I have no idea if it will work on Windows for example. http://reviews.llvm.org/D13066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org