tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:592
@@ +591,3 @@
+{
+if (!is_complex)
+{
Please check that "float_count == 1" as well (we don't want to use this
zturner added a comment.
In http://reviews.llvm.org/D16936#346293, @tberghammer wrote:
> In http://reviews.llvm.org/D16936#346182, @labath wrote:
>
> > I agree with the idea in general, but I wanted to ask what is your plan
> > with the android decorators: For them we use the additional
mamai added a comment.
Scalar::operator<<= works well as-is because it uses APInt
<<=(unsigned shiftAmt), whereas the right shift equivalent is not
implemented. Should I add APInt >>=, or should I change
Scalar::operator<<= for consistency ?
Repository:
rL LLVM
Author: labath
Date: Mon Feb 8 03:35:53 2016
New Revision: 260078
URL: http://llvm.org/viewvc/llvm-project?rev=260078=rev
Log:
Have lldb-server log the timestamp in its log messages
Modified:
lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
Modified:
labath added a subscriber: labath.
labath added a comment.
Do we have a test for this?
If not, it sounds like it would be an easy thing to add one.
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath accepted this revision.
labath added a comment.
I agree with the idea in general, but I wanted to ask what is your plan with
the android decorators: For them we use the additional `api_levels` flag, which
does not exist on other platforms/decorators. I suppose we could add that flag
to
labath added a comment.
Nevermind, I now see you mention TestReturnValue. :/
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Mon Feb 8 03:58:27 2016
New Revision: 260081
URL: http://llvm.org/viewvc/llvm-project?rev=260081=rev
Log:
Revert "Enable test_lldbmi_settings_set_target_run_args_before on linux"
Test is still flaky.
Modified:
Author: sivachandra
Date: Mon Feb 8 20:18:50 2016
New Revision: 260192
URL: http://llvm.org/viewvc/llvm-project?rev=260192=rev
Log:
[TestExprsChar] Fix a typo is failure archs list
Reviewers: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D17014
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260192: [TestExprsChar] Fix a typo is failure archs list
(authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D17014?vs=47283=47284#toc
Repository:
rL LLVM
Author: enrico
Date: Mon Feb 8 23:46:47 2016
New Revision: 260199
URL: http://llvm.org/viewvc/llvm-project?rev=260199=rev
Log:
Fix an issue where pressing CTRL+C in the interactive script interpreter causes
LLDB to crash
This is because PyThreadState_Get() assumes a non-NULL thread state and
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D17014
Files:
packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py
Index:
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
In http://reviews.llvm.org/D16936#346182, @labath wrote:
> I agree with the idea in general, but I wanted to ask what is your plan with
> the android decorators: For them we use the additional `api_levels` flag,
> which
labath added a comment.
`Scalar::operator<<=` seems to do a `m_integer <<= ...`. Will it suffer from
the same recursion problem?
In any case, I think the implementations of both methods should use the same
API (it doesn't matter which one if both work).
Also it would be super great if you
mamai added reviewers: labath, tberghammer.
mamai updated this revision to Diff 47190.
Repository:
rL LLVM
http://reviews.llvm.org/D16868
Files:
source/Core/Scalar.cpp
Index: source/Core/Scalar.cpp
===
---
omjavaid updated this revision to Diff 47191.
omjavaid added a comment.
updated diff after incorporating suggested corrections.
http://reviews.llvm.org/D16975
Files:
source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp
Index: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp
omjavaid added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:581-591
@@ -580,10 +580,13 @@
{
size_t byte_size = compiler_type.GetByteSize();
if (byte_size <= 4)
{
RegisterValue r0_reg_value;
tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:597
@@ +596,3 @@
+{
+if (base_type.IsFloatingPointType(float_count, is_complex))
+{
omjavaid wrote:
> tberghammer
omjavaid updated this revision to Diff 47198.
omjavaid added a comment.
Updated adding float_count check.
http://reviews.llvm.org/D16975
Files:
source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp
Index: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp
tberghammer added inline comments.
Comment at: source/Plugins/ABI/SysV-arm/ABISysV_arm.cpp:581-591
@@ -580,10 +580,13 @@
{
size_t byte_size = compiler_type.GetByteSize();
if (byte_size <= 4)
{
RegisterValue r0_reg_value;
tfiala accepted this revision.
tfiala added a comment.
LGTM.
Regarding the section Pavel was looking at, on the Apple side we have a
simulator target that is not technically remote, but isn't really local either.
I'll have to look at that if/when we actually want to mark a simulator test as
tberghammer added a comment.
In http://reviews.llvm.org/D16936#346536, @tfiala wrote:
> > I agree but I also might consider going further where the only thing you
> > can specify is a function and we remove all arguments. Then we implement
> > functions like architectureMatches,
labath added a comment.
Ah, ok I understand what's going on now. I guess APInt operator >> probably
does not exist because it would be ambiguous (arithmetic or bitwise shift?).
Let's just leave this as it is now.
Could you add that test though?
Repository:
rL LLVM
zturner added a comment.
I'm not opposed to it in principle, but I think we should optimize the design
for conciseness at the point where you decorate a class or function. If it
makes the point of decoration more verbose or harder to read, then I would
probably be against it. I guess I'd
tberghammer created this revision.
tberghammer added a reviewer: clayborg.
tberghammer added a subscriber: lldb-commits.
Improve the handling of missing elf symtab and missing symbol sizes
* Generate artificial symbol names from eh_fame during symbol parsing
so these symbols are already
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260135: A number of improvements to decorator conditionals.
(authored by zturner).
Changed prior to commit:
http://reviews.llvm.org/D16938?vs=47068=47233#toc
Repository:
rL LLVM
tfiala added a comment.
> I agree but I also might consider going further where the only thing you can
> specify is a function and we remove all arguments. Then we implement
> functions like architectureMatches, targetOsMatches, hostOsMatches, etc.. and
> some logical function what can combine
mamai updated this revision to Diff 47218.
mamai added a comment.
Added a small unit test for scalar right shift operator, which invokes the >>=
operator.
Repository:
rL LLVM
http://reviews.llvm.org/D16868
Files:
source/Core/Scalar.cpp
unittests/CMakeLists.txt
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I am fine as long as tberghammer is happy.
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Make sure we use a consistent naming scheme for symbols that don't have names
between all ObjectFile subclasses.
Comment at:
Author: zturner
Date: Mon Feb 8 18:36:22 2016
New Revision: 260176
URL: http://llvm.org/viewvc/llvm-project?rev=260176=rev
Log:
Remove the skipUnlessArch decorator.
Convert everything over to using skipIf.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
Author: zturner
Date: Mon Feb 8 18:36:34 2016
New Revision: 260178
URL: http://llvm.org/viewvc/llvm-project?rev=260178=rev
Log:
Remove skip and xfail decorators for target architecture.
This removes the following decorators:
* skipIfI386
* expectedFailureI386
* expectedFailurex86_64
*
Author: zturner
Date: Mon Feb 8 18:36:27 2016
New Revision: 260177
URL: http://llvm.org/viewvc/llvm-project?rev=260177=rev
Log:
Remove skipIfHostPlatform and skipUnlessHostPlatform decorators.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/decorators.py
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
In http://reviews.llvm.org/D16936#346594, @zturner wrote:
> I'm not opposed to it in principle, but I think we should optimize the design
> for conciseness at the point where you decorate a class or function. If it
> makes the point of decoration more verbose or
35 matches
Mail list logo
